Skip to content

Commit

Permalink
[VCN] Update enrollment dialog card label
Browse files Browse the repository at this point in the history
Add "Linked with" prefix to enrollment dialog card label.

Mock: https://screenshot.googleplex.com/9AiAnWC9dZ43pXu.png
Current implementation: https://screenshot.googleplex.com/6dSKcSU65ydApy4.png
New implementation: https://screenshot.googleplex.com/73WHDpi2Mtg6rdi

(cherry picked from commit 0102f5b)

Bug: 1323930
Change-Id: Ic5090a4eaa4a7886b2ac16717785b5275bcc700c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3654556
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Siddharth Shah <siashah@chromium.org>
Commit-Queue: Vishwas Uppoor <vishwasuppoor@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1006295}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3665278
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Krishna Govind <govind@chromium.org>
Auto-Submit: Vishwas Uppoor <vishwasuppoor@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Owners-Override: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#243}
Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
  • Loading branch information
Vishwas Uppoor authored and Chromium LUCI CQ committed May 25, 2022
1 parent a26d5d9 commit d1a1919
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,9 @@ private View getCustomViewForModalDialog() {
issuerLegalMessageTextView.setMovementMethod(LinkMovementMethod.getInstance());

((TextView) customView.findViewById(R.id.credit_card_identifier))
.setText(mVirtualCardEnrollmentFields.getCardIdentifierString());
.setText(mContext.getString(
R.string.autofill_virtual_card_enrollment_dialog_card_label,
mVirtualCardEnrollmentFields.getCardIdentifierString()));
((ImageView) customView.findViewById(R.id.credit_card_issuer_icon))
.setImageBitmap(mVirtualCardEnrollmentFields.getIssuerCardArt());
return customView;
Expand Down
3 changes: 3 additions & 0 deletions chrome/browser/ui/android/strings/android_chrome_strings.grd
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,9 @@ CHAR_LIMIT guidelines:
<message name="IDS_AUTOFILL_VIRTUAL_CARD_ENROLLMENT_DIALOG_CARD_CONTAINER_TITLE" desc="Text describing how the virtual card will be shown to the user in autofill suggestions.">
Virtual card
</message>
<message name="IDS_AUTOFILL_VIRTUAL_CARD_ENROLLMENT_DIALOG_CARD_LABEL" desc="Notifies the user that their virtual card card is linked with a card on their account.">
Linked with <ph name="CARD_DETAIL">%1$s<ex>Visa ....1234</ex></ph>
</message>
<message name="IDS_AUTOFILL_VIRTUAL_CARD_ENROLLMENT_INFOBAR_CARD_PREFIX" desc="Notifies the user that their virtual card card is linked with a card on their account.">
linked with
</message>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
5bda7bb2e14e432c2d15a3feb6d69104357ffd4d

0 comments on commit d1a1919

Please sign in to comment.