Skip to content

Commit

Permalink
Roll inspector_protocol to 9b24bffce6e26dee406081ebe0854da6e68301ae
Browse files Browse the repository at this point in the history
This removes SerializerTraits which are no longer used.

Change-Id: Ie8d252f21cd055217408d2c1c347abe34c0c8270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3265551
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Peter Kvitek <kvitekp@chromium.org>
Cr-Commit-Position: refs/heads/main@{#939547}
  • Loading branch information
caseq authored and Chromium LUCI CQ committed Nov 8, 2021
1 parent 0d6140b commit d1c87fd
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 409 deletions.
22 changes: 0 additions & 22 deletions third_party/blink/renderer/core/inspector/v8_inspector_string.h
Expand Up @@ -15,11 +15,9 @@
#include "third_party/blink/renderer/platform/wtf/text/string_hash.h"
#include "third_party/blink/renderer/platform/wtf/text/string_view.h"
#include "third_party/blink/renderer/platform/wtf/text/wtf_string.h"
#include "third_party/inspector_protocol/crdtp/cbor.h"
#include "third_party/inspector_protocol/crdtp/maybe.h"
#include "third_party/inspector_protocol/crdtp/protocol_core.h"
#include "third_party/inspector_protocol/crdtp/serializable.h"
#include "third_party/inspector_protocol/crdtp/serializer_traits.h"
#include "v8/include/v8-inspector.h"
#include "v8/include/v8-script.h"

Expand Down Expand Up @@ -111,26 +109,6 @@ struct hash<WTF::String> {

// See third_party/inspector_protocol/crdtp/serializer_traits.h.
namespace crdtp {
template <>
struct SerializerTraits<WTF::String> {
static void Serialize(const WTF::String& str, std::vector<uint8_t>* out) {
if (str.length() == 0) {
cbor::EncodeString8(span<uint8_t>(nullptr, 0), out); // Empty string.
return;
}
if (str.Is8Bit()) {
cbor::EncodeFromLatin1(
span<uint8_t>(reinterpret_cast<const uint8_t*>(str.Characters8()),
str.length()),
out);
return;
}
cbor::EncodeFromUTF16(
span<uint16_t>(reinterpret_cast<const uint16_t*>(str.Characters16()),
str.length()),
out);
}
};

template <>
struct ProtocolTypeTraits<WTF::String> {
Expand Down
2 changes: 0 additions & 2 deletions third_party/inspector_protocol/BUILD.gn
Expand Up @@ -22,7 +22,6 @@ component("crdtp") {
"crdtp/protocol_core.h",
"crdtp/serializable.cc",
"crdtp/serializable.h",
"crdtp/serializer_traits.h",
"crdtp/span.cc",
"crdtp/span.h",
"crdtp/status.cc",
Expand Down Expand Up @@ -65,7 +64,6 @@ source_set("crdtp_test") {
"crdtp/maybe_test.cc",
"crdtp/protocol_core_test.cc",
"crdtp/serializable_test.cc",
"crdtp/serializer_traits_test.cc",
"crdtp/span_test.cc",
"crdtp/status_test.cc",
"crdtp/status_test_support.cc",
Expand Down
2 changes: 1 addition & 1 deletion third_party/inspector_protocol/README.chromium
Expand Up @@ -2,7 +2,7 @@ Name: inspector protocol
Short Name: inspector_protocol
URL: https://chromium.googlesource.com/deps/inspector_protocol/
Version: 0
Revision: 0e6e70f78b7f0445de6d69107b341540c92ad091
Revision: 9bb056c1285ddd32b5f7daee5a440d2554a165b9
License: BSD
License File: LICENSE
Security Critical: yes
Expand Down
158 changes: 0 additions & 158 deletions third_party/inspector_protocol/crdtp/serializer_traits.h

This file was deleted.

0 comments on commit d1c87fd

Please sign in to comment.