Skip to content

Commit

Permalink
Revert CPUUSED back to '6' for VP9 in CRD
Browse files Browse the repository at this point in the history
Details are in the bug but basically I see a decent increase in network
traffic for certain encoding workloads. There is also some variability
in the performance gains which means it's safer to revert back to the
original value used for CPUUSED in VP9 and then add a client-side toggle
to allow users to adjust this value for their network and workload.

(cherry picked from commit a28f874)

Bug: 1328377
Change-Id: I5bbde5c20d6c72b5c138c71d75f59d89c85d6146
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3661377
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1006591}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3665421
Cr-Commit-Position: refs/branch-heads/5060@{#227}
Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
  • Loading branch information
joedow-42 authored and Chromium LUCI CQ committed May 24, 2022
1 parent 656c87c commit d5a3ec0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion remoting/codec/webrtc_video_encoder_vpx.cc
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ void SetVp9CodecOptions(vpx_codec_ctx_t* codec, bool lossless_encode) {
// Request the lowest-CPU usage that VP9 supports, which depends on whether
// we are encoding lossy or lossless.
// Note that this knob uses the same parameter name as VP8.
int cpu_used = lossless_encode ? 5 : 8;
int cpu_used = lossless_encode ? 5 : 6;
vpx_codec_err_t ret = vpx_codec_control(codec, VP8E_SET_CPUUSED, cpu_used);
DCHECK_EQ(VPX_CODEC_OK, ret) << "Failed to set CPUUSED";

Expand Down

0 comments on commit d5a3ec0

Please sign in to comment.