Skip to content

Commit

Permalink
[CodeHealth] Replace DictionaryValue::GetString in /chrome/browser/as…
Browse files Browse the repository at this point in the history
…h/file_system_provider.

This CL was uploaded by git cl split.

R=joelhockey@chromium.org

Bug: 1187036
Change-Id: I2e94810ebe9fc191742f57eb897e601eca4944db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3829626
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Auto-Submit: Brian Begnoche <bcb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1034937}
  • Loading branch information
brianbegnoche authored and Chromium LUCI CQ committed Aug 15, 2022
1 parent afad9ed commit d5d9acb
Showing 1 changed file with 17 additions and 14 deletions.
31 changes: 17 additions & 14 deletions chrome/browser/ash/file_system_provider/operations/get_metadata.cc
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,19 @@ bool ConvertRequestValueToFileInfo(std::unique_ptr<RequestValue> value,
std::make_unique<int64_t>(static_cast<int64_t>(*params->metadata.size));

if (fields & ProvidedFileSystemInterface::METADATA_FIELD_MODIFICATION_TIME) {
std::string input_modification_time;
params->metadata.modification_time->additional_properties.GetString(
"value", &input_modification_time);

// Allow to pass invalid modification time, since there is no way to verify
// it easily on any earlier stage.
base::Time output_modification_time;
std::ignore = base::Time::FromString(input_modification_time.c_str(),
&output_modification_time);
output->modification_time =
std::make_unique<base::Time>(output_modification_time);
const std::string* input_modification_time =
params->metadata.modification_time->additional_properties.GetDict()
.FindString("value");

if (input_modification_time) {
// Allow to pass invalid modification time, since there is no way to
// verify it easily on any earlier stage.
base::Time output_modification_time;
std::ignore = base::Time::FromString(input_modification_time->c_str(),
&output_modification_time);
output->modification_time =
std::make_unique<base::Time>(output_modification_time);
}
}

if (fields & ProvidedFileSystemInterface::METADATA_FIELD_MIME_TYPE &&
Expand Down Expand Up @@ -103,9 +105,10 @@ bool ValidateIDLEntryMetadata(
if (fields & ProvidedFileSystemInterface::METADATA_FIELD_MODIFICATION_TIME) {
if (!metadata.modification_time)
return false;
std::string input_modification_time;
if (!metadata.modification_time->additional_properties.GetString(
"value", &input_modification_time)) {
const std::string* input_modification_time =
metadata.modification_time->additional_properties.GetDict().FindString(
"value");
if (!input_modification_time) {
return false;
}
}
Expand Down

0 comments on commit d5d9acb

Please sign in to comment.