Skip to content

Commit

Permalink
Reactivate deflaked keyboard accessory tests
Browse files Browse the repository at this point in the history
After having landed https://crrev.com/c/1028230, the problems of the
linked bug seem to have gone (as assumed).

I removed the Disabling and RetryOnFailure annotations to test on 3
devices (one physical, two emulator with different screen sizes and OS)
and couldn't find a single broken test.
Edit: I changed the font size recently (not finally) which seems to
bother some bots - unrelated from the filed bug. Changed that back.

This CL now reenables all the tests but keeps the RetryOnFailure
annotation. That way, I can test whether the tests start failing on
some bots again without making the sheriffs life harder.
If the bots don't notice any flakiness, I will remove the
RetryOnFailure annotation as well and mark the linked bug fixed.

Bug: 838922
Change-Id: I9781e6d820ac39e43435ad1529da817601967ed4
Reviewed-on: https://chromium-review.googlesource.com/1044371
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556798}
  • Loading branch information
FHorschig authored and Commit Bot committed May 8, 2018
1 parent 86b1e8b commit dc92f9d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion chrome/android/java/res/values/dimens.xml
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
<dimen name="keyboard_accessory_height">36dp</dimen>
<dimen name="keyboard_accessory_padding">4dp</dimen>
<dimen name="keyboard_accessory_sheet_height">200dp</dimen>
<dimen name="keyboard_accessory_text_size">6sp</dimen>
<dimen name="keyboard_accessory_text_size">10sp</dimen>

<!-- Password generation popup dimensions -->
<dimen name="password_generation_divider_height">1dp</dimen>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@

import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.MinAndroidSdkLevel;
import org.chromium.base.test.util.RetryOnFailure;
Expand Down Expand Up @@ -127,7 +126,6 @@ public void testAutofocusedFieldDoesNotShowKeyboardAccessory()
@Test
@MediumTest
@Feature({"keyboard-accessory"})
@DisabledTest(message = "crbug.com/838922")
public void testTapInputFieldShowsKeyboardAccessory()
throws ExecutionException, InterruptedException, TimeoutException {
loadTestPage(false);
Expand All @@ -146,7 +144,6 @@ public void testTapInputFieldShowsKeyboardAccessory()
@Test
@MediumTest
@Feature({"keyboard-accessory"})
@DisabledTest(message = "crbug.com/836027")
public void testSwitchFieldsRescrollsKeyboardAccessory()
throws ExecutionException, InterruptedException, TimeoutException {
loadTestPage(false);
Expand Down Expand Up @@ -176,7 +173,6 @@ public void testSwitchFieldsRescrollsKeyboardAccessory()
@MediumTest
@Feature({"keyboard-accessory"})
@MinAndroidSdkLevel(Build.VERSION_CODES.JELLY_BEAN_MR1)
@DisabledTest(message = "crbug.com/836027")
public void testSwitchFieldsRescrollsKeyboardAccessoryRtl()
throws ExecutionException, InterruptedException, TimeoutException {
loadTestPage(true);
Expand Down

0 comments on commit dc92f9d

Please sign in to comment.