Skip to content

Commit

Permalink
[Files app] Ducks: reducer migration: current directory
Browse files Browse the repository at this point in the history
Bug: b:295777015
Test: CQ passes
Change-Id: Icc84888fa8176e0457bf0ca59b5284405fb5b041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4806862
Auto-Submit: Marcello Salomao <msalomao@google.com>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Marcello Salomao <msalomao@google.com>
Cr-Commit-Position: refs/heads/main@{#1188190}
  • Loading branch information
Marcello Salomao authored and Chromium LUCI CQ committed Aug 25, 2023
1 parent 2618239 commit df917da
Show file tree
Hide file tree
Showing 22 changed files with 484 additions and 515 deletions.
2 changes: 1 addition & 1 deletion chrome/browser/ash/file_manager/file_manager_jstest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ IN_PROC_BROWSER_TEST_F(FileManagerJsTest, ReducerFolderShortcuts) {
}

IN_PROC_BROWSER_TEST_F(FileManagerJsTest, ReducerCurrentDirectory) {
RunTestURL("state/reducers/current_directory_unittest.js");
RunTestURL("state/ducks/current_directory_unittest.js");
}

IN_PROC_BROWSER_TEST_F(FileManagerJsTest, ReducerNavigation) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {SEARCH_RESULTS_KEY} from '../common/js/url_constants.js';
import {str, util} from '../common/js/util.js';
import {VolumeManagerCommon} from '../common/js/volume_manager_types.js';
import {PathComponent, PropStatus, State} from '../externs/ts/state.js';
import {changeDirectory} from '../state/actions/current_directory.js';
import {changeDirectory} from '../state/ducks/current_directory.js';
import {FileKey} from '../state/file_key.js';
import {getStore, Store} from '../state/store.js';
import {BreadcrumbClickedEvent, XfBreadcrumb} from '../widgets/xf_breadcrumb.js';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ import {MetadataModel} from '../foreground/js/metadata/metadata_model.js';
import {Command} from '../foreground/js/ui/command.js';
import {contextMenuHandler} from '../foreground/js/ui/context_menu_handler.js';
import {Menu} from '../foreground/js/ui/menu.js';
import {changeDirectory} from '../state/actions/current_directory.js';
import {readSubDirectories} from '../state/actions_producers/all_entries.js';
import {changeDirectory} from '../state/ducks/current_directory.js';
import {refreshNavigationRoots, updateNavigationEntry} from '../state/ducks/navigation.js';
import {driveRootEntryListKey} from '../state/ducks/volumes.js';
import {convertEntryToFileData} from '../state/reducers/all_entries.js';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {CurrentDirectory, PropStatus, SearchData, SearchLocation, SearchOptions,
import {VolumeManager} from '../externs/volume_manager.js';
import {PathComponent} from '../foreground/js/path_component.js';
import {SearchAutocompleteList} from '../foreground/js/ui/search_autocomplete_list.js';
import {changeDirectory} from '../state/actions/current_directory.js';
import {changeDirectory} from '../state/ducks/current_directory.js';
import {clearSearch, getDefaultSearchOptions, updateSearch} from '../state/ducks/search.js';
import {FileKey} from '../state/file_key.js';
import {getStore, Store} from '../state/store.js';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {PropStatus, SearchLocation, SearchOptions, State} from '../../externs/ts
import {Store} from '../../externs/ts/store.js';
import {VolumeInfo} from '../../externs/volume_info.js';
import {VolumeManager} from '../../externs/volume_manager.js';
import {changeDirectory} from '../../state/actions/current_directory.js';
import {changeDirectory} from '../../state/ducks/current_directory.js';
import {updateSearch} from '../../state/ducks/search.js';
import {getStore} from '../../state/store.js';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import {NativeEventTarget as EventTarget} from 'chrome://resources/ash/common/event_target.js';

import {Store} from '../../externs/ts/store.js';
import {updateDirectoryContent, updateSelection} from '../../state/actions/current_directory.js';
import {updateDirectoryContent, updateSelection} from '../../state/ducks/current_directory.js';

import {FileSelection, FileSelectionHandler} from './file_selection.js';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {FakeEntry, FilesAppDirEntry, FilesAppEntry} from '../../externs/files_ap
import {State} from '../../externs/ts/state.js';
import {VolumeInfo} from '../../externs/volume_info.js';
import {VolumeManager} from '../../externs/volume_manager.js';
import {changeDirectory} from '../../state/actions/current_directory.js';
import {changeDirectory} from '../../state/ducks/current_directory.js';
import {getFileData, getStore} from '../../state/store.js';
import {XfTree} from '../../widgets/xf_tree.js';
import {XfTreeItem} from '../../widgets/xf_tree_item.js';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {AllowedPaths} from '../../common/js/volume_manager_types.js';
import {FileOperationManager} from '../../externs/background/file_operation_manager.js';
import {Store} from '../../externs/ts/store.js';
import {VolumeManager} from '../../externs/volume_manager.js';
import {updateSelection} from '../../state/actions/current_directory.js';
import {updateSelection} from '../../state/ducks/current_directory.js';
import {getStore} from '../../state/store.js';

import {constants} from './constants.js';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {str, util} from '../../common/js/util.js';
import {VolumeManagerCommon} from '../../common/js/volume_manager_types.js';
import {DirectoryChangeEvent} from '../../externs/directory_change_event.js';
import {VolumeManager} from '../../externs/volume_manager.js';
import {changeDirectory} from '../../state/actions/current_directory.js';
import {changeDirectory} from '../../state/ducks/current_directory.js';
import {getStore} from '../../state/store.js';

import {AppStateController} from './app_state_controller.js';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {metrics} from '../../common/js/metrics.js';
import {util} from '../../common/js/util.js';
import {VolumeManagerCommon} from '../../common/js/volume_manager_types.js';
import {Store} from '../../externs/ts/store.js';
import {updateDirectoryContent} from '../../state/actions/current_directory.js';
import {updateDirectoryContent} from '../../state/ducks/current_directory.js';
import {getStore} from '../../state/store.js';

import {DirectoryModel} from './directory_model.js';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {ProgressCenter} from '../../externs/background/progress_center.js';
import {FilesAppDirEntry, FilesAppEntry} from '../../externs/files_app_entry_interfaces.js';
import {FileData, FileKey, FileTasks as StoreFileTasks, PropStatus, State} from '../../externs/ts/state.js';
import {VolumeManager} from '../../externs/volume_manager.js';
import {fetchFileTasks} from '../../state/actions_producers/current_directory.js';
import {fetchFileTasks} from '../../state/ducks/current_directory.js';
import {getFilesData, getStore, Store, waitForState} from '../../state/store.js';
import {FilesPasswordDialog} from '../elements/files_password_dialog.js';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {ProgressCenter} from '../../externs/background/progress_center.js';
import {PropStatus, State} from '../../externs/ts/state.js';
import {VolumeInfo} from '../../externs/volume_info.js';
import {VolumeManager} from '../../externs/volume_manager.js';
import {changeDirectory} from '../../state/actions/current_directory.js';
import {changeDirectory} from '../../state/ducks/current_directory.js';
import {setUpFileManagerOnWindow} from '../../state/for_tests.js';
import {getEmptyState, getStore, waitForState} from '../../state/store.js';

Expand Down
2 changes: 1 addition & 1 deletion ui/file_manager/file_manager/state/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
// found in the LICENSE file.

import {AddChildEntriesAction, ClearStaleCachedEntriesAction, UpdateMetadataAction} from './actions/all_entries.js';
import {ChangeDirectoryAction, ChangeFileTasksAction, ChangeSelectionAction, UpdateDirectoryContentAction} from './actions/current_directory.js';
import {AddAndroidAppsAction} from './ducks/android_apps.js';
import {UpdateBulkPinProgressAction} from './ducks/bulk_pinning.js';
import {ChangeDirectoryAction, ChangeFileTasksAction, ChangeSelectionAction, UpdateDirectoryContentAction} from './ducks/current_directory.js';
import {UpdateDeviceConnectionStateAction} from './ducks/device.js';
import {AddFolderShortcutAction, RefreshFolderShortcutAction, RemoveFolderShortcutAction} from './ducks/folder_shortcuts.js';
import {RefreshNavigationRootsAction, UpdateNavigationEntryAction} from './ducks/navigation.js';
Expand Down
84 changes: 0 additions & 84 deletions ui/file_manager/file_manager/state/actions/current_directory.ts

This file was deleted.

This file was deleted.

0 comments on commit df917da

Please sign in to comment.