[FilesBulkPinning] Unpin files that are deleted on the cloud

The default option when files are deleted from the cloud is to move the
file to the trash. On ChromeOS the drive trash isn't surfaced so they
sit in the cache and remained pinned. To avoid this (and allow Cello to
prune the cache) unpin the files when a kDelete event is received.

Bug: b:266005690
Test: browser_tests --gtest_filter=*driveCloudDeleteUnpinsItem*
Change-Id: I8af673a86115ad8be4705fb0bab935bdf0723720
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4199118
Reviewed-by: Austin Tankiang <austinct@chromium.org>
Commit-Queue: Ben Reich <benreich@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1098492}

chrome/browser/ash/file_manager/file_manager_browsertest.cc

@@ -1466,7 +1466,8 @@ WRAPPED_INSTANTIATE_TEST_SUITE_P(
         TestCase("driveDeleteDialogDoesntMentionPermanentDelete"),
         TestCase("driveInlineSyncStatusSingleFile").EnableInlineStatusSync(),
         TestCase("driveInlineSyncStatusParentFolder").EnableInlineStatusSync(),
-        TestCase("driveLocalDeleteUnpinsItem").EnableBulkPinning()
+        TestCase("driveLocalDeleteUnpinsItem").EnableBulkPinning(),
+        TestCase("driveCloudDeleteUnpinsItem").EnableBulkPinning()
         // TODO(b/189173190): Enable
         // TestCase("driveEnableDocsOfflineDialog"),
         // TODO(b/189173190): Enable

chrome/browser/ash/file_manager/file_manager_browsertest_base.cc

@@ -1321,6 +1321,21 @@ class DriveFsTestVolume : public TestVolume {
     drivefs_delegate.FlushForTesting();
   }
 
+  void SendCloudDeleteEvent(const std::string& path) {
+    const base::FilePath file_path(path);
+    absl::optional<drivefs::FakeDriveFs::FileMetadata> metadata =
+        fake_drivefs_helper_->fake_drivefs().GetItemMetadata(file_path);
+    ASSERT_TRUE(metadata.has_value()) << "No file metadata with path: " << path;
+
+    std::vector<drivefs::mojom::FileChangePtr> file_changes;
+    file_changes.emplace_back(absl::in_place, file_path,
+                              drivefs::mojom::FileChange::Type::kDelete,
+                              metadata.value().stable_id);
+    auto& drivefs_delegate = fake_drivefs_helper_->fake_drivefs().delegate();
+    drivefs_delegate->OnFilesChanged(std::move(file_changes));
+    drivefs_delegate.FlushForTesting();
+  }
+
   absl::optional<drivefs::mojom::DialogResult> last_dialog_result() {
     return last_dialog_result_;
   }
@@ -3266,6 +3281,13 @@ void FileManagerBrowserTestBase::OnCommand(const std::string& name,
     return;
   }
 
+  if (name == "sendDriveCloudDeleteEvent") {
+    const std::string* path = value.FindString("path");
+    ASSERT_TRUE(path) << "No supplied path to sendDriveFilesChangedEvent";
+    drive_volume_->SendCloudDeleteEvent(*path);
+    return;
+  }
+
   if (HandleGuestOsCommands(name, value, output)) {
     return;
   }

chromeos/ash/components/drivefs/drivefs_pin_manager.cc

@@ -801,7 +801,21 @@ void PinManager::OnFilesChanged(const std::vector<mojom::FileChange>& changes) {
 
   if (progress_.stage != Stage::kSyncing) {
     for (const mojom::FileChange& change : changes) {
-      VLOG(1) << "Ignored FileChange " << Quote(change);
+      switch (change.type) {
+        case mojom::FileChange::Type::kDelete:
+          VLOG(1) << "Got FileChange " << Quote(change);
+          drivefs_->SetPinnedByStableId(
+              change.stable_id, /*pinned=*/false,
+              base::BindOnce([](drive::FileError status) {
+                LOG_IF(ERROR, status != drive::FILE_ERROR_OK)
+                    << "Failed to unpin file: "
+                    << drive::FileErrorToString(status);
+              }));
+          break;
+        default:
+          VLOG(1) << "Ignored FileChange " << Quote(change);
+          break;
+      }
     }
     return;
   }

chromeos/ash/components/drivefs/fake_drivefs.cc

@@ -90,20 +90,6 @@ FakeDriveFsBootstrapListener::bootstrap() {
   return std::move(bootstrap_);
 }
 
-struct FakeDriveFs::FileMetadata {
-  std::string mime_type;
-  bool pinned = false;
-  bool hosted = false;
-  bool shared = false;
-  bool available_offline = false;
-  std::string original_name;
-  mojom::Capabilities capabilities;
-  mojom::FolderFeature folder_feature;
-  std::string doc_id;
-  int64_t stable_id = 0;
-  std::string alternate_url;
-};
-
 class FakeDriveFs::SearchQuery : public mojom::SearchQuery {
  public:
   SearchQuery(base::WeakPtr<FakeDriveFs> drive_fs,
@@ -258,6 +244,13 @@ class FakeDriveFs::SearchQuery : public mojom::SearchQuery {
   base::WeakPtrFactory<SearchQuery> weak_ptr_factory_{this};
 };
 
+FakeDriveFs::FileMetadata::FileMetadata() = default;
+FakeDriveFs::FileMetadata::FileMetadata(const FakeDriveFs::FileMetadata&) =
+    default;
+FakeDriveFs::FileMetadata& FakeDriveFs::FileMetadata::operator=(
+    const FakeDriveFs::FileMetadata&) = default;
+FakeDriveFs::FileMetadata::~FileMetadata() = default;
+
 FakeDriveFs::FakeDriveFs(const base::FilePath& mount_path)
     : mount_path_(mount_path) {
   CHECK(mount_path.IsAbsolute());
@@ -331,6 +324,15 @@ absl::optional<bool> FakeDriveFs::IsItemPinned(const std::string& path) {
   return absl::nullopt;
 }
 
+absl::optional<FakeDriveFs::FileMetadata> FakeDriveFs::GetItemMetadata(
+    const base::FilePath& path) {
+  const auto& metadata = metadata_.find(path);
+  if (metadata == metadata_.end()) {
+    return absl::nullopt;
+  }
+  return metadata->second;
+}
+
 void FakeDriveFs::Init(
     drivefs::mojom::DriveFsConfigurationPtr config,
     mojo::PendingReceiver<drivefs::mojom::DriveFs> receiver,

chromeos/ash/components/drivefs/fake_drivefs.h

@@ -84,8 +84,29 @@ class FakeDriveFs : public drivefs::mojom::DriveFs,
 
   absl::optional<bool> IsItemPinned(const std::string& path);
 
+  struct FileMetadata {
+    FileMetadata();
+    FileMetadata(const FileMetadata&);
+    FileMetadata& operator=(const FileMetadata&);
+    ~FileMetadata();
+
+    std::string mime_type;
+    bool pinned = false;
+    bool hosted = false;
+    bool shared = false;
+    bool available_offline = false;
+    std::string original_name;
+    mojom::Capabilities capabilities;
+    mojom::FolderFeature folder_feature;
+    std::string doc_id;
+    int64_t stable_id = 0;
+    std::string alternate_url;
+  };
+
+  absl::optional<FakeDriveFs::FileMetadata> GetItemMetadata(
+      const base::FilePath& path);
+
  private:
-  struct FileMetadata;
   class SearchQuery;
 
   // drivefs::mojom::DriveFsBootstrap:

ui/file_manager/integration_tests/file_manager/drive_specific.js

@@ -1298,3 +1298,27 @@ testcase.driveLocalDeleteUnpinsItem = async () => {
   // Ensure the file was unpinned prior to deleting.
   await remoteCall.expectDriveItemPinnedStatus(appId, '/root/test.txt', false);
 };
+
+/**
+ * Test that when files get deleted in the cloud, they get unpinned after being
+ * deleted.
+ */
+testcase.driveCloudDeleteUnpinsItem = async () => {
+  const appId = await setupAndWaitUntilReady(RootPath.DRIVE);
+
+  // Select test.txt which is already pinned.
+  await remoteCall.waitAndClickElement(
+      appId, '#file-list [file-name="test.txt"]');
+  await remoteCall.waitForElement(
+      appId, '[file-name="test.txt"][selected] xf-icon[type=offline]');
+
+  // Ensure the metadata for the file is set to pinned.
+  await remoteCall.expectDriveItemPinnedStatus(appId, '/root/test.txt', true);
+
+  await remoteCall.sendDriveCloudDeleteEvent(appId, '/root/test.txt');
+  await remoteCall.waitForElementLost(
+      appId, '#file-list [file-name="test.txt"]');
+
+  // Ensure the file was unpinned prior to deleting.
+  await remoteCall.expectDriveItemPinnedStatus(appId, '/root/test.txt', false);
+};

ui/file_manager/integration_tests/remote_call.js

@@ -998,4 +998,18 @@ export class RemoteCallFilesApp extends RemoteCall {
         }),
         String(status));
   }
+
+  /**
+   * Send a delete event via the `OnFilesChanged` drivefs delegate method.
+   * @param {string} appId app window ID.
+   * @param {string} path Path from the drive mount point, e.g. /root/test.txt
+   */
+  async sendDriveCloudDeleteEvent(appId, path) {
+    await this.waitFor('isFileManagerLoaded', appId, true);
+    await sendTestMessage({
+      appId,
+      name: 'sendDriveCloudDeleteEvent',
+      path,
+    });
+  }
 }