-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adjust Desktop privacy guide for hash-prefix real-time lookups
Changes: - When the friendlier settings feature is enabled, modifies the sublabel of Safe Browsing standard protection. - When the friendlier settings features is disabled, modifies the some additional details in the Safe Browsing standard protection description (FeatureDescription2 + PrivacyDescription1). Note that the "off" branch for hash-prefix real-time lookups will be long-lived, so this does not follow the general strategy of adding the disabled case only in the "FlagsDisabled" suite. Test changes: - `label` is added to PrivacyGuideDescriptionItemElement so that tests can read it. - New child test suites added to the SafeBrowsingFragment suite: 1) HashPrefixRealTimeDisabled 2) HashPrefixRealTimeEnabled 3) HashPrefixRealTimeEnabled_FriendlierSettingsDisabled - The test suite SafeBrowsingFragment_FlagsDisabled is renamed to FlagsDisabled since it is already a child suite of the suite SafeBrowsingFragment. - The test UpdatedStandardProtectionPrivacyGuide is renamed to StandardProtectionDescription and is moved within the child suite HashPrefixRealTimeDisabled. - The HashPrefixRealTimeDisabled and HashPrefixRealTimeEnabled suites are expected to stick around long-term, whereas the FlagsDisabled and HashPrefixRealTimeEnabled_FriendlierSettingsDisabled suites contain only temporary test cases. Bug: 1469956 Change-Id: I1a754710fb27b1defc4a68a8ad25248a1dcd0d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4802965 Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: thefrog <thefrog@chromium.org> Cr-Commit-Position: refs/heads/main@{#1188308}
- Loading branch information
thefrog
authored and
Chromium LUCI CQ
committed
Aug 25, 2023
1 parent
ba73e55
commit e3f97dd
Showing
8 changed files
with
267 additions
and
122 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
..._PRIVACY_GUIDE_SAFE_BROWSING_CARD_STANDARD_PROTECTION_FEATURE_DESCRIPTION2_PROXY.png.sha1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
4a2af9788ccababb26bb6f0cf09563766bd64a3b |
1 change: 1 addition & 0 deletions
1
..._PRIVACY_GUIDE_SAFE_BROWSING_CARD_STANDARD_PROTECTION_PRIVACY_DESCRIPTION1_PROXY.png.sha1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
4a2af9788ccababb26bb6f0cf09563766bd64a3b |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.