Skip to content

Commit

Permalink
Adjust Desktop privacy guide for hash-prefix real-time lookups
Browse files Browse the repository at this point in the history
Changes:
 - When the friendlier settings feature is enabled, modifies the
   sublabel of Safe Browsing standard protection.
 - When the friendlier settings features is disabled, modifies the
   some additional details in the Safe Browsing standard protection
   description (FeatureDescription2 + PrivacyDescription1).

Note that the "off" branch for hash-prefix real-time lookups will be
long-lived, so this does not follow the general strategy of adding the
disabled case only in the "FlagsDisabled" suite.

Test changes:
 - `label` is added to PrivacyGuideDescriptionItemElement so that tests
   can read it.
 - New child test suites added to the SafeBrowsingFragment suite:
     1) HashPrefixRealTimeDisabled
     2) HashPrefixRealTimeEnabled
     3) HashPrefixRealTimeEnabled_FriendlierSettingsDisabled
 - The test suite SafeBrowsingFragment_FlagsDisabled is renamed to
   FlagsDisabled since it is already a child suite of the suite
   SafeBrowsingFragment.
 - The test UpdatedStandardProtectionPrivacyGuide is renamed to
   StandardProtectionDescription and is moved within the child suite
   HashPrefixRealTimeDisabled.
 - The HashPrefixRealTimeDisabled and HashPrefixRealTimeEnabled suites
   are expected to stick around long-term, whereas the FlagsDisabled and
   HashPrefixRealTimeEnabled_FriendlierSettingsDisabled suites contain
   only temporary test cases.

Bug: 1469956
Change-Id: I1a754710fb27b1defc4a68a8ad25248a1dcd0d85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4802965
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Commit-Queue: thefrog <thefrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1188308}
  • Loading branch information
thefrog authored and Chromium LUCI CQ committed Aug 25, 2023
1 parent ba73e55 commit e3f97dd
Show file tree
Hide file tree
Showing 8 changed files with 267 additions and 122 deletions.
8 changes: 8 additions & 0 deletions chrome/app/settings_strings.grdp
Original file line number Diff line number Diff line change
Expand Up @@ -2313,6 +2313,14 @@
<message name="IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_STANDARD_PROTECTION_FEATURE_DESCRIPTION1" desc="A part of the feature description of the standard protection section of the safe browsing card in the 'Privacy guide'.">
Detects and warns you about dangerous events when they happen
</message>
<if expr="_google_chrome">
<message name="IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_STANDARD_PROTECTION_FEATURE_DESCRIPTION2_PROXY" desc="A part of the feature description of the standard protection section of the safe browsing card in the 'Privacy guide'.">
Sends an obfuscated portion of the URL to Google through a privacy server that hides your IP address
</message>
<message name="IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_STANDARD_PROTECTION_PRIVACY_DESCRIPTION1_PROXY" desc="A part of the privacy description of the standard protection section of the safe browsing card in the 'Privacy Guide'.">
If a site tries to steal your password, or when you download a harmful file, Chrome may also send URLs, including bits of page content, to Google
</message>
</if>
<message name="IDS_SETTINGS_PRIVACY_GUIDE_SEARCH_SUGGESTIONS_CARD_HEADER" desc="Header of the 'search suggestions' card in the 'Privacy Guide'.">
Choose whether to get additional search suggestions
</message>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
4a2af9788ccababb26bb6f0cf09563766bd64a3b
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
4a2af9788ccababb26bb6f0cf09563766bd64a3b
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ export class PrivacyGuideDescriptionItemElement extends PolymerElement {
};
}

label: string;

private sanitizeInnerHtml_(rawString: string): TrustedHTML {
return sanitizeInnerHtml(rawString);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ <h2 class="header-label-phase2">
name="[[safeBrowsingSettingEnum_.STANDARD]]"
label="$i18n{safeBrowsingStandard}"
sub-label="[[getSafeBrowsingStandardSubLabel_(
enableFriendlierSafeBrowsingSettings_)]]"
enableFriendlierSafeBrowsingSettings_,
enableHashPrefixRealTimeLookups_)]]"
expand-aria-label="$i18n{safeBrowsingStandardExpandA11yLabel}"
on-click="onSafeBrowsingStandardClick_">
<template is="dom-if" if="[[!enableFriendlierSafeBrowsingSettings_]]">
Expand All @@ -160,9 +161,11 @@ <h2 class="header-label-phase2">
label="$i18n{privacyGuideSafeBrowsingCardStandardProtectionFeatureDescription1}">
</privacy-guide-description-item>
<privacy-guide-description-item
id="standardProtectionFeatureDescription2"
role="listitem"
icon="settings20:googleg"
label="$i18n{privacyGuideSafeBrowsingCardStandardProtectionFeatureDescription2}">
label="[[getStandardProtectionFeatureDescription2_(
enableHashPrefixRealTimeLookups_)]]">
</privacy-guide-description-item>
</div>
</div>
Expand All @@ -172,9 +175,11 @@ <h2 class="header-label-phase2">
</div>
<div role="list">
<privacy-guide-description-item
id="standardProtectionPrivacyDescription1"
role="listitem"
icon="settings20:data"
label="$i18n{privacyGuideSafeBrowsingCardStandardProtectionPrivacyDescription1}">
label="[[getStandardProtectionPrivacyDescription1_(
enableHashPrefixRealTimeLookups_)]]">
</privacy-guide-description-item>
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,21 @@ export class PrivacyGuideSafeBrowsingFragmentElement extends
'enableFriendlierSafeBrowsingSettings');
},
},

enableHashPrefixRealTimeLookups_: {
type: Boolean,
value() {
return loadTimeData.getBoolean('enableHashPrefixRealTimeLookups');
},
},
};
}

private metricsBrowserProxy_: MetricsBrowserProxy =
MetricsBrowserProxyImpl.getInstance();
private startStateEnhanced_: boolean;
private enableFriendlierSafeBrowsingSettings_: boolean;
private enableHashPrefixRealTimeLookups_: boolean;

override ready() {
super.ready();
Expand Down Expand Up @@ -142,9 +150,25 @@ export class PrivacyGuideSafeBrowsingFragmentElement extends
private getSafeBrowsingStandardSubLabel_(): string {
return this.i18n(
this.enableFriendlierSafeBrowsingSettings_ ?
this.enableHashPrefixRealTimeLookups_ ?
'safeBrowsingStandardDescUpdatedProxy' :
'safeBrowsingStandardDescUpdated' :
'safeBrowsingStandardDesc');
}

private getStandardProtectionFeatureDescription2_(): string {
return this.i18n(
this.enableHashPrefixRealTimeLookups_ ?
'privacyGuideSafeBrowsingCardStandardProtectionFeatureDescription2Proxy' :
'privacyGuideSafeBrowsingCardStandardProtectionFeatureDescription2');
}

private getStandardProtectionPrivacyDescription1_(): string {
return this.i18n(
this.enableHashPrefixRealTimeLookups_ ?
'privacyGuideSafeBrowsingCardStandardProtectionPrivacyDescription1Proxy' :
'privacyGuideSafeBrowsingCardStandardProtectionPrivacyDescription1');
}
}

declare global {
Expand Down
209 changes: 108 additions & 101 deletions chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2375,107 +2375,114 @@ void AddPrivacySandboxStrings(content::WebUIDataSource* html_source,

void AddPrivacyGuideStrings(content::WebUIDataSource* html_source) {
static constexpr webui::LocalizedString kLocalizedStrings[] = {
{"privacyGuideLabel", IDS_SETTINGS_PRIVACY_GUIDE_LABEL},
{"privacyGuideSublabel", IDS_SETTINGS_PRIVACY_GUIDE_SUBLABEL},
{"privacyGuidePromoHeader", IDS_SETTINGS_PRIVACY_GUIDE_PROMO_HEADER},
{"privacyGuidePromoBody", IDS_SETTINGS_PRIVACY_GUIDE_PROMO_BODY},
{"privacyGuidePromoStartButton",
IDS_SETTINGS_PRIVACY_GUIDE_PROMO_START_BUTTON},
{"privacyGuideBackToSettingsAriaLabel",
IDS_SETTINGS_PRIVACY_GUIDE_BACK_TO_SETTINGS_ARIA_LABEL},
{"privacyGuideBackToSettingsAriaRoleDescription",
IDS_SETTINGS_PRIVACY_GUIDE_BACK_TO_SETTINGS_ARIA_ROLE_DESC},
{"privacyGuideBackButton", IDS_SETTINGS_PRIVACY_GUIDE_BACK_BUTTON},
{"privacyGuideSteps", IDS_SETTINGS_PRIVACY_GUIDE_STEPS},
{"privacyGuideNextButton", IDS_SETTINGS_PRIVACY_GUIDE_NEXT_BUTTON},
{"privacyGuideFeatureDescriptionHeader",
IDS_SETTINGS_PRIVACY_GUIDE_FEATURE_DESCRIPTION_HEADER},
{"privacyGuideThingsToConsider",
IDS_SETTINGS_PRIVACY_GUIDE_THINGS_TO_CONSIDER},
{"privacyGuideWelcomeCardHeader",
IDS_SETTINGS_PRIVACY_GUIDE_WELCOME_CARD_HEADER},
{"privacyGuideWelcomeCardSubHeader",
IDS_SETTINGS_PRIVACY_GUIDE_WELCOME_CARD_SUB_HEADER},
{"privacyGuideCompletionCardHeader",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_HEADER},
{"privacyGuideCompletionCardSubHeader",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_SUB_HEADER},
{"privacyGuideCompletionCardSubHeaderNoLinks",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_SUB_HEADER_NO_LINKS},
{"privacyGuideCompletionCardLeaveButton",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_LEAVE_BUTTON},
{"privacyGuideCompletionCardPrivacySandboxLabel",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_PRIVACY_SANDBOX_LABEL},
{"privacyGuideCompletionCardPrivacySandboxSubLabel",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_PRIVACY_SANDBOX_SUB_LABEL},
{"privacyGuideCompletionCardWaaLabel",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_WAA_LABEL},
{"privacyGuideCompletionCardWaaSubLabel",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_WAA_SUB_LABEL},
{"privacyGuideMsbbCardHeader",
IDS_SETTINGS_PRIVACY_GUIDE_MSBB_CARD_HEADER},
{"privacyGuideMsbbFeatureDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_MSBB_FEATURE_DESCRIPTION1},
{"privacyGuideMsbbFeatureDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_MSBB_FEATURE_DESCRIPTION2},
{"privacyGuideMsbbFeatureDescription3",
IDS_SETTINGS_PRIVACY_GUIDE_MSBB_FEATURE_DESCRIPTION3},
{"privacyGuideMsbbPrivacyDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_MSBB_PRIVACY_DESCRIPTION1},
{"privacyGuideMsbbPrivacyDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_MSBB_PRIVACY_DESCRIPTION2},
{"privacyGuideHistorySyncCardHeader",
IDS_SETTINGS_PRIVACY_GUIDE_HISTORY_SYNC_CARD_HEADER},
{"privacyGuideHistorySyncSettingLabel",
IDS_SETTINGS_PRIVACY_GUIDE_HISTORY_SYNC_SETTING_LABEL},
{"privacyGuideHistorySyncFeatureDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_HISTORY_SYNC_FEATURE_DESCRIPTION1},
{"privacyGuideHistorySyncFeatureDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_HISTORY_SYNC_FEATURE_DESCRIPTION2},
{"privacyGuideHistorySyncPrivacyDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_HISTORY_SYNC_PRIVACY_DESCRIPTION1},
{"privacyGuideCookiesCardHeader",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_HEADER},
{"privacyGuideCookiesCardBlockTpcIncognitoSubheader",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_INCOGNITO_SUBHEADER},
{"privacyGuideCookiesCardBlockTpcIncognitoFeatureDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_INCOGNITO_FEATURE_DESCRIPTION1},
{"privacyGuideCookiesCardBlockTpcIncognitoFeatureDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_INCOGNITO_FEATURE_DESCRIPTION2},
{"privacyGuideCookiesCardBlockTpcIncognitoPrivacyDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_INCOGNITO_PRIVACY_DESCRIPTION1},
{"privacyGuideCookiesCardBlockTpcIncognitoPrivacyDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_INCOGNITO_PRIVACY_DESCRIPTION2},
{"privacyGuideCookiesCardBlockTpcSubheader",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_SUBHEADER},
{"privacyGuideCookiesCardBlockTpcFeatureDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_FEATURE_DESCRIPTION1},
{"privacyGuideCookiesCardBlockTpcFeatureDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_FEATURE_DESCRIPTION2},
{"privacyGuideCookiesCardBlockTpcPrivacyDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_PRIVACY_DESCRIPTION1},
{"privacyGuideSafeBrowsingCardHeader",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_HEADER},
{"privacyGuideSafeBrowsingCardEnhancedProtectionPrivacyDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_ENHANCED_PROTECTION_PRIVACY_DESCRIPTION1},
{"privacyGuideSafeBrowsingCardEnhancedProtectionPrivacyDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_ENHANCED_PROTECTION_PRIVACY_DESCRIPTION2},
{"privacyGuideSafeBrowsingCardEnhancedProtectionPrivacyDescription3",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_ENHANCED_PROTECTION_PRIVACY_DESCRIPTION3},
{"privacyGuideSafeBrowsingCardStandardProtectionFeatureDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_STANDARD_PROTECTION_FEATURE_DESCRIPTION1},
{"privacyGuideSafeBrowsingCardStandardProtectionFeatureDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_STANDARD_PROTECTION_FEATURE_DESCRIPTION2},
{"privacyGuideSafeBrowsingCardStandardProtectionPrivacyDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_STANDARD_PROTECTION_PRIVACY_DESCRIPTION1},
{"privacyGuideSearchSuggestionsCardHeader",
IDS_SETTINGS_PRIVACY_GUIDE_SEARCH_SUGGESTIONS_CARD_HEADER},
{"privacyGuideSearchSuggestionsFeatureDescription1",
IDS_SETTINGS_PRIVACY_SEARCH_SUGGESTIONS_FEATURE_DESCRIPTION1},
{"privacyGuideSearchSuggestionsPrivacyDescription1",
IDS_SETTINGS_PRIVACY_SEARCH_SUGGESTIONS_PRIVACY_DESCRIPTION1},
{"privacyGuideSearchSuggestionsPrivacyDescription2",
IDS_SETTINGS_PRIVACY_SEARCH_SUGGESTIONS_PRIVACY_DESCRIPTION2},
{"privacyGuideLabel", IDS_SETTINGS_PRIVACY_GUIDE_LABEL},
{"privacyGuideSublabel", IDS_SETTINGS_PRIVACY_GUIDE_SUBLABEL},
{"privacyGuidePromoHeader", IDS_SETTINGS_PRIVACY_GUIDE_PROMO_HEADER},
{"privacyGuidePromoBody", IDS_SETTINGS_PRIVACY_GUIDE_PROMO_BODY},
{"privacyGuidePromoStartButton",
IDS_SETTINGS_PRIVACY_GUIDE_PROMO_START_BUTTON},
{"privacyGuideBackToSettingsAriaLabel",
IDS_SETTINGS_PRIVACY_GUIDE_BACK_TO_SETTINGS_ARIA_LABEL},
{"privacyGuideBackToSettingsAriaRoleDescription",
IDS_SETTINGS_PRIVACY_GUIDE_BACK_TO_SETTINGS_ARIA_ROLE_DESC},
{"privacyGuideBackButton", IDS_SETTINGS_PRIVACY_GUIDE_BACK_BUTTON},
{"privacyGuideSteps", IDS_SETTINGS_PRIVACY_GUIDE_STEPS},
{"privacyGuideNextButton", IDS_SETTINGS_PRIVACY_GUIDE_NEXT_BUTTON},
{"privacyGuideFeatureDescriptionHeader",
IDS_SETTINGS_PRIVACY_GUIDE_FEATURE_DESCRIPTION_HEADER},
{"privacyGuideThingsToConsider",
IDS_SETTINGS_PRIVACY_GUIDE_THINGS_TO_CONSIDER},
{"privacyGuideWelcomeCardHeader",
IDS_SETTINGS_PRIVACY_GUIDE_WELCOME_CARD_HEADER},
{"privacyGuideWelcomeCardSubHeader",
IDS_SETTINGS_PRIVACY_GUIDE_WELCOME_CARD_SUB_HEADER},
{"privacyGuideCompletionCardHeader",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_HEADER},
{"privacyGuideCompletionCardSubHeader",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_SUB_HEADER},
{"privacyGuideCompletionCardSubHeaderNoLinks",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_SUB_HEADER_NO_LINKS},
{"privacyGuideCompletionCardLeaveButton",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_LEAVE_BUTTON},
{"privacyGuideCompletionCardPrivacySandboxLabel",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_PRIVACY_SANDBOX_LABEL},
{"privacyGuideCompletionCardPrivacySandboxSubLabel",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_PRIVACY_SANDBOX_SUB_LABEL},
{"privacyGuideCompletionCardWaaLabel",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_WAA_LABEL},
{"privacyGuideCompletionCardWaaSubLabel",
IDS_SETTINGS_PRIVACY_GUIDE_COMPLETION_CARD_WAA_SUB_LABEL},
{"privacyGuideMsbbCardHeader", IDS_SETTINGS_PRIVACY_GUIDE_MSBB_CARD_HEADER},
{"privacyGuideMsbbFeatureDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_MSBB_FEATURE_DESCRIPTION1},
{"privacyGuideMsbbFeatureDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_MSBB_FEATURE_DESCRIPTION2},
{"privacyGuideMsbbFeatureDescription3",
IDS_SETTINGS_PRIVACY_GUIDE_MSBB_FEATURE_DESCRIPTION3},
{"privacyGuideMsbbPrivacyDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_MSBB_PRIVACY_DESCRIPTION1},
{"privacyGuideMsbbPrivacyDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_MSBB_PRIVACY_DESCRIPTION2},
{"privacyGuideHistorySyncCardHeader",
IDS_SETTINGS_PRIVACY_GUIDE_HISTORY_SYNC_CARD_HEADER},
{"privacyGuideHistorySyncSettingLabel",
IDS_SETTINGS_PRIVACY_GUIDE_HISTORY_SYNC_SETTING_LABEL},
{"privacyGuideHistorySyncFeatureDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_HISTORY_SYNC_FEATURE_DESCRIPTION1},
{"privacyGuideHistorySyncFeatureDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_HISTORY_SYNC_FEATURE_DESCRIPTION2},
{"privacyGuideHistorySyncPrivacyDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_HISTORY_SYNC_PRIVACY_DESCRIPTION1},
{"privacyGuideCookiesCardHeader",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_HEADER},
{"privacyGuideCookiesCardBlockTpcIncognitoSubheader",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_INCOGNITO_SUBHEADER},
{"privacyGuideCookiesCardBlockTpcIncognitoFeatureDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_INCOGNITO_FEATURE_DESCRIPTION1},
{"privacyGuideCookiesCardBlockTpcIncognitoFeatureDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_INCOGNITO_FEATURE_DESCRIPTION2},
{"privacyGuideCookiesCardBlockTpcIncognitoPrivacyDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_INCOGNITO_PRIVACY_DESCRIPTION1},
{"privacyGuideCookiesCardBlockTpcIncognitoPrivacyDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_INCOGNITO_PRIVACY_DESCRIPTION2},
{"privacyGuideCookiesCardBlockTpcSubheader",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_SUBHEADER},
{"privacyGuideCookiesCardBlockTpcFeatureDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_FEATURE_DESCRIPTION1},
{"privacyGuideCookiesCardBlockTpcFeatureDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_FEATURE_DESCRIPTION2},
{"privacyGuideCookiesCardBlockTpcPrivacyDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_COOKIES_CARD_BLOCK_TPC_PRIVACY_DESCRIPTION1},
{"privacyGuideSafeBrowsingCardHeader",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_HEADER},
{"privacyGuideSafeBrowsingCardEnhancedProtectionPrivacyDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_ENHANCED_PROTECTION_PRIVACY_DESCRIPTION1},
{"privacyGuideSafeBrowsingCardEnhancedProtectionPrivacyDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_ENHANCED_PROTECTION_PRIVACY_DESCRIPTION2},
{"privacyGuideSafeBrowsingCardEnhancedProtectionPrivacyDescription3",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_ENHANCED_PROTECTION_PRIVACY_DESCRIPTION3},
{"privacyGuideSafeBrowsingCardStandardProtectionFeatureDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_STANDARD_PROTECTION_FEATURE_DESCRIPTION1},
{"privacyGuideSafeBrowsingCardStandardProtectionFeatureDescription2",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_STANDARD_PROTECTION_FEATURE_DESCRIPTION2},
#if BUILDFLAG(GOOGLE_CHROME_BRANDING)
{"privacyGuideSafeBrowsingCardStandardProtectionFeatureDescription2Proxy",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_STANDARD_PROTECTION_FEATURE_DESCRIPTION2_PROXY},
#endif
{"privacyGuideSafeBrowsingCardStandardProtectionPrivacyDescription1",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_STANDARD_PROTECTION_PRIVACY_DESCRIPTION1},
#if BUILDFLAG(GOOGLE_CHROME_BRANDING)
{"privacyGuideSafeBrowsingCardStandardProtectionPrivacyDescription1Proxy",
IDS_SETTINGS_PRIVACY_GUIDE_SAFE_BROWSING_CARD_STANDARD_PROTECTION_PRIVACY_DESCRIPTION1_PROXY},
#endif
{"privacyGuideSearchSuggestionsCardHeader",
IDS_SETTINGS_PRIVACY_GUIDE_SEARCH_SUGGESTIONS_CARD_HEADER},
{"privacyGuideSearchSuggestionsFeatureDescription1",
IDS_SETTINGS_PRIVACY_SEARCH_SUGGESTIONS_FEATURE_DESCRIPTION1},
{"privacyGuideSearchSuggestionsPrivacyDescription1",
IDS_SETTINGS_PRIVACY_SEARCH_SUGGESTIONS_PRIVACY_DESCRIPTION1},
{"privacyGuideSearchSuggestionsPrivacyDescription2",
IDS_SETTINGS_PRIVACY_SEARCH_SUGGESTIONS_PRIVACY_DESCRIPTION2},
};
html_source->AddLocalizedStrings(kLocalizedStrings);
}
Expand Down

0 comments on commit e3f97dd

Please sign in to comment.