Add flag ExperimentalWebAppStoragePartitionIsolation

Bug: 1425284 Change-Id: I740b2ceedd6c098cc3744fd675b4d277221082e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4343793 Reviewed-by: Glen Robertson <glenrob@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/main@{#1119772}
chromium · Mar 21, 2023 · e4862b0 · e4862b0
1 parent c7c2cae
commit e4862b0
Show file tree

Hide file tree

Showing 7 changed files with 34 additions and 0 deletions.
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
@@ -9762,6 +9762,15 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_VALUE_TYPE(ash::features::kAppLaunchAutomation)},
 #endif
 
+#if BUILDFLAG(IS_CHROMEOS_LACROS)
+    {"experimental-web-app-storage-partition-isolation",
+     flag_descriptions::kExperimentalWebAppStoragePartitionIsolationName,
+     flag_descriptions::kExperimentalWebAppStoragePartitionIsolationDescription,
+     kOsLacros,
+     FEATURE_VALUE_TYPE(
+         chromeos::features::kExperimentalWebAppStoragePartitionIsolation)},
+#endif  // BUILDFLAG(IS_CHROMEOS_LACROS)
+
     // NOTE: Adding a new flag requires adding a corresponding entry to enum
     // "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
     // Histograms" in tools/metrics/histograms/README.md (run the

diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
@@ -3657,6 +3657,11 @@
     "owners": [ "djean@google.com", "erahmaoui@google.com", "bling-flags@google.com" ],
     "expiry_milestone": 116
   },
+  {
+    "name": "experimental-web-app-storage-partition-isolation",
+    "owners": [ "lxj@google.com", "glenrob@google.com", "chromeos-web-apps-platform-syd@google.com"],
+    "expiry_milestone": 120
+  },
   {
     "name": "explore-sites",
     "owners": [ "chili", "dewittj" ],

diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
@@ -6287,6 +6287,12 @@ const char kDesktopCaptureLacrosV2Description[] =
     "Enables the improved desktop/window capturer for doing screen/window "
     "sharing on Lacros";
 
+const char kExperimentalWebAppStoragePartitionIsolationName[] =
+    "Enable experimental web app stroage partition isolation";
+const char kExperimentalWebAppStoragePartitionIsolationDescription[] =
+    "This is highly experimental. Enabling this flag could break things. And a "
+    "power wash might be needed to fully recover the state.";
+
 const char kLacrosAuraCaptureName[] = "Enable Lacros Aura Capture";
 const char kLacrosAuraCaptureDescription[] =
     "Enables LaCrOS to perform an in-process capture of it's own windows "

diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
@@ -3622,6 +3622,9 @@ extern const char kLibAssistantV2MigrationDescription[];
 extern const char kDesktopCaptureLacrosV2Name[];
 extern const char kDesktopCaptureLacrosV2Description[];
 
+extern const char kExperimentalWebAppStoragePartitionIsolationName[];
+extern const char kExperimentalWebAppStoragePartitionIsolationDescription[];
+
 extern const char kLacrosAuraCaptureName[];
 extern const char kLacrosAuraCaptureDescription[];
 

diff --git a/chromeos/constants/chromeos_features.cc b/chromeos/constants/chromeos_features.cc
@@ -51,6 +51,11 @@ BASE_FEATURE(kDisableQuickAnswersV2Translation,
              "DisableQuickAnswersV2Translation",
              base::FEATURE_DISABLED_BY_DEFAULT);
 
+// Enable experimental goldfish web app isolation.
+BASE_FEATURE(kExperimentalWebAppStoragePartitionIsolation,
+             "ExperimentalWebAppStoragePartitionIsolation",
+             base::FEATURE_DISABLED_BY_DEFAULT);
+
 // Enables Jelly features.
 BASE_FEATURE(kJelly, "Jelly", base::FEATURE_DISABLED_BY_DEFAULT);
 

diff --git a/chromeos/constants/chromeos_features.h b/chromeos/constants/chromeos_features.h
@@ -30,6 +30,8 @@ COMPONENT_EXPORT(CHROMEOS_CONSTANTS)
 BASE_DECLARE_FEATURE(kDisableOfficeEditingComponentApp);
 COMPONENT_EXPORT(CHROMEOS_CONSTANTS)
 BASE_DECLARE_FEATURE(kDisableQuickAnswersV2Translation);
+COMPONENT_EXPORT(CHROMEOS_CONSTANTS)
+BASE_DECLARE_FEATURE(kExperimentalWebAppStoragePartitionIsolation);
 COMPONENT_EXPORT(CHROMEOS_CONSTANTS) BASE_DECLARE_FEATURE(kJelly);
 COMPONENT_EXPORT(CHROMEOS_CONSTANTS) BASE_DECLARE_FEATURE(kJellyroll);
 COMPONENT_EXPORT(CHROMEOS_CONSTANTS)

diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
@@ -61668,6 +61668,8 @@ from previous Chrome versions.
   <int value="-283220112" label="RevampedPasswordManagementBubble:enabled"/>
   <int value="-283079109" label="TouchToFillPasswordSubmission:enabled"/>
   <int value="-283024110" label="WebXRPlaneDetection:disabled"/>
+  <int value="-282770689"
+      label="ExperimentalWebAppStoragePartitionIsolation:disabled"/>
   <int value="-281844827" label="AutofillCreditCardAblationExperiment:enabled"/>
   <int value="-279920685" label="affiliation-based-matching:enabled"/>
   <int value="-279493876" label="WebVRExperimentalRendering:enabled"/>
@@ -64608,6 +64610,8 @@ from previous Chrome versions.
   <int value="1360969228" label="RevampedContextMenu:enabled"/>
   <int value="1361047396" label="disable-click-delay"/>
   <int value="1361073386" label="ContentSuggestionsNotifications:enabled"/>
+  <int value="1361736708"
+      label="ExperimentalWebAppStoragePartitionIsolation:enabled"/>
   <int value="1363136936" label="VrCustomTabBrowsing:enabled"/>
   <int value="1363151585" label="SyncPseudoUSSAppList:enabled"/>
   <int value="1363283577" label="CrOSLateBootAudioFlexibleLoopback:enabled"/>