Skip to content

Commit

Permalink
[SafetyCheck] Fix max value for histogram
Browse files Browse the repository at this point in the history
Reduce max value to 99, so that there is a better bucketing
of list count. Currently we only see 2 buckets, which is not a meaningful guiding metric for the team.

(cherry picked from commit 2cc8d5a)

Bug: 1345920
Change-Id: I9e1689765a9620c66ed6acfc36f535397b0fbc2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4176919
Reviewed-by: Side YILMAZ <sideyilmaz@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Kamila Hasanbega <hkamila@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1096097}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4197577
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Kamila Hasanbega <hkamila@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/branch-heads/5481@{#730}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
  • Loading branch information
hkamila authored and Chromium LUCI CQ committed Jan 27, 2023
1 parent aaf8168 commit e5b88bd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion chrome/browser/resources/settings/metrics_browser_proxy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ export class MetricsBrowserProxyImpl implements MetricsBrowserProxy {
recordSafetyCheckNotificationsListCountHistogram(suggestions: number) {
chrome.send('metricsHandler:recordInHistogram', [
'Settings.SafetyCheck.NotificationsListCount',
suggestions, 3999 /*max value for Notification suggestions*/,
suggestions, 99 /*max value for Notification suggestions*/,
]);
}

Expand Down

0 comments on commit e5b88bd

Please sign in to comment.