Skip to content

Commit

Permalink
[Translate metrics cleanup] Remove Translate.CompactInfobar.Translati…
Browse files Browse the repository at this point in the history
…onsPerPage code

Most of this was already done on https://crbug.com/1244705 but there is a bit of remaining code to be removed.

Bug: 1446386
Change-Id: I4ad7e655b408d48c89e9c592ced15ac851508379
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4545119
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1146831}
  • Loading branch information
Anthony Cui authored and Chromium LUCI CQ committed May 20, 2023
1 parent 1d4e415 commit e641d7f
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 9 deletions.
Expand Up @@ -66,9 +66,6 @@ public class TranslateCompactInfoBar
private long mNativeTranslateInfoBarPtr;
private TranslateTabLayout mTabLayout;

// Metric to track the total number of translations in a page, including reverts to original.
private int mTotalTranslationCount;

private static final String INFOBAR_HISTOGRAM = "Translate.CompactInfobar.Event";

// Need 2 instances of TranslateMenuHelper to prevent a race condition bug which happens when
Expand Down
1 change: 0 additions & 1 deletion ios/chrome/browser/translate/translate_constants.h
Expand Up @@ -22,6 +22,5 @@ typedef NS_OPTIONS(NSUInteger, UserAction) {
// UMA histogram names.
// Note: These string constants are repeated in TranslateCompactInfoBar.java.
extern const char kEventHistogram[];
extern const char kTranslationCountHistogram[];

#endif // IOS_CHROME_BROWSER_TRANSLATE_TRANSLATE_CONSTANTS_H_
2 changes: 0 additions & 2 deletions ios/chrome/browser/translate/translate_constants.mm
Expand Up @@ -9,5 +9,3 @@
#endif

const char kEventHistogram[] = "Translate.CompactInfobar.Event";
const char kTranslationCountHistogram[] =
"Translate.CompactInfobar.TranslationsPerPage";
Expand Up @@ -59,9 +59,6 @@ public class TranslateCompactInfoBar extends InfoBar
private long mNativeTranslateInfoBarPtr;
private TranslateTabLayout mTabLayout;

// Metric to track the total number of translations in a page, including reverts to original.
private int mTotalTranslationCount;

// Histogram names for logging metrics.
private static final String INFOBAR_HISTOGRAM = "Translate.CompactInfobar.Event";

Expand Down

0 comments on commit e641d7f

Please sign in to comment.