-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Add parsing for between street lines"
This reverts commit 04a91b9. Reason for revert: suspected culprit for crbug.com/1497836 Original change's description: > Add parsing for between street lines > > This CL adds type parsing for ADDRESS_HOME_BETWEEN_STREETS_1 and > ADDRESS_HOME_BETWEEN_STREETS_2. It is implemented behind the feature > flag kAutofillEnableSupportForBetweenStreets. > > The field is classified as ADDRESS_HOME_BETWEEN_STREETS_2 only if > there exists a field with type ADDRESS_HOME_BETWEEN_STREETS_1. > > With this CL, the regex for spanish locale for > ADDRESS_HOME_BETWEEN_STREETS is changed to search for "calles" instead > of "calle". As a side effect, single address between street fields with > name/label as "calle" would be labeled as ADDRESS_HOME_BETWEEN_STREETS_1 > now instead of ADDRESS_HOME_BETWEEN_STREETS. > > Bug: 1493377 > Change-Id: I09413720cc7487574fd9f05da0531ec40adef9a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4958347 > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > Reviewed-by: Dominic Battre <battre@chromium.org> > Commit-Queue: Dominic Battre <battre@chromium.org> > Reviewed-by: Norge Vizcay <vizcay@google.com> > Cr-Commit-Position: refs/heads/main@{#1217023} Bug: 1493377 Change-Id: I681a023700667f1233fed86133bfb4cce8b327b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989579 Commit-Queue: Shu Yang <shuyng@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shu Yang <shuyng@google.com> Owners-Override: Shu Yang <shuyng@google.com> Cr-Commit-Position: refs/heads/main@{#1217326}
- Loading branch information
Shu Yang
authored and
Chromium LUCI CQ
committed
Oct 31, 2023
1 parent
dc0ab0c
commit ea9f1f6
Showing
9 changed files
with
40 additions
and
203 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.