Skip to content

Commit

Permalink
[dPWA] Clean up PreinstalledWebAppDuplicationFixer
Browse files Browse the repository at this point in the history
This CL cleans up the PreinstalledWebAppDuplicationFixer start up
adjustment step.
This looked for preinstalled web apps that had corresponding old
Chrome apps still installed and re-migrated them. This was very
successful when deployed and has tapered off substantially,
see metrics: go/nejyv

This code is a complexity risk to keep around and can cause other
unintended issues at start up, see crbug.com/1393284 for an example.

Bug: 1290716
Change-Id: I3d16034e7a2ea871e1be735aecc9c5903b647207
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584075
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1153622}
  • Loading branch information
alancutter authored and Chromium LUCI CQ committed Jun 6, 2023
1 parent e519cfd commit ee9726e
Show file tree
Hide file tree
Showing 8 changed files with 26 additions and 696 deletions.
5 changes: 1 addition & 4 deletions chrome/browser/web_applications/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -888,10 +888,7 @@ source_set("web_applications_browser_tests") {
group("browser_tests") {
testonly = true

deps = [
":web_applications_browser_tests",
"adjustments:adjustments_browser_tests",
]
deps = [ ":web_applications_browser_tests" ]
}

# On Lacros, these browser tests require Ash to be running.
Expand Down
22 changes: 0 additions & 22 deletions chrome/browser/web_applications/adjustments/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import("//chrome/common/features.gni")

source_set("adjustments") {
sources = [
"preinstalled_web_app_duplication_fixer.cc",
"preinstalled_web_app_duplication_fixer.h",
"web_app_adjustments.cc",
"web_app_adjustments.h",
]
Expand Down Expand Up @@ -37,26 +35,6 @@ source_set("adjustments") {
}
}

source_set("adjustments_browser_tests") {
testonly = true

sources = []

if (!is_chromeos_lacros) {
sources += [ "preinstalled_web_app_duplication_fixer_browsertest.cc" ]
}

defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]

deps = [
":adjustments",
"//chrome/browser/apps/app_service",
"//chrome/browser/web_applications",
"//chrome/browser/web_applications:web_applications_test_support",
"//chrome/test:test_support",
]
}

source_set("unit_tests") {
testonly = true

Expand Down

This file was deleted.

This file was deleted.

0 comments on commit ee9726e

Please sign in to comment.