Skip to content

Commit

Permalink
[118][Discounts] Bug bash polish work
Browse files Browse the repository at this point in the history
This CL fixes the following:
  * Updates the header image that has additional top spaces
  * Updates the top content padding for the GM3 version

(cherry picked from commit 301b688)

Bug: 1480833
Change-Id: Ida2b099b1677ecffdcf66fb53f1c927ab1bcf161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4889935
Reviewed-by: Vinny Persky <vinnypersky@google.com>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1201751}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908639
Auto-Submit: Mei Liang <meiliang@chromium.org>
Reviewed-by: Emily Shack <emshack@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/branch-heads/5993@{#1101}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
  • Loading branch information
Mei Liang authored and Chromium LUCI CQ committed Oct 3, 2023
1 parent 1202d0f commit f039b5a
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 0 deletions.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,9 @@ void OfferNotificationBubbleViews::InitWithFreeListingCouponOfferContent() {
std::u16string promo_code_value_prop_string;

if (::features::IsChromeRefresh2023()) {
set_margins(ChromeLayoutProvider::Get()->GetDialogInsetsForContentType(
views::DialogContentType::kControl, views::DialogContentType::kText));

const int dialog_inset = views::LayoutProvider::Get()
->GetInsetsMetric(views::INSETS_DIALOG)
.left();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ class OfferNotificationIconViewBrowserTest : public UiBrowserTest {
if (!offer_notification_icon_view) {
return false;
}

EXPECT_EQ(offer_notification_icon_view->GetAccessibleName(),
l10n_util::GetStringUTF16(
IDS_AUTOFILL_OFFERS_REMINDER_ICON_TOOLTIP_TEXT));
Expand Down

0 comments on commit f039b5a

Please sign in to comment.