-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Update QS bubble width and fix page indicator visibility"
This reverts commit c920e62. Reason for revert: crbug.com/1411566 Original change's description: > Update QS bubble width and fix page indicator visibility > > - Updated QS Revamp bubble and Feature Tile widths to spec. > See go/cros-quick-settings-spec for details. > > - Fixed a padding issue by making the PageIndicatorView visible only > when we have multiple pages. > > - Added page indicator visibility test in new quick_settings_unittest.cc > file and moved some existing unified_system_tray tests to this file. > > - Added feature tiles container test to switch page with focus. > > screenshots > single page: https://screenshot.googleplex.com/3hN2KssXLAZ6Q7H > multiple pages: https://screenshot.googleplex.com/5JiibovN5NC6aHe > > b: 260119632, b:266601219, b:264469449, b:266627837 > Change-Id: I3600ce520291d9785e526542b79cc51d10f3a3f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4195122 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Kevin Radtke <kradtke@chromium.org> > Reviewed-by: Jiaming Cheng <jiamingc@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1099054} Change-Id: I570a75434093c99abb12865c37f692cf049c883e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4207269 Auto-Submit: Keishi Hattori <keishi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1099090}
- Loading branch information
Keishi Hattori
authored and
Chromium LUCI CQ
committed
Jan 31, 2023
1 parent
11a0bfb
commit f042459
Showing
12 changed files
with
176 additions
and
266 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.