-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove SiteInstanceDeleting from content/public API.
Currently, two unit tests are relying on ContentBrowserClient::SiteInstanceDeleting() to ensure that SiteInstance lifetimes are managed properly. However, it is undesirable to allow //content embedders to run arbitrary code during SiteInstance destruction, per the linked bug. Hence, this CL converts SiteInstanceDeleting() usage to a test-specific callback instead and removes it from ContentBrowserClient. Bug: 1444438 Change-Id: I2affcb4a40ccfbf3bd715d7b225976a687405616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4564316 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1149171}
- Loading branch information
Alex Moshchuk
authored and
Chromium LUCI CQ
committed
May 25, 2023
1 parent
5aa3a81
commit f149f77
Showing
4 changed files
with
73 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters