Skip to content

Commit

Permalink
[Nearby][Self Share] GAR 1.1 NS Visibility Page
Browse files Browse the repository at this point in the history
When Chromevox is enabled:
- Visible to all contacts toggle has name read
- All radio buttons have their descriptions read after their names

Tested: manually via DUT
Bug: b/279942442
Change-Id: Ib17c676a8e448f8f1ab93c0326426021660dad5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4785129
Reviewed-by: Daniel Classon <dclasson@google.com>
Commit-Queue: Brando Socarras <brandosocarras@google.com>
Cr-Commit-Position: refs/heads/main@{#1185442}
  • Loading branch information
Brando authored and Chromium LUCI CQ committed Aug 18, 2023
1 parent 4bc5fba commit f23f49f
Showing 1 changed file with 7 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@
selected="{{selectedVisibility}}">
<template is="dom-if" if="[[showSelfShareUi_(isSelfShareEnabled_)]]">
<cr-card-radio-button id="contacts" class="flex" name="contacts"
aria-labelledby="contactsLabel">
aria-labelledby="contactsLabel" aria-describedby="explanation">
<div class="card-contents">
<iron-icon icon="nearby20:contact-all" class="card-icon">
</iron-icon>
Expand All @@ -251,7 +251,7 @@
</div>
</cr-card-radio-button>
<cr-card-radio-button id="yourDevices" class="flex" name="yourDevices"
aria-labelledby="yourDevicesLabel">
aria-labelledby="yourDevicesLabel" aria-describedby="explanation">
<div class="card-contents">
<iron-icon icon="nearby20:your-devices" class="card-icon">
</iron-icon>
Expand All @@ -263,7 +263,7 @@
</template>
<template is="dom-if" if="[[!showSelfShareUi_(isSelfShareEnabled_)]]">
<cr-card-radio-button id="allContacts" class="flex" name="all"
aria-labelledby="allContactsLabel">
aria-labelledby="allContactsLabel" aria-describedby="explanation">
<div class="card-contents">
<iron-icon icon="nearby20:contact-all" class="card-icon">
</iron-icon>
Expand All @@ -273,7 +273,7 @@
</div>
</cr-card-radio-button>
<cr-card-radio-button id="someContacts" class="flex" name="some"
aria-labelledby="someContactsLabel">
aria-labelledby="someContactsLabel" aria-describedby="explanation">
<div class="card-contents">
<iron-icon icon="nearby20:contact-group" class="card-icon">
</iron-icon>
Expand All @@ -284,7 +284,7 @@
</cr-card-radio-button>
</template>
<cr-card-radio-button id="noContacts" class="flex" name="none"
aria-labelledby="noContactsLabel">
aria-labelledby="noContactsLabel" aria-describedby="explanation">
<div class="card-contents">
<iron-icon icon="nearby20:visibility-off" class="card-icon">
</iron-icon>
Expand Down Expand Up @@ -379,7 +379,8 @@
</div>
<cr-toggle id="AllContactsToggle"
checked="[[isAllContactsToggledOn_]]"
on-change="toggleAllContacts_">
on-change="toggleAllContacts_"
aria-describedby="nearbyVisibilityAllContactsToggleTitle">
</cr-toggle>
</div>
</template>
Expand Down

0 comments on commit f23f49f

Please sign in to comment.