Skip to content

Commit

Permalink
safe_browsing OWNERS refactor
Browse files Browse the repository at this point in the history
This CL makes a couple changes to the OWNERS files for safe_browsing
code.
- Most OWNERS files now point to components/safe_browsing/OWNERS,
  for easier addition/removal of users.
- Removed redundant OWNERS file
  chrome/browser/safe_browsing/download_protection/OWNERS
- Removed reference to non-existent file
  components/safe_browsing/content/password_protection/OWNERS
- Removed BUILD.gn special case in chrome/common/safe_browsing/OWNERS
  so that BUILD.gn changes to our code still get reviewed.

Change-Id: If567a56ec3955810b0293fbfa1665b15d45875ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826746
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1034157}
  • Loading branch information
Daniel Rubery authored and Chromium LUCI CQ committed Aug 11, 2022
1 parent 80544a4 commit f276009
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 34 deletions.
4 changes: 1 addition & 3 deletions chrome/browser/resources/safe_browsing/OWNERS
@@ -1,3 +1 @@
drubery@chromium.org
nparker@chromium.org
vakh@chromium.org
file://components/safe_browsing/OWNERS
7 changes: 1 addition & 6 deletions chrome/browser/safe_browsing/OWNERS
@@ -1,6 +1 @@
drubery@chromium.org
nparker@chromium.org
vakh@chromium.org
xinghuilu@chromium.org

per-file *password_protection*=file://components/safe_browsing/content/password_protection/OWNERS
file://components/safe_browsing/OWNERS
3 changes: 0 additions & 3 deletions chrome/browser/safe_browsing/download_protection/OWNERS

This file was deleted.

4 changes: 1 addition & 3 deletions chrome/browser/ui/views/safe_browsing/OWNERS
@@ -1,3 +1 @@
drubery@chromium.org
nparker@chromium.org
vakh@chromium.org
file://components/safe_browsing/OWNERS
4 changes: 1 addition & 3 deletions chrome/browser/ui/webui/reset_password/OWNERS
@@ -1,6 +1,4 @@
per-file *.mojom=set noparent
per-file *.mojom=file://ipc/SECURITY_OWNERS

drubery@chromium.org
nparker@chromium.org
vakh@chromium.org
file://components/safe_browsing/OWNERS
8 changes: 1 addition & 7 deletions chrome/common/safe_browsing/OWNERS
@@ -1,10 +1,4 @@
drubery@chromium.org
nparker@chromium.org
vakh@chromium.org

# This is for the common case of adding or renaming files. If you're doing
# structural changes, use usual OWNERS rules.
per-file BUILD.gn=*
file://components/safe_browsing/OWNERS

per-file *_messages*.h=set noparent
per-file *_messages*.h=file://ipc/SECURITY_OWNERS
Expand Down
4 changes: 1 addition & 3 deletions chrome/renderer/safe_browsing/OWNERS
@@ -1,3 +1 @@
drubery@chromium.org
nparker@chromium.org
vakh@chromium.org
file://components/safe_browsing/OWNERS
4 changes: 1 addition & 3 deletions chrome/utility/safe_browsing/OWNERS
@@ -1,3 +1 @@
drubery@chromium.org
nparker@chromium.org
vakh@chromium.org
file://components/safe_browsing/OWNERS
5 changes: 2 additions & 3 deletions components/resources/protobufs/OWNERS
@@ -1,4 +1,3 @@
drubery@chromium.org
file://components/safe_browsing/OWNERS

meacer@chromium.org
nparker@chromium.org
vakh@chromium.org

0 comments on commit f276009

Please sign in to comment.