Skip to content

Commit

Permalink
[Sheriff] Disable ErrorMetricsTest.CreateSqliteLoggedResultCode_Chrom…
Browse files Browse the repository at this point in the history
…eBugError on dcheck off builds

(cherry picked from commit f721913)

Bug: 1306382
Change-Id: I85b5c7ee1b0a2982b9080695a1eac14ffbb20a08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522433
Owners-Override: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#980998}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3534504
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Owners-Override: Tomasz Wiszkowski <ender@google.com>
Auto-Submit: Tomasz Wiszkowski <ender@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4896@{#650}
Cr-Branched-From: 1f63ff4-refs/heads/main@{#972766}
  • Loading branch information
horo-t authored and Chromium LUCI CQ committed Mar 17, 2022
1 parent 5a87fd4 commit f35cb6a
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion sql/error_metrics_unittest.cc
Expand Up @@ -62,7 +62,15 @@ TEST(ErrorMetricsTest, CreateSqliteLoggedResultCode_SqliteInternalError) {
#endif
}

TEST(ErrorMetricsTest, CreateSqliteLoggedResultCode_ChromeBugError) {
// TODO(crbug.com/1306382): Fails when dcheck_always_on = false.
#if !DCHECK_IS_ON()
#define MAYBE_CreateSqliteLoggedResultCode_ChromeBugError \
DISABLED_CreateSqliteLoggedResultCode_ChromeBugError
#else
#define MAYBE_CreateSqliteLoggedResultCode_ChromeBugError \
CreateSqliteLoggedResultCode_ChromeBugError
#endif // DCHECK_IS_ON()
TEST(ErrorMetricsTest, MAYBE_CreateSqliteLoggedResultCode_ChromeBugError) {
#if DCHECK_IS_ON()
EXPECT_DCHECK_DEATH_WITH(
CreateSqliteLoggedResultCode(SQLITE_NOTFOUND),
Expand Down

0 comments on commit f35cb6a

Please sign in to comment.