Skip to content

Commit

Permalink
Cross-origin isolate Terminal to allow SharedArrayBuffer
Browse files Browse the repository at this point in the history
SharedArrayBuffer is required for wasm ssh.

Bug: 1350479
Change-Id: I70b09baf8fa19450dafdf385e60844ea3bf183e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812982
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Dominic Schulz <dominicschulz@google.com>
Cr-Commit-Position: refs/heads/main@{#1032422}
  • Loading branch information
Joel Hockey authored and Chromium LUCI CQ committed Aug 8, 2022
1 parent 648b219 commit f4fced5
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
10 changes: 10 additions & 0 deletions chrome/browser/ash/web_applications/terminal_source.cc
Expand Up @@ -235,3 +235,13 @@ std::string TerminalSource::GetContentSecurityPolicy(
return content::URLDataSource::GetContentSecurityPolicy(directive);
}
}

// Required for wasm SharedArrayBuffer.
std::string TerminalSource::GetCrossOriginOpenerPolicy() {
return "same-origin";
}

// Required for wasm SharedArrayBuffer.
std::string TerminalSource::GetCrossOriginEmbedderPolicy() {
return "require-corp";
}
2 changes: 2 additions & 0 deletions chrome/browser/ash/web_applications/terminal_source.h
Expand Up @@ -46,6 +46,8 @@ class TerminalSource : public content::URLDataSource {
const ui::TemplateReplacements* GetReplacements() override;
std::string GetContentSecurityPolicy(
network::mojom::CSPDirectiveName directive) override;
std::string GetCrossOriginOpenerPolicy() override;
std::string GetCrossOriginEmbedderPolicy() override;

Profile* profile_;
std::string source_;
Expand Down

0 comments on commit f4fced5

Please sign in to comment.