-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[journeys] Fix regression where WebUI toggle disappears if pref false
There's a regression in M115 where if the user turns the pref false from WebUI, then closes the tab, and re-opens History, the toggle is gone. This regression happened here: https://bugs.chromium.org/p/chromium/issues/detail?id=1450346 This CL is a minimal fix meant to be easily mergeable to M115. I tested it manually. A more extensive cleanup can be done after the client-side locale check can be removed from the code. Bug: 1450346 Change-Id: I860103c365b276735627a3c15cf39031330492b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4577921 Reviewed-by: Roman Arora <romanarora@chromium.org> Auto-Submit: Tommy Li <tommycli@chromium.org> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/main@{#1151536}
- Loading branch information
Tommy C. Li
authored and
Chromium LUCI CQ
committed
May 31, 2023
1 parent
9a42c15
commit f50b325
Showing
10 changed files
with
35 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters