Skip to content

Commit

Permalink
PageLoadMetrics: Remove unused callback OnFirstLayout
Browse files Browse the repository at this point in the history
PageLoadMetricsObserverInterface::OnFirstLayout is not called from
anywhere. This CL removes the method.

Change-Id: I2bc9612c4c3f7890006868923b3a9a8e9c83894b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3779936
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Ken Okada <kenoss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1028580}
  • Loading branch information
kenoss authored and Chromium LUCI CQ committed Jul 27, 2022
1 parent 8fd325d commit f76859c
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,6 @@ void PageLoadMetricsForwardObserver::OnDomContentLoadedEventStart(
void PageLoadMetricsForwardObserver::OnLoadEventStart(
const mojom::PageLoadTiming& timing) {}

void PageLoadMetricsForwardObserver::OnFirstLayout(
const mojom::PageLoadTiming& timing) {}

void PageLoadMetricsForwardObserver::OnParseStart(
const mojom::PageLoadTiming& timing) {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ class PageLoadMetricsForwardObserver final
void OnDomContentLoadedEventStart(
const mojom::PageLoadTiming& timing) override;
void OnLoadEventStart(const mojom::PageLoadTiming& timing) override;
void OnFirstLayout(const mojom::PageLoadTiming& timing) override;
void OnParseStart(const mojom::PageLoadTiming& timing) override;
void OnParseStop(const mojom::PageLoadTiming& timing) override;
void OnFirstPaintInPage(const mojom::PageLoadTiming& timing) override;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ class PageLoadMetricsObserver : public PageLoadMetricsObserverInterface {
void OnDomContentLoadedEventStart(
const mojom::PageLoadTiming& timing) override {}
void OnLoadEventStart(const mojom::PageLoadTiming& timing) override {}
void OnFirstLayout(const mojom::PageLoadTiming& timing) override {}
void OnParseStart(const mojom::PageLoadTiming& timing) override {}
void OnParseStop(const mojom::PageLoadTiming& timing) override {}
void OnFirstPaintInPage(const mojom::PageLoadTiming& timing) override {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,6 @@ class PageLoadMetricsObserverInterface {
virtual void OnDomContentLoadedEventStart(
const mojom::PageLoadTiming& timing) = 0;
virtual void OnLoadEventStart(const mojom::PageLoadTiming& timing) = 0;
virtual void OnFirstLayout(const mojom::PageLoadTiming& timing) = 0;
virtual void OnParseStart(const mojom::PageLoadTiming& timing) = 0;
virtual void OnParseStop(const mojom::PageLoadTiming& timing) = 0;

Expand Down

0 comments on commit f76859c

Please sign in to comment.