[Refactor] Fix StartSurfaceMediatorUnitTest when the refactoring is e…

…nabled. In this CL, a helper function showHomepageAndVerify() is added to allow showing Start surface without using the StartSurfaceState. Bug: 1347089 Change-Id: Icd7eb42de013fd836105e2824cb8fd696f852700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4114402 Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1084590}
chromium · Dec 16, 2022 · f8dadbb · f8dadbb
1 parent 1064b35
commit f8dadbb
Show file tree

Hide file tree

Showing 2 changed files with 155 additions and 117 deletions.
diff --git a/...art_surface/java/src/org/chromium/chrome/features/start_surface/StartSurfaceMediator.java b/...art_surface/java/src/org/chromium/chrome/features/start_surface/StartSurfaceMediator.java
@@ -1498,7 +1498,8 @@ private void mayRecordHomepageSessionBegin() {
     /**
      * Returns whether the Start surface homepage is showing.
      */
-    private boolean isHomepageShown() {
+    @VisibleForTesting
+    boolean isHomepageShown() {
         return mIsStartSurfaceRefactorEnabled
                 ? mIsHomepageShown
                 : mStartSurfaceState == StartSurfaceState.SHOWN_HOMEPAGE;