Skip to content

Commit

Permalink
Clean up expired chrome://flags for offline capability check
Browse files Browse the repository at this point in the history
This CL reverts https://crrev.com/c/2494288 and
https://crrev.com/c/2517278 to remove the flag that was expired on M93
(chrome://flags#check-offline-capability).

Bug: 965802
Change-Id: I4ea3b0da02b81bdebb6bf1b6fc68a49f80b810fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4202272
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Auto-Submit: Asami Doi <asamidoi@chromium.org>
Commit-Queue: Asami Doi <asamidoi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1098456}
  • Loading branch information
d0iasm authored and Chromium LUCI CQ committed Jan 30, 2023
1 parent a1b3c71 commit f9608f0
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 31 deletions.
18 changes: 0 additions & 18 deletions chrome/browser/about_flags.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2613,18 +2613,6 @@ const FeatureEntry::FeatureVariation
};
#endif // BUILDFLAG(IS_ANDROID)

const FeatureEntry::FeatureParam kCheckOfflineCapabilityWarnOnly[] = {
{"check_mode", "warn_only"}};
const FeatureEntry::FeatureParam kCheckOfflineCapabilityEnforce[] = {
{"check_mode", "enforce"}};

const FeatureEntry::FeatureVariation kCheckOfflineCapabilityVariations[] = {
{"Warn-only", kCheckOfflineCapabilityWarnOnly,
std::size(kCheckOfflineCapabilityWarnOnly), nullptr},
{"Enforce", kCheckOfflineCapabilityEnforce,
std::size(kCheckOfflineCapabilityEnforce), nullptr},
};

#if BUILDFLAG(IS_CHROMEOS_ASH)
const FeatureEntry::FeatureParam kProductivityLauncher_WithoutContinue[] = {
{"enable_continue", "false"}};
Expand Down Expand Up @@ -7601,12 +7589,6 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kBlockInsecureDownloadsDescription, kOsAll,
FEATURE_VALUE_TYPE(features::kBlockInsecureDownloads)},

{"check-offline-capability", flag_descriptions::kCheckOfflineCapabilityName,
flag_descriptions::kCheckOfflineCapabilityDescription, kOsAll,
FEATURE_WITH_PARAMS_VALUE_TYPE(blink::features::kCheckOfflineCapability,
kCheckOfflineCapabilityVariations,
"CheckOfflineCapability")},

{"deferred-font-shaping", flag_descriptions::kDeferredFontShapingName,
flag_descriptions::kDeferredFontShapingDescription, kOsAll,
FEATURE_VALUE_TYPE(blink::features::kDeferredShaping)},
Expand Down
5 changes: 0 additions & 5 deletions chrome/browser/flag-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -952,11 +952,6 @@
"owners": ["hchao", "mattm", "davidben", "chrome-trusty-transport-core@google.com"],
"expiry_milestone": 115
},
{
"name": "check-offline-capability",
"owners": [ "asamidoi", "//content/browser/service_worker/OWNERS" ],
"expiry_milestone": 93
},
{
"name": "chip-location-bar-icon-override",
"owners": [
Expand Down
5 changes: 0 additions & 5 deletions chrome/browser/flag_descriptions.cc
Original file line number Diff line number Diff line change
Expand Up @@ -670,11 +670,6 @@ const char kServiceWorkerBypassFetchHandlerForMainResourceDescription[] =
"and handles subresources. If the main resource could be handled in the "
"fetch handler, the feature may affect the page load.";

const char kCheckOfflineCapabilityName[] = "Check offline capability for PWAs";
const char kCheckOfflineCapabilityDescription[] =
"Use advanced offline capability check to decide whether the browser "
"displays install prompts for PWAs.";

const char kChromeLabsName[] = "Chrome Labs";
const char kChromeLabsDescription[] =
"Access Chrome Labs through the toolbar menu to see featured user-facing "
Expand Down
3 changes: 0 additions & 3 deletions chrome/browser/flag_descriptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -370,9 +370,6 @@ extern const char kServiceWorkerBypassFetchHandlerForMainResourceDescription[];
extern const char kCanvasOopRasterizationName[];
extern const char kCanvasOopRasterizationDescription[];

extern const char kCheckOfflineCapabilityName[];
extern const char kCheckOfflineCapabilityDescription[];

extern const char kChromeLabsName[];
extern const char kChromeLabsDescription[];

Expand Down

0 comments on commit f9608f0

Please sign in to comment.