[A11y] Fix DCHECK in UnignoredNextSibling

Don't try to set controls relation automatically on ignored textfield. (cherry picked from commit 3503f30) Fixed: 1447023 Change-Id: Idf1e6228ab80f768acd59e6e861212d5b92e48d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598128 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1154976} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606627 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5790@{#599} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
chromium · Jun 11, 2023 · fa87a1a · fa87a1a
1 parent c84b3db
commit fa87a1a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/third_party/blink/renderer/modules/accessibility/ax_object.cc b/third_party/blink/renderer/modules/accessibility/ax_object.cc
@@ -2394,6 +2394,11 @@ AXObject* AXObject::GetControlsListboxForTextfieldCombobox() {
   if (!ui::IsTextField(RoleValue()))
     return nullptr;
 
+  // Object is ignored for some reason, most likely hidden.
+  if (AccessibilityIsIgnored()) {
+    return nullptr;
+  }
+
   // Authors used to be told to use aria-owns to point from the textfield to the
   // listbox. However, the aria-owns  on a textfield must be ignored for its
   // normal purpose because a textfield cannot have children. This code allows

diff --git a/...blink/web_tests/external/wpt/accessibility/crashtests/hidden-textfield-with-combobox.html b/...blink/web_tests/external/wpt/accessibility/crashtests/hidden-textfield-with-combobox.html
@@ -0,0 +1,8 @@
+<!DOCTYPE html>
+<div>
+  <div role="combobox">
+    <input id="textfield" role="textbox" aria-hidden="true" tabindex="-1" aria-readonly="true" aria-label="foo" aria-autocomplete="both">
+    <div role="listbox">
+    </div>
+  </div>
+</div>