Skip to content

Commit

Permalink
ash: Allow StopDataCollection without starting
Browse files Browse the repository at this point in the history
CUJ recorder force stop frame tracking to ensure test cases do
not interfere each other in http://crrev.com/c/4685262. Stop
without starting is a valid case now and the DHCECK is causing
problems when running CUJ with a dcheck enabled chrome.

Bug: b:268541084
Change-Id: I5f1efc01d9ade7d288777e7af6c7d5ab34a1ea35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4939517
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1209782}
  • Loading branch information
Xiyuan Xia authored and Chromium LUCI CQ committed Oct 14, 2023
1 parent d9d47f3 commit fd17dd7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion ash/public/cpp/metrics_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ void StartDataCollection() {
}

std::vector<AnimationData> StopDataCollection() {
DCHECK(g_data_collection_enabled);
g_data_collection_enabled = false;

return GetCollectedData();
Expand Down

0 comments on commit fd17dd7

Please sign in to comment.