Skip to content

Commit

Permalink
Fixed broken tests due to expired credit cards
Browse files Browse the repository at this point in the history
UserHappinessFormInteraction_CreditCardForm and
LogCreditCardSeamlessFillsMetricIfAutofilledWithoutCvc were broken
due to a credit card expiring in 12/2022.

(cherry picked from commit da5f219)

Fixed: 1394998
Change-Id: I082c64e40f6145f3a3c4373007d5cd27175ea28f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4066885
Reviewed-by: Florian Leimgruber <fleimgruber@google.com>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1077999}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4081390
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Auto-Submit: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/branch-heads/5359@{#1092}
Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
  • Loading branch information
Dominic Battre authored and Chromium LUCI CQ committed Dec 6, 2022
1 parent 988abc2 commit fd4a812
Showing 1 changed file with 7 additions and 14 deletions.
Expand Up @@ -209,9 +209,7 @@ void AutofillMetricsBaseTest::RecreateCreditCards(
bool masked_card_is_enrolled_for_virtual_card) {
personal_data().ClearCreditCards();
if (include_local_credit_card) {
CreditCard local_credit_card;
test::SetCreditCardInfo(&local_credit_card, "Test User",
"4111111111111111" /* Visa */, "11", "2022", "1");
CreditCard local_credit_card = test::GetCreditCard();
local_credit_card.set_guid("10000000-0000-0000-0000-000000000001");
personal_data().AddCreditCard(local_credit_card);
}
Expand Down Expand Up @@ -244,10 +242,8 @@ std::string AutofillMetricsBaseTest::CreateLocalMasterCard(
personal_data().ClearCreditCards();
}
std::string guid("10000000-0000-0000-0000-000000000003");
CreditCard local_credit_card;
test::SetCreditCardInfo(&local_credit_card, "Test User",
"5454545454545454" /* Mastercard */, "08", "2022",
"1");
CreditCard local_credit_card = test::GetCreditCard();
local_credit_card.SetNumber(u"5454545454545454" /* Mastercard */);
local_credit_card.set_guid(guid);
personal_data().AddCreditCard(local_credit_card);
return guid;
Expand All @@ -258,20 +254,17 @@ AutofillMetricsBaseTest::CreateLocalAndDuplicateServerCreditCard() {
personal_data().ClearCreditCards();

// Local credit card creation.
CreditCard local_credit_card;
test::SetCreditCardInfo(&local_credit_card, "Test User",
"4111111111111111" /* Visa */, "11", "2022", "1");
CreditCard local_credit_card = test::GetCreditCard();
std::string local_card_guid("10000000-0000-0000-0000-000000000001");
local_credit_card.set_guid(local_card_guid);
personal_data().AddCreditCard(local_credit_card);

// Duplicate masked server card with same card information as local card.
CreditCard masked_server_credit_card(CreditCard::MASKED_SERVER_CARD,
"server_id_2");
CreditCard masked_server_credit_card = test::GetCreditCard();
masked_server_credit_card.set_record_type(CreditCard::MASKED_SERVER_CARD);
masked_server_credit_card.set_server_id("server_id_2");
std::string server_card_guid("10000000-0000-0000-0000-000000000002");
masked_server_credit_card.set_guid(server_card_guid);
test::SetCreditCardInfo(&masked_server_credit_card, "Test User",
"4111111111111111" /* Visa */, "11", "2022", "1");
masked_server_credit_card.set_instrument_id(1);
masked_server_credit_card.SetNetworkForMaskedCard(kVisaCard);
masked_server_credit_card.SetNumber(u"1111");
Expand Down

0 comments on commit fd4a812

Please sign in to comment.