Skip to content

Commit

Permalink
crow: clean up domain list component
Browse files Browse the repository at this point in the history
Instead of installing the component, clean up the on-disk data.

Fixed: 1401373
Change-Id: Ic972c6249d4d8a01dba8bd053a3830020a7beb13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4327877
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1115741}
  • Loading branch information
Elly Fong-Jones authored and Chromium LUCI CQ committed Mar 10, 2023
1 parent 59b3897 commit fe86669
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 206 deletions.
2 changes: 0 additions & 2 deletions chrome/browser/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -2928,8 +2928,6 @@ static_library("browser") {
"commerce/merchant_viewer/web_contents_helper.cc",
"commerce/price_tracking/android/price_tracking_notification_bridge.cc",
"commerce/price_tracking/android/price_tracking_notification_bridge.h",
"component_updater/crow_domain_list_component_installer.cc",
"component_updater/crow_domain_list_component_installer.h",
"content_creation/notes/internal/android/note_service_bridge_factory.cc",
"content_creation/notes/internal/note_service_factory.cc",
"content_creation/notes/internal/note_service_factory.h",
Expand Down

This file was deleted.

This file was deleted.

8 changes: 6 additions & 2 deletions chrome/browser/component_updater/registration.cc
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
#endif // BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC)

#if BUILDFLAG(IS_ANDROID)
#include "chrome/browser/component_updater/crow_domain_list_component_installer.h"
#include "chrome/browser/component_updater/real_time_url_checks_allowlist_component_installer.h"
#endif // BUILDFLAG(IS_ANDROID)

Expand Down Expand Up @@ -202,8 +201,13 @@ void RegisterComponentsForUpdate() {
#endif // !BUILDFLAG(IS_ANDROID)

#if BUILDFLAG(IS_ANDROID)
RegisterCrowDomainListComponent(cus);
RegisterRealTimeUrlChecksAllowlistComponent(cus);
// TODO(https://crbug.com/1423159): Clean this up once it's been live for a
// few months.
base::ThreadPool::PostTask(
FROM_HERE, {base::TaskPriority::BEST_EFFORT, base::MayBlock()},
base::GetDeleteFileCallback(
path.Append(FILE_PATH_LITERAL("CreatorChipConfig"))));
#endif // BUIDLFLAG(IS_ANDROID)

RegisterAutofillStatesComponent(cus, g_browser_process->local_state());
Expand Down

0 comments on commit fe86669

Please sign in to comment.