-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ios] Create directory for Password Issues.
This patch moves to a new directory files related to the Password Issues surface in Bling's Password Manager. Unused deps were removed from the original source sets of the moving files. Fixed:1425170 Change-Id: I2be2952e6fbbccea8052298c96083f2996e2610c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4343521 Commit-Queue: Ernesto Izquierdo Clua <eic@google.com> Auto-Submit: Ernesto Izquierdo Clua <eic@google.com> Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118422}
- Loading branch information
Ernesto Izquierdo Clua
authored and
Chromium LUCI CQ
committed
Mar 16, 2023
1 parent
db41689
commit fee5b52
Showing
22 changed files
with
177 additions
and
102 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
104 changes: 104 additions & 0 deletions
104
ios/chrome/browser/ui/settings/password/password_issues/BUILD.gn
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| # Copyright 2023 The Chromium Authors | ||
| # Use of this source code is governed by a BSD-style license that can be | ||
| # found in the LICENSE file. | ||
|
|
||
| source_set("password_issues") { | ||
| configs += [ "//build/config/compiler:enable_arc" ] | ||
| sources = [ | ||
| "password_issues_coordinator.h", | ||
| "password_issues_coordinator.mm", | ||
| "password_issues_mediator.h", | ||
| "password_issues_mediator.mm", | ||
| ] | ||
| deps = [ | ||
| ":password_issues_ui", | ||
| "//base", | ||
| "//components/google/core/common", | ||
| "//components/password_manager/core/browser", | ||
| "//components/password_manager/core/common:features", | ||
| "//components/sync/driver", | ||
| "//ios/chrome/app/strings", | ||
| "//ios/chrome/browser/application_context", | ||
| "//ios/chrome/browser/favicon", | ||
| "//ios/chrome/browser/main:public", | ||
| "//ios/chrome/browser/net:crurl", | ||
| "//ios/chrome/browser/passwords", | ||
| "//ios/chrome/browser/shared/coordinator/chrome_coordinator", | ||
| "//ios/chrome/browser/shared/public/commands", | ||
| "//ios/chrome/browser/shared/ui/table_view", | ||
| "//ios/chrome/browser/shared/ui/table_view:utils", | ||
| "//ios/chrome/browser/sync", | ||
| "//ios/chrome/browser/ui/settings/password:common", | ||
| "//ios/chrome/browser/ui/settings/password/password_checkup:password_checkup_constants", | ||
| "//ios/chrome/browser/ui/settings/password/password_checkup:password_checkup_utils", | ||
| "//ios/chrome/browser/ui/settings/password/password_details", | ||
| "//ios/chrome/common/ui/favicon:favicon_constants", | ||
| "//ios/chrome/common/ui/reauthentication", | ||
| "//ui/base", | ||
| ] | ||
| } | ||
|
|
||
| source_set("password_issues_ui") { | ||
| configs += [ "//build/config/compiler:enable_arc" ] | ||
| sources = [ | ||
| "password_issue.h", | ||
| "password_issue.mm", | ||
| "password_issue_content_item.h", | ||
| "password_issue_content_item.mm", | ||
| "password_issue_group.h", | ||
| "password_issue_group.mm", | ||
| "password_issues_consumer.h", | ||
| "password_issues_presenter.h", | ||
| "password_issues_table_view_controller.h", | ||
| "password_issues_table_view_controller.mm", | ||
| ] | ||
| deps = [ | ||
| "//base", | ||
| "//components/password_manager/core/browser", | ||
| "//ios/chrome/app/strings", | ||
| "//ios/chrome/browser/net:crurl", | ||
| "//ios/chrome/browser/shared/ui/table_view", | ||
| "//ios/chrome/browser/shared/ui/table_view/cells", | ||
| "//ios/chrome/browser/ui/settings:settings_root", | ||
| "//ios/chrome/browser/ui/settings/password:password_constants", | ||
| "//ios/chrome/common/ui/favicon", | ||
| "//ui/base", | ||
| ] | ||
| } | ||
|
|
||
| source_set("unit_tests") { | ||
| configs += [ "//build/config/compiler:enable_arc" ] | ||
| testonly = true | ||
| sources = [ | ||
| "password_issues_mediator_unittest.mm", | ||
| "password_issues_table_view_controller_unittest.mm", | ||
| ] | ||
| deps = [ | ||
| ":password_issues", | ||
| ":password_issues_ui", | ||
| "//base", | ||
| "//base/test:test_support", | ||
| "//components/google/core/common", | ||
| "//components/keyed_service/core", | ||
| "//components/password_manager/core/browser", | ||
| "//components/password_manager/core/browser:test_support", | ||
| "//components/password_manager/core/common:features", | ||
| "//ios/chrome/app/strings", | ||
| "//ios/chrome/browser/application_context", | ||
| "//ios/chrome/browser/browser_state:test_support", | ||
| "//ios/chrome/browser/favicon", | ||
| "//ios/chrome/browser/main:test_support", | ||
| "//ios/chrome/browser/net:crurl", | ||
| "//ios/chrome/browser/passwords", | ||
| "//ios/chrome/browser/passwords:store_factory", | ||
| "//ios/chrome/browser/shared/ui/table_view:test_support", | ||
| "//ios/chrome/browser/sync", | ||
| "//ios/chrome/browser/sync:test_support", | ||
| "//ios/chrome/browser/ui/settings/password/password_checkup:password_checkup_constants", | ||
| "//ios/chrome/browser/ui/settings/password/password_checkup:password_checkup_utils", | ||
| "//ios/web/public/test", | ||
| "//testing/gmock", | ||
| "//testing/gtest", | ||
| "//ui/base", | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.