Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing "browser project" to "web browser project" #120

Closed
wants to merge 1 commit into from
Closed

Changing "browser project" to "web browser project" #120

wants to merge 1 commit into from

Conversation

thendotshikota
Copy link

Adding the word "web" before "browser project" in line 3

@thendotshikota
Changing "browser project" to "web browser project"
c84424c 
Adding the word "web" before "browser project" in line 3
darinwf pushed a commit to neevaco/chromium that referenced this pull request Jun 2, 2022
@pkasting
Fix transparent ring in downloaded QR code image.
2a54463 
(cherry picked from commit e00bee1)

Bug: 1318417
Change-Id: I8df6e3a665b5e6920ee2a2cbfe8e2521b2e1523e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3601209
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Travis Skare <skare@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#994929}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3603363
Cr-Commit-Position: refs/branch-heads/5005@{chromium#120}
Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}
pkviet pushed a commit to pkviet/chromium that referenced this pull request Jun 4, 2022
[M101] Re-path libclearkeycdm.so in test-ash-chrome.yaml
864023f 
This is a test only change.
Similar to crrev.com/c/3448036, this step has been failing
since the path changed in crrev.com/c/2033936.

(cherry picked from commit 5f369e5)

Bug: 1308979
Change-Id: Ia7bc09e6a2fcde60f51ed7c8a2dba6b5f880f37d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546759
Auto-Submit: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#984523}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3547397
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4951@{chromium#120}
Cr-Branched-From: 27de622-refs/heads/main@{#982481}
pkviet pushed a commit to pkviet/chromium that referenced this pull request Jun 6, 2022
@meacer
HTTPS-Only Mode: Ignore navigations with no pending navigation item
c6cba25 
In some cases, the pending navigation item can be null (unclear why).
Ignore such navigations and simply allow the response. Also clear all
the state.

(cherry picked from commit 02045fe)

Bug: 1302509, 1325271
Change-Id: If53894adf730994ee50785a0a122dfd9c4956e24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3651859
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1004678}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3654887
Auto-Submit: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5060@{chromium#120}
Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
ashie pushed a commit to clear-code/chromium that referenced this pull request Jul 13, 2022
@npm1
[M96] Ship interactionId
f817fa6 
Intent to Ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/a5cInmNh0Ro

(cherry picked from commit 5f47e34)

Bug: 1236758
Change-Id: Ifaf79755e61c015aa3c4ad216b4fbcfae7a26c5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206750
Auto-Submit: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#930725}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223919
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Owners-Override: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/4664@{chromium#120}
Cr-Branched-From: 24dc4ee-refs/heads/main@{#929512}
darinwf pushed a commit to neevaco/chromium that referenced this pull request Aug 10, 2022
Updating XTBs based on .GRDs from branch 5112
a75a655 
Change-Id: Iaf861f880c516132abc1717dd5662ae4691b0fa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3711960
Auto-Submit: Ben Mason <benmason@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5112@{chromium#120}
Cr-Branched-From: b13d3fe-refs/heads/main@{#1012729}
wendachuan pushed a commit to wendachuan/chromium that referenced this pull request Jan 7, 2023
@mrefaat88
[M100] Fix incognito tabs not activated properly on search mode
172460c 
The problem is that the code used to check on with the
regularTabDelegate to see if the selection process was actually
successful (to see if its a tab from another window) however if should
check both incognito and regular delegate based on the current mode.

(cherry picked from commit d966dea)

Fixed: 1300522
Change-Id: I2e10d8ce9070363fa5cadd1c0cf1bfd9cbfb6c63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3489807
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Auto-Submit: Mohammad Refaat <mrefaat@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#975231}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3493117
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4896@{chromium#120}
Cr-Branched-From: 1f63ff4-refs/heads/main@{#972766}
@thendotshikota thendotshikota closed this by deleting the head repository Jan 17, 2023
MaoHan001 pushed a commit to riscv-android-src/chromium that referenced this pull request Jan 17, 2023
[m109]Make JP options page work again
878bb76 
As part of this, revert the commit below:

Revert "ime: Delete unused GetInputMethodFromId"

This reverts commit e6dc209.

As well as a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/3954822

(cherry picked from commit 7aaf721)

BUG: 1385295
Change-Id: Ic2ae14e6090cec864f2851be39a3c3b055448474
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4033146
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: John Palmer <jopalmer@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Auto-Submit: John Palmer <jopalmer@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1073088}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4036466
Cr-Commit-Position: refs/branch-heads/5414@{chromium#120}
Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}
wwwppp0801 pushed a commit to wwwppp0801/chromium that referenced this pull request Feb 13, 2023
Prevent crash after moving the last item from a folder
55bc7f1 
Existing logic of unfoldering the last item to the right:
1) calculate target position as "folder index + 1";
2) move item at that position;
3) delete the folder;
4) reparented item moves one position back.

The issue was that code continues using position from 1) after 4).
This leads to:
1) focusing the wrong (+ 1) item, if the folder was not at the end;
2) crash, if the folder was at the end of the grid.

(cherry picked from commit efe4528)

Bug: b/262715563
Change-Id: I3208635b8b612057440fc5be993bd8abb5e40b1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4117547
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Artsiom Mitrokhin <amitrokhin@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1086060}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4135539
Cr-Commit-Position: refs/branch-heads/5481@{chromium#120}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
chirayudesai pushed a commit to chirayudesai/chromium that referenced this pull request Mar 7, 2023
[M111] Update feed protos.
f33670a 
Includes adding OPEN_WEB_FEED_COMMAND to capabilities.

(cherry picked from commit 9a122f8)

Bug: 1380541
Change-Id: I94c6eea01a57bbe35cdf8c03ecdfdd440b8b5066
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4209573
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Sophey Dong <sophey@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1099429}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4217480
Cr-Commit-Position: refs/branch-heads/5563@{chromium#120}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
calyxos-gerrit pushed a commit to CalyxOS/chromium that referenced this pull request Mar 31, 2023
[Merge 112] Track whether a frame has had user-initiated edits in Per…
4cbbed3 
…formanceManager

This will be useful to avoid discarding tabs that have user-entered data
even if that data was entered in non-forms elements (such as elements
with the contenteditable property set to true).

(cherry picked from commit 6d331b8)

Bug: 1156388
Change-Id: Ie960fb00e3d6103c62d90b4dfc38a5b58c14f216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4281658
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Auto-Submit: Anthony Vallée-Dubois <anthonyvd@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Francois Pierre Doray <fdoray@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1110710}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4300069
Owners-Override: Gabriel Charette <gab@chromium.org>
Commit-Queue: Anthony Vallée-Dubois <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/5615@{chromium#120}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
l0hn pushed a commit to l0hn/chromium_test that referenced this pull request Jun 9, 2023
Incrementing VERSION to 114.0.5735.13
2904bc5 
Change-Id: I13847151f00aa2f66ebc70b840f9a959cd7d211a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4495429
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5735@{chromium#120}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
msizanoen1 pushed a commit to qtmlabs/chromium that referenced this pull request Jun 27, 2023
[M116] lacros: fix the buffer scale when setting wayland cursor
e2ee9a3 
Cursor in lacros is oversize because the buffer scale is not
set correctly because surface_submission_in_pixel_coordinates
was never meant to be used for cursor and lacros should just
use the standard wayland cursor protocol. Wayland cursor does
not submit surface in pixel coordinates as only AuraToplevel and
AuraPopup implement SetClientSubmitsSurfacesInPixelCoordinates.
Thus we still need to set buffer scale explicitly.

Also `WebCursor::GetNativeCursor` scale the cursor from
its image scale factor to device scale factor. Because device
scale factor is not always integer (e.g. 2.08) and wayland set
buffer scale can only accept integer, there might be rounding
error and cause wrong bitmap size when calculating the logical
pixel bitmap in ash. The solution is to keep image scale factor
which should be integer so that there won't be rounding error.

This approach can also fix mis-scaled cursor with multi-display
(i.e. when moving a lacros window from a 1x display to a 2x display,
the cursor scale is wrong in 2x) because we don't do any scaling in
lacros anymore.

(cherry picked from commit 9bd82dc)

Bug: 1450385, 1450388, 1440148, b/285205466
Change-Id: I4498cd01c5c13bba0436f14226929144bd641d9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583534
Reviewed-by: Mike Wasserman <msw@chromium.org>
Commit-Queue: Yichen Zhou <yichenz@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1162030}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4647668
Cr-Commit-Position: refs/branch-heads/5845@{chromium#120}
Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
aetota61 pushed a commit to monkbrowser/monk-browser that referenced this pull request Aug 2, 2023
[M115] Fix an underflow when ModelReadyToSync is called
988be40 
This CL fixes an underflow that is happening when
ReadingListSyncBridge::ModelReadyToSync() is called from
ReadingListModelImpl::StoreLoaded() by suppressing the observer
notification when ReadingListSyncBridge::ModelReadyToSync() called.

When ReadingListSyncBridge::ModelReadyToSync() is called from
ReadingListModelImpl::StoreLoaded(), it's called before
ReadingListModelLoaded() is called, and it could reach to
ReadingListModelImpl::DeleteAllEntries() which means notifying deletions
to DualReadingListModel, which decrement the
DualReadingListModel::unread_entry_count_ and
DualReadingListModel::read_entry_count_ before they are initialized,
which causes the underflow.

(cherry picked from commit 4c6016c)

Fixed: 1446140
Change-Id: I6968bba233a505ae4bbc9a568fc5e074945a0603
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4552758
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mahmoud Rashad <mmrashad@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1148616}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568075
Cr-Commit-Position: refs/branch-heads/5790@{chromium#120}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
trflynn89 pushed a commit to RebelBrowser/rebel that referenced this pull request Oct 26, 2023
[M118][X-Device Restore] Add null check for web contents on resync pl…
9f65ae5 
…aceholder tabs

To resolve an edge case crash that seems to be happening when placeholder tabs are resynced, check that the newly retrieved web contents is not null, otherwise early exit when attempting to associate the placeholder tab.

(cherry picked from commit ee28dc7)

Bug: 1479576
Change-Id: I4cdf93771db6d1b362312bf2ed37ad2c54a00dbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4846955
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Brandon Fong <bjfong@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1194256}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4855165
Auto-Submit: Brandon Fong <bjfong@google.com>
Commit-Queue: Marc Treib <treib@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5993@{chromium#120}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
Roll Chrome Win64 PGO Profile
c685905 
Roll Chrome Win64 PGO profile from chrome-win64-6045-1696570439-374e4053f792f6f29839ac2fd9fcec7d23e9067e.profdata to chrome-win64-6045-1696590050-0afcc23767e5a375d9663a31ef78688f16b431a0.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m119.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I79f8480c82de467e619d63f0ff44eee0abc91f46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4918098
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6045@{chromium#120}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori referenced this pull request in Pissandshittium/pissandshittium Dec 8, 2023
Tracking Protection: Update Page Info strings
08e9a66 
Merge approved in crbug.com/1497950

(cherry picked from commit 2b32738)

Bug: 1497950
Fixed: b:308165421, b:308160744
Change-Id: Iea0abafd1ca46d045f2e389ca2904fec265ea356
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4987085
Reviewed-by: Nicola Tommasi <tommasin@chromium.org>
Commit-Queue: Andrey Zaytsev <andzaytsev@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/main@{#1217497}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003795
Auto-Submit: Andrey Zaytsev <andzaytsev@google.com>
Commit-Queue: Nicola Tommasi <tommasin@chromium.org>
Cr-Commit-Position: refs/branch-heads/6099@{#120}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable pushed a commit that referenced this pull request Jan 6, 2024
Roll src/v8 from 21e09a5486b0 to 6d9556de835d
5f86e7e 
Commits rolled:
https://chromium.googlesource.com/v8/v8.git/+log/21e09a5486b0..6d9556de835d

Generated by: go/bbid/8762280657438392321

Change-Id: I0374c91e87703745baf5b9fcf2424339d9c98835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5104388
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6167@{#120}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable pushed a commit that referenced this pull request Jan 26, 2024
[M122][ForceSignin] Add a feature param to control the reauth url used
9352f7c 
Feature param to control whether to use the url for reauth as:
- /AccountChooser (default)
- /AddSession (fallback through config)

(cherry picked from commit 2ce5c64)

Bug: 1478217
Fixed: 1521324
Change-Id: Iaa6c13a45103910e3b0aadbc11a9db1528b88844
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5233707
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Ryan Sultanem <rsult@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1251442}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237410
Commit-Queue: David Roger <droger@chromium.org>
Auto-Submit: Ryan Sultanem <rsult@google.com>
Cr-Commit-Position: refs/branch-heads/6261@{#120}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
consp1racy pushed a commit to signageos/chromium-chromium that referenced this pull request Feb 21, 2024
[Merge M95] Side panel: fix current page action button state after sw…
1e39a59 
…itching tabs.

The reading list doesn't receive updates in the side panel while the
bookmarks tab is open so when the side panel opens straight to the
bookmarks tab then the current state action button isn't appropriately
updated. This change makes sure the button state is updated when
switching to the reading list tab.

(cherry picked from commit 30a0317)

Bug: 1248552
Change-Id: I3334857189d8061cf527f4185c9bf49dbe30c569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3158449
Reviewed-by: John Lee <johntlee@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#921657}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168932
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Auto-Submit: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/branch-heads/4638@{chromium#120}
Cr-Branched-From: 159257c-refs/heads/main@{#920003}
aarongable pushed a commit that referenced this pull request Feb 24, 2024
Roll Chrome Linux PGO Profile
39dce77 
Roll Chrome Linux PGO profile from chrome-linux-6312-1708731904-70246f1ee7d3a5a1e09dd39235bb1c4fed412520-3f21022be53be68a67bb0890e792e74a7568c83f.profdata to chrome-linux-6312-1708744026-a7a00df54a31a3aafd5a5eeb4822d1b8fd286cd6-0fa15e1cfeb54595a3c4f8b841d890f20fe1f787.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m123.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I02c094259a8b44f0087109bf8b4fa8b23b1d7b99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5322561
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6312@{#120}
Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
NaaeemMalik pushed a commit to SoftwarePrince/Egon-Chromium that referenced this pull request Mar 22, 2024
[M117] IndexedDB: ignore re-entrancy when draining IDBTransaction res…
02a2284 
…ult queue

The re-entrancy can occur when a transaction-aborting error occurs
during the dispatch of an event for a request that's in the queue and
ahead of another request which is still loading. Then second request
gets canceled, and canceling it causes `IDBTransaction::OnResultReady`
to run again, nestedly. We can safely just return here as the queue
will keep draining and doesn't need to be kicked again.

A unit test is added because it would be tricky to create a WPT since
the crucial element is that a blob-wrapped value needs to be still
loading when the error occurs, and there's no way to cause that
implementation detail to occur from script.

There are also another couple small updates to false assumptions in
this CL which probably didn't cause crashes.

(cherry picked from commit 8196aab)

Bug: 1470485
Change-Id: I20aaad8b356b0005f3a88323a855ee00c4951227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4766320
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1182197}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4777995
Reviewed-by: Nathan Memmott <memmott@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/branch-heads/5938@{chromium#120}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable pushed a commit that referenced this pull request Mar 22, 2024
Roll Chrome Mac PGO Profile
e5f8fb9 
Roll Chrome Mac PGO profile from chrome-mac-6367-1711077473-3cec1faeec3fdf630c22ce1367c96e1bcce43785-a07f2b73f7abd27e90bbfc1cb75764bea0867242.profdata to chrome-mac-6367-1711104562-a7c1703ce45f4d73de4bc10385a6a82bb7ef2d64-244c3f065d8f423ec397f9a2832b4fc184cb0e70.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m124.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ie5875c576ef8a748c61f5b349ec592be69b70b36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5386932
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6367@{#120}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable pushed a commit that referenced this pull request Apr 19, 2024
[m125][ios] Fix crash if disconnect is called before updating item
1f6f3db 
If the user navigates away from the NTP before an async callback that
would normally mark an item complete, it is possible that the
_localState ivar will have already been cleared by disconnect. In this
case, we can skip updating the item's state and it will be updated the
next time the mediator loads.

(cherry picked from commit 38f9634)

Fixed: 335385961
Change-Id: I484b7eb7cac578f4503d6899487aceeb94e4a8e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5462240
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Auto-Submit: Scott Yoder <scottyoder@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1289098}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5462871
Reviewed-by: Krishna Govind <govind@chromium.org>
Owners-Override: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/6422@{#120}
Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable pushed a commit that referenced this pull request May 17, 2024
Roll Chrome Win32 PGO Profile
19e5df3 
Roll Chrome Win32 PGO profile from chrome-win32-6478-1715882376-d198b71c0e4000176b7f50a5c7704ed38bf9dc86-b91fb31cda4d2836845e793becbd36bd039a5869.profdata to chrome-win32-6478-1715902542-dff1a204083a1b9be9d7e2369133a9590c700a53-cf25b1ca365049f0f979f0792c0261c47167e582.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m126.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I49e1d7bbca9a54ee6f09c97e7c7b4ded5dec26aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5546743
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#120}
Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielVilaBoa DanielVilaBoa DanielVilaBoa approved these changes

@leonardodimarchi leonardodimarchi leonardodimarchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@thendotshikota @DanielVilaBoa @leonardodimarchi