update windows docs to help people on limited internet connection #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update windows_build_instructions.md to help people on limited internet packages like myself
update windows_build_instructions.md to help people on limited connection
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
when will it get approved please let me know, its my first contribution |
Kokobe
pushed a commit
to neevaco/chromium
that referenced
this pull request
Sep 15, 2022
Change-Id: Icaf78542f6cbe85b42d2a7b3eb34e0fc7abbbfc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3796228 Auto-Submit: Ben Mason <benmason@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5195@{chromium#134} Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
|
Hi |
wendachuan
pushed a commit
to wendachuan/chromium
that referenced
this pull request
Jan 7, 2023
Disable tab grid drag and dropping while the user is in search mode. (cherry picked from commit 3c75b60) Bug: 1300369 Change-Id: I79ee2382ffa1e5b366b3042d708eb0362cea9290 Fixed: 1300079, 1300180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3486296 Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#974745} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3495622 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/branch-heads/4896@{chromium#134} Cr-Branched-From: 1f63ff4-refs/heads/main@{#972766}
MaoHan001
pushed a commit
to riscv-android-src/chromium
that referenced
this pull request
Jan 17, 2023
Repositions the fullscreen notification toast when window layout changes. This keeps the toast from being obscured by decreased window height. (cherry picked from commit 69def73) Bug: 1382484 Change-Id: Ib24e0df6d5c9dd024b50203d1f35330411e5c887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4021894 Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1072510} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4035653 Cr-Commit-Position: refs/branch-heads/5414@{chromium#134} Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}
wwwppp0801
pushed a commit
to wwwppp0801/chromium
that referenced
this pull request
Feb 13, 2023
…riseRealTimeUrlLookup Service (cherry picked from commit d6206e4) Bug: 1402746 Change-Id: Ib091b62b916219e1e47ec8b683e7784e08d1a975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4113106 Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Sneha Nagpaul <snehanagpaul@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1085620} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4133368 Cr-Commit-Position: refs/branch-heads/5481@{chromium#134} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
chirayudesai
pushed a commit
to chirayudesai/chromium
that referenced
this pull request
Mar 7, 2023
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file go/crostc-bug. Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ieca14daff869d7ebef0b7118fe0c86460320eb01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4217862 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{chromium#134} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
calyxos-gerrit
pushed a commit
to CalyxOS/chromium
that referenced
this pull request
Mar 31, 2023
WebView can be embedded in a Fullscreen application, without itself being Fullscreen. If the WebView is of a different Orientation from that of the application, it can end up failing to synchronize. The handling of mismatched orientations of the PhysicalBackingSize and ScreenInfo was missing removing a throttle used for initial fullscreen transitions. This change re-adds it. This change also fixes the parameterization in the tests, which didn't have the Disable path updated when the flag was changed to be on by default TEST=*RenderWidgetHostViewAndroid* (cherry picked from commit 3bf767a) Bug: 1418321 Change-Id: I2cfb0f404a3f8a4a958cebf9853f1ed2044cb18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4297803 Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1111225} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4304238 Auto-Submit: Jonathan Ross <jonross@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5615@{chromium#134} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
l0hn
pushed a commit
to l0hn/chromium_test
that referenced
this pull request
Jun 9, 2023
Prior to this change, changing settings for inactive tabs would dismiss the settings and pop Inactive Tabs underneath when the setting change would mean there were no longer any inactive tabs. With this CL, the auto-closing is scheduled to run when settings are dismissed, if they are presented. Before: https://drive.google.com/open?id=12t-Xewos0ij9khDUQR2njrj8TMhm9Zgu After: https://drive.google.com/open?id=12iJxzG6UL1FQdRxvjpESOMl_ERykemv7 (cherry picked from commit 4d787c6) Fixed: 1440728 Fixed: 1439957 Change-Id: I11a71810308cb4de7bb07b43b3380b2818ce7793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4481488 Commit-Queue: Louis Romero <lpromero@google.com> Reviewed-by: Aliona Dangla <alionadangla@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1137057} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4496385 Auto-Submit: Louis Romero <lpromero@google.com> Cr-Commit-Position: refs/branch-heads/5735@{chromium#134} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
msizanoen1
pushed a commit
to qtmlabs/chromium
that referenced
this pull request
Jun 29, 2023
The CL adds a placeholder to the issue description section of the autofill feedback form. Note that this targets an internal feature, so no translation is necessary. (cherry picked from commit 7385f0c) Bug: 1407646, 1457142 Change-Id: I8bb5eec94a30c7a8d99b97bc33f2c1f278a1cc0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4629310 Reviewed-by: Dominic Battre <battre@chromium.org> Commit-Queue: Norge Vizcay <vizcay@google.com> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1161190} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4641930 Reviewed-by: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/branch-heads/5845@{chromium#134} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
debugeek
pushed a commit
to debugeek/chromium
that referenced
this pull request
Jul 6, 2023
…rly context destruction. (We aren't sure when it happened) There is high number of crashes when RTCPeerConnectionHandler::GetStats is called after it is closed by RTCPeerConnection. It could happen RTCPeerConnection::ContextDestroyed is called before getStats calls because these two events can occur out of order. The fix is made to check peer_handler_unregistered_ before calling peer_handler_->GetStats. If it is unregistered, it will detach the promise by spec. (cherry picked from commit c88b71d) Bug: 1289799 Change-Id: I6471fd9431543c97b0af12963510ec58db8f9f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3594496 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#994545} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3605181 Auto-Submit: Henrik Boström <hbos@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/branch-heads/5005@{chromium#134} Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}
aetota61
pushed a commit
to monkbrowser/monk-browser
that referenced
this pull request
Aug 2, 2023
crrev.com/c/4505893 added logic to use the app monochrome icon or colored icon on the home tab instead of the favicon, but Terminal is dynamically setting the color of their favicon. (cherry picked from commit 6099084) Bug: 1381377 Change-Id: I382e36d31945d8f5edc758ec9e83c805c82b4b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4559845 Commit-Queue: Louise Brett <loubrett@google.com> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1149399} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569972 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Louise Brett <loubrett@google.com> Cr-Commit-Position: refs/branch-heads/5790@{chromium#134} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
trflynn89
pushed a commit
to RebelBrowser/rebel
that referenced
this pull request
Oct 26, 2023
The Profile* passed to DeveloperPrivateAPI::CreateProfileInfo can be an incognito profile. Since SupervisedUserService is not created on incognito, this CL add a nullptr check for such case and add the description for SupervisedUserServiceFactory. (cherry picked from commit 353734a) Bug: 1478591, 1479891 Change-Id: I9dc00a987306a2c8444233ba877a50297fe049de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4843033 Reviewed-by: Alex Ilin <alexilin@chromium.org> Commit-Queue: Duong Dac <ddac@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1192983} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4847112 Cr-Commit-Position: refs/branch-heads/5993@{chromium#134} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
Change-Id: I4255a6f9bbe16a21b484304bc35496499a6c4715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4916404 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#134} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori
referenced
this pull request
in Pissandshittium/pissandshittium
Dec 8, 2023
The default (for when there should be no threshold) should be -1, not 0, because the diff algorithm rounds down the percentage from float using a floor function (so a 1.5% change is considered a 1% change, and -- subsequently -- a 0.5% change is a 0% change). 100% is reserved for more drastic changes, such as when configs change, etc. (cherry picked from commit ba8636a) Bug: 1498054 Change-Id: I4b9cc1d51eab6d10ebd418abc6a36322061562ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4994727 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Ella Ge <eirage@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1217861} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5001994 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/branch-heads/6099@{#134} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Jan 6, 2024
This patch changes the UI in the search engine choice screen: + Increase the fake omnibox width + Reduce the margin between the icon and the name in the fake omnibox + Add radius corner for the icon in the fake omnibox + Remove the border for the icon in the search engine cell + Increase the icon size in the search engine cell + Increase the icon container in the search engine cell Before: https://drive.google.com/file/d/1UORNnYu-o4vs6ACPTzV_Fx0X_6_Uw_h5/view?usp=drive_link&resourcekey=0-MfuQEDdTfAYyCw413GVD3g After: https://drive.google.com/file/d/1dagRsne_4xfxbK0gzZhaNybrGKTf0X7u/view?usp=drive_link&resourcekey=0-CPTFcFbKnuvG-Usof-wj0w (cherry picked from commit 6f80ec9) Fixed: 1509408, b/306371771, b/306365268 Change-Id: I30a1f2d3eb5ccc5cc44eed482a30d342e05bf61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5097748 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Samar Chehade-Lepleux <samarchehade@google.com> Reviewed-by: Samar Chehade-Lepleux <samarchehade@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1234516} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5104970 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/branch-heads/6167@{#134} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable
pushed a commit
that referenced
this pull request
Jan 26, 2024
Roll Chrome Linux PGO profile from chrome-linux-6261-1706239603-ef14449b0980c24cf6568e5a633abcb0749250ee.profdata to chrome-linux-6261-1706267230-ec7f9f3b5f6ba0d53a641fb6661fe003e7119aa2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m122.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I191b36e7c55b51cbb477544548475e65539c8a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5239244 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#134} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
consp1racy
pushed a commit
to signageos/chromium-chromium
that referenced
this pull request
Feb 21, 2024
A previous patch (crrev.com/c/3072884) made text descendants of list markers hidden, and as a result, we no longer have word starts and ends information on list marker text. This patch adds it back. (cherry picked from commit bb2cdc9) Bug: 1166766 Change-Id: Id5d49b2acc51fb816d3597be5f4fd806fed16397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3149363 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#920922} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3169424 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/branch-heads/4638@{chromium#134} Cr-Branched-From: 159257c-refs/heads/main@{#920003}
aarongable
pushed a commit
that referenced
this pull request
Feb 26, 2024
Change-Id: Ia01c4976a18a1eb290f93884c764d509d21e4c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321664 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6312@{#134} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
NaaeemMalik
pushed a commit
to SoftwarePrince/Egon-Chromium
that referenced
this pull request
Mar 22, 2024
Essentially the same as "Net.HttpJob.PrefilterBytesRead.Net" and "DataUse.BytesSent" but only for requests that are covered by IP Protection. (cherry picked from commit fb1873f) Bug: 1471278 Change-Id: I41e4dceb3b832202fa28ea122cd6d87fbd57178f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4762824 Commit-Queue: Alex Kallam <aakallam@chromium.org> Reviewed-by: Andrew Williams <awillia@chromium.org> Reviewed-by: David Schinazi <dschinazi@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1182083} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4770956 Cr-Commit-Position: refs/branch-heads/5938@{chromium#134} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable
pushed a commit
that referenced
this pull request
Mar 22, 2024
Roll Chrome Linux PGO profile from chrome-linux-6367-1711104562-18055a6685f5cf7b1e10998e12748f1eb28afb25-244c3f065d8f423ec397f9a2832b4fc184cb0e70.profdata to chrome-linux-6367-1711129065-ef39ab3264002d67726e2f7dd81f5aff61cb4b6b-73505ebaf922c5ea595491516502214af19090b0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m124.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iddbf5e900a52ea2acf0cde783e3e63b4212b1442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5388809 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367@{#134} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable
pushed a commit
that referenced
this pull request
Apr 19, 2024
(cherry picked from commit 77859c4) Bug: 335316706 Change-Id: I1b40b9170f24d6589ad9d9ca552f6a34cafcf70d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5462187 Reviewed-by: Charles Meng <charlesmeng@chromium.org> Reviewed-by: Eshwar Stalin <estalin@chromium.org> Commit-Queue: Alison Gale <agale@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1289037} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467061 Cr-Commit-Position: refs/branch-heads/6422@{#134} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable
pushed a commit
that referenced
this pull request
May 17, 2024
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6478-1715929159-827780b8696cb22acc26ec93aa6045e8ae85a8de-463bc638ccab6879ff680df4919c0f2b96c92dbc.profdata to chrome-mac-arm-6478-1715937363-b6a3a09bc34d6cfba1d3f139249411f3e41e4d7c-39b84e1445f4e05247f319dce8b8bf23ca5ace48.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie778025d2fa1f6144f00966abf6038ae4d4cf201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548095 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#134} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
people on limited internet like myself face alot of problems contributing to chromium with current docs so please approve it.
view discussion in comments for more info https://www.youtube.com/watch?v=aWXkpJ6Pn0c&lc=UgzA7-aMYYDSeMET1gh4AaABAg