Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed grammar in Read.md! #138

Closed
wants to merge 1 commit into from
Closed

Fixed grammar in Read.md! #138

wants to merge 1 commit into from

Conversation

KaiPereira
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented Nov 7, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@KaiPereira KaiPereira closed this Nov 7, 2022
@KaiPereira KaiPereira reopened this Nov 7, 2022
@KaiPereira KaiPereira closed this Nov 7, 2022
blueboxd referenced this pull request in blueboxd/chromium-legacy Nov 30, 2022
@drott
[Merge] Roll src/third_party/freetype/src/ 5182264a4..0b62c1e43 (8 co…
99dd799 
…mmits)

Cherry-picked https://chromium-review.googlesource.com/c/chromium/src/+/3965188
by locally rolling FreeType to 0b62c1e43 in this branch.

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/5182264a40e7..0b62c1e43dc4

$ git log 5182264a4..0b62c1e43 --date=short --no-merges --format='%ad %ae %s'
2022-10-18 drott [sfnt] Additional bounds checks for `COLR` v1 table handling.
2022-10-18 wl [gzip] Update sources to zlib 1.2.13.
2022-10-18 apodtele * src/sfnt/ttsbit.c (tt_face_load_strike_metrics): Simplify calculations.
2022-10-18 wl Minor formatting.
2022-10-17 drott [sfnt] Guard individual `COLR` v1 paint field reads.
2022-10-05 xiaoxiang * builds/toplevel.mk: Prefix all paths with `$(TOP_DIR)/`.
2022-10-16 liukunpeng * src/base/ftsynth.c (FT_GlyphSlot_Slant): New API with custom slant. * include/freetype/ftsynth.h (FT_GlyphSlot_Slant): Declare it.
2022-10-14 apodtele Note the lack of floating-point data types.

Created with:
  roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org

Bug: 1375290
Change-Id: Ic96b975e49e221aaa4dbe23a26fd2da25d1edaae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3968068
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/branch-heads/5359@{#138}
Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
fujunwei pushed a commit to fujunwei/chromium that referenced this pull request Dec 8, 2022
@matt-mueller
TrustStoreMac::TrustImplDomainCacheFullCerts keychain notification fixes
b0c162b 
1. Ensure that KeychainChangedNotifier::KeychainCallback doesn't get
code-folded. SecKeychainAddCallback is keyed on the function pointer
only, so if the code gets folded together by the optimizer, only one
of the notifications would actually be honored by MacOS, even if
each one had a different context pointer.

2. Fix issue with the 2nd part of MaybeInitializeCache checking
trust_iteration_ after it had already been updated, meaning that
condition would only update on the certs_iteration_ changing (which
can be never due to problem number 1.)

(cherry picked from commit 92821e8)

Fixed: 1365702
Change-Id: Ic59a3709e73dfeecc598086d5429f795a8698e28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3911781
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1050231}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913982
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/branch-heads/5304@{chromium#138}
Cr-Branched-From: 5d7b1fc-refs/heads/main@{#1047731}
wendachuan pushed a commit to wendachuan/chromium that referenced this pull request Jan 7, 2023
@kleerwater
[M100][infra] Use the triggered_by field for the child-parent relatio…
4d7736d 
…nship.

An upcoming change will enable specifying a builder's spec in terms of
another builder so that we can set up builders that mostly mimic other
builders with changes for experiments. This will defer the calculation
of the builder spec until the generator time which means that it can't
be used for creating the necessary edges to establish the relationship.
Using the triggered_by field instead requires the relationship to be
explicitly specified instead of inherited via another builder and ensure
that the necessary edges are created to establish the relationship.

(cherry picked from commit b80e19c)

Bug: 1248219
Change-Id: I6ac7bd957f82682f58374fc2281f2e2849078be1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3484706
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#975884}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3495688
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4896@{chromium#138}
Cr-Branched-From: 1f63ff4-refs/heads/main@{#972766}
MaoHan001 pushed a commit to riscv-android-src/chromium that referenced this pull request Jan 17, 2023
[M109 merge] assistant: Stop observation before stop service
935295c 
We stop observing media/app_list events before we destroy
`AssistantManagerImpl`, otherwise notification may happen any time after it is destroyed.

We also add an assistant status check before calling on `assistant_` functions. We could not assume the assistant manager service is ready even the `assistant_` is valid pointer.

(cherry picked from commit 8704303)

Bug: 1383557
Test: could not repro local, speculative fix
Change-Id: I05fcfe01ec411b80b97c046d68d9708269f487fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4024269
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1071203}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4035661
Cr-Commit-Position: refs/branch-heads/5414@{chromium#138}
Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}
wwwppp0801 pushed a commit to wwwppp0801/chromium that referenced this pull request Feb 13, 2023
@skylab-tests-roller
[skylab_tests] Update skylab tests cros img version
9aa7b48 
This cl only affect Lacros on-device config builders like
lacros-amd64-generic-chrome-skylab. This cl will certainly NOT affect
linux-lacros builders(linux-lacros-tester-rel, linux-lacros-rel, etc)
or any other platforms.
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM
is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV,
CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha.

If this CL caused regressions, please revert and pause the autoroller at
https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller
Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org,
yjt@google.com.


R=rubber-stamper@appspot.gserviceaccount.com

Requires-Testing: True
Change-Id: I7e032ceb3bcdbe508e41c14c605bd8cfe3377b2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4137470
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5481@{chromium#138}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
chirayudesai pushed a commit to chirayudesai/chromium that referenced this pull request Mar 7, 2023
@pakzhygitov
Added logging of new tab-related metrics.
336ffbb 
– Number of duplicate tabs
– Number of old/inactive tabs
– The age of all open tabs

(cherry picked from commit cc1c077)

Bug: 1411663 (b/262494271)
Change-Id: I8f6062217fae0a7218b08487321c8fe0b3a863ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4066012
Commit-Queue: Petro Akzhygitov <pakzhygitov@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1099181}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4217551
Cr-Commit-Position: refs/branch-heads/5563@{chromium#138}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
calyxos-gerrit pushed a commit to CalyxOS/chromium that referenced this pull request Mar 31, 2023
[iOS] Added experimental setting to ignore tile ablation conditions.
86eaa18 
Added an experimental setting to be able to force tile ablation even
when the experiment has concluded.

(cherry picked from commit dc1f0e6)

Bug: 1414513
Change-Id: I5cbc7a92aa6ed64da3c7673e14f0f1907166debe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4298309
Reviewed-by: Adam Arcaro <adamta@google.com>
Commit-Queue: Guillem Perez <guiperez@google.com>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1111213}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4301096
Auto-Submit: Guillem Perez <guiperez@google.com>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/branch-heads/5615@{chromium#138}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
unicornx pushed a commit to unicornx/chromium that referenced this pull request Apr 19, 2023
Roll AFDO from 105.0.5195.13_rc-r1-merged to 105.0.5195.14_rc-r1-merged
7998c0f 
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-beta-autoroll
Please CC gbiv@chromium.org on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: gbiv@chromium.org
Change-Id: I3079f4eec01f71d6f3ee323bef265855ca4145a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3802579
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5195@{chromium#138}
Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
l0hn pushed a commit to l0hn/chromium_test that referenced this pull request Jun 9, 2023
[iOS] Replace NOTREACHED with DumpWithoutCrashing for unhandled shortcut
65f5692 
This CL replaces a call to NOTREACHED with a DumpWithoutCrashing, with a
custom crash key to determine the unhandled shortcut item type.

(cherry picked from commit a376166)

Bug: 1435511
Change-Id: I276f4ea492555b3c5904fc47db7ff1e56cbbfab1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4488903
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Quentin Pubert <qpubert@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1137150}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4496312
Cr-Commit-Position: refs/branch-heads/5735@{chromium#138}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
msizanoen1 pushed a commit to qtmlabs/chromium that referenced this pull request Jun 29, 2023
[Merge 116][NOTREACHED] Fix AccountSelectFillData::GetFillData crash
7cbe1bf 
This happens because we call AccountSelectFillData::Reset() and it
sets last_requested_form_ = nullptr.

In our case, we just want to clear the credentials_ cache. I made a
separate method to clear that cache only.

(cherry picked from commit db0ba83)

Bug: 1457248
Change-Id: Ia5305015f520815bc367cc9fea80adcde6889a92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4638202
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Veronique Nguyen <veronguyen@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1161726}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4651208
Cr-Commit-Position: refs/branch-heads/5845@{chromium#138}
Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
debugeek pushed a commit to debugeek/chromium that referenced this pull request Jul 6, 2023
Do not allow fullscreening during a drag
b992016 
Do not allow a page to attempt to enter fullscreen while it is being
actively dragged. Things break.

(cherry picked from commit 26594d7)

Fixed: 1315080
Change-Id: Ia175339807284a3e0edddfbf8fb26a4b67fdaf04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3601249
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#995196}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3601574
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/branch-heads/5005@{chromium#138}
Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}
aetota61 pushed a commit to monkbrowser/monk-browser that referenced this pull request Aug 2, 2023
@carlosjoan91
Opt-out URLs typed with http scheme from https upgrades.
403eaca 
This only opts out cases where the full http url was typed (e.g. typing http://examp and then choosing example.com from the suggestions will still result in an upgrade, as will navigating to an http url via an http bookmark).

Plumbing for the new flag is somewhat duplicated with added_default_scheme_to_typed_url. This was on purpose (rather than adding a multi-state flag) since schemeless typed navigations upgrades (and thus the added_default_scheme_to_typed_url) will be obsolete when https upgrades fully launch.

Change-Id: I86c4f487b79aa3b4705f2345ddc25ca22a8b4eb4

(cherry picked from commit 67cf5a9)

Bug: 1447921
Change-Id: I86c4f487b79aa3b4705f2345ddc25ca22a8b4eb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4549863
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Chris Thompson <cthomp@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1149342}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4575041
Auto-Submit: Carlos IL <carlosil@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/branch-heads/5790@{chromium#138}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
trflynn89 pushed a commit to RebelBrowser/rebel that referenced this pull request Oct 26, 2023
[M118] [ThumbnailCapturerMac] Fix thumbnail size in recurrent mode
7b3b874 
The thumbnail size was not correctly set. Use the value that is set
instead of the default value.

(cherry picked from commit c532510)

Bug: chromium:1478178
Change-Id: I36fc679ce7d55dd07fb3b88ed53b40d0406fe188
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4852177
Reviewed-by: Elad Alon <eladalon@chromium.org>
Commit-Queue: Johannes Kron <kron@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1194057}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4852088
Cr-Commit-Position: refs/branch-heads/5993@{chromium#138}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
Roll Chrome Win64 PGO Profile
a5f7e8a 
Roll Chrome Win64 PGO profile from chrome-win64-6045-1696590050-0afcc23767e5a375d9663a31ef78688f16b431a0.profdata to chrome-win64-6045-1696614294-8df28bb22d8071db0e9e2c5ba184874386b4f705.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m119.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I73454f5bceb7adf87c22742756a45a912b901117
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4919457
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6045@{chromium#138}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori referenced this pull request in Pissandshittium/pissandshittium Dec 8, 2023
Prevent high efficiency pref observers from firing on startup
f5fdc0c 
This breaks the HaTS survey code which should only be triggered on a
change of the pref, not when the system is initializing. This splits
the initialization from the notifications of the observers. Currently
only two things observe the pref: HaTS and the high efficiency chip.

(cherry picked from commit 0badb43)

Bug: 1466203
Change-Id: I3c1a1d68e33f4bd83126e5545115c5cb637bc78a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4990147
Auto-Submit: Alison Gale <agale@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Anthony Vallée-Dubois <anthonyvd@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1217807}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5002371
Reviewed-by: Francois Pierre Doray <fdoray@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/branch-heads/6099@{#138}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable pushed a commit that referenced this pull request Jan 6, 2024
[android][selection] Add Paste as Plain Text Menu Icon
658b59c 
This CL adds the vector drawable for the "Paste as Plain Text" menu
item.

(cherry picked from commit 7deba9e)

Bug: 1428022, 1508818
Change-Id: I8db791346f121a0e8365748d2c69f0323349eeb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5024997
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Wayne Jackson Jr. <wbjacksonjr@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1233272}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5093894
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/6167@{#138}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable pushed a commit that referenced this pull request Jan 26, 2024
Updating XTBs based on .GRDs from branch 6261
ad27521 
Change-Id: Ia78391a3721344ee6eaf8f8f37ebca23bdf94884
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5238044
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/branch-heads/6261@{#138}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
aarongable pushed a commit that referenced this pull request Feb 26, 2024
Roll Chrome Linux PGO Profile
87ea7f0 
Roll Chrome Linux PGO profile from chrome-linux-6312-1708893129-837d0584413570f60b2d82230bd4f2c8e9287210-c6981c02ac2e7b0f7576cbdc21517f0466976cc8.profdata to chrome-linux-6312-1708915668-3d930b8542f68e691eb457f98345b022d92397c4-ee4d4fb3b65e8af363383e39be19d02343cf94fe.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m123.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I83acf580c65f87bd7fb8b25f73ad292ec24dc586
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5323818
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6312@{#138}
Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
NaaeemMalik pushed a commit to SoftwarePrince/Egon-Chromium that referenced this pull request Mar 22, 2024
@pkasting
Make Windows pre-refresh menus more accurately emulate native.
c2c58ac 
(cherry picked from commit 44ac5f0)

Bug: 1470006
Low-Coverage-Reason: No Win 11 coverage bots
Change-Id: I9a0ab1b8fcf9c938db9d4c5fb2d390b1bfffb505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4762885
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1181800}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4777669
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/branch-heads/5938@{chromium#138}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable pushed a commit that referenced this pull request Mar 22, 2024
@npm1
[M124]Revert "[FedCM] Enable CORS in ID assertion endpoint"
885960b 
This reverts commit b2cb1b5.

Reason for revert: Causing issues to a real IDP

Original change's description:
> [FedCM] Enable CORS in ID assertion endpoint
>
> I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/gYoQJsaiD9E
>
> Bug: 40284123
> Change-Id: I61989f1e7a7578c2f59d87815e3ec2b51b7fc5be
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5370086
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Reviewed-by: Mathias Bynens <mathias@chromium.org>
> Commit-Queue: Nicolás Peña <npm@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1274203}

(cherry picked from commit 4b1c288)

Bug: 40284123
Change-Id: I4a518b55396d5aba676f0a15c9a515451dc11e86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5381316
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/main@{#1276213}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5386308
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/branch-heads/6367@{#138}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable pushed a commit that referenced this pull request Apr 19, 2024
Automatic update from google3
076d6ae 
Automatic update for 2024-04-19 UTC

Change-Id: I63b6c5ca4fc887d5e91c35be8138357704c0e4dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467471
Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Cr-Commit-Position: refs/branch-heads/6422@{#138}
Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable pushed a commit that referenced this pull request May 17, 2024
Roll Chrome Mac Arm PGO Profile
26c3d22 
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6478-1715937363-b6a3a09bc34d6cfba1d3f139249411f3e41e4d7c-39b84e1445f4e05247f319dce8b8bf23ca5ace48.profdata to chrome-mac-arm-6478-1715944004-de75bd2065894eba511e09550ec6f8bf9e715e63-582cd3edc39dd59a36d814d4675db522ecf4ccf7.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: pgo-profile-sheriffs@google.com
Change-Id: Id0550e15516207673d3688f3dfe3f2e15faebc54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548215
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#138}
Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
consp1racy pushed a commit to signageos/chromium-chromium that referenced this pull request May 18, 2024
@rkgibson2
[iOS] Fix jumpy scrolling on overflow menu destination list
4c166b5 
The bug seems to be caused by having variable width views (like Spacer)
in a LazyHStack inside a ScrollView. Maybe some issue where LazyHStack
doesn't properly calculate the variable width when those views aren't
on the screen, thus causing jumpy scrolling.

Regardless, the space we want here is a fixed width, so we can use a
fixed width view instead.

(cherry picked from commit 2498f87)

Fixed: 1355836
Change-Id: If6eb65d39035d402d87808893733a4b73d1373cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3852304
Reviewed-by: David Jean <djean@chromium.org>
Auto-Submit: Robbie Gibson <rkgibson@google.com>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1038635}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3860149
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/branch-heads/5249@{chromium#138}
Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@KaiPereira