Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shorter switch statement #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

shorter switch statement #141

wants to merge 1 commit into from

Conversation

TrueJu
Copy link

@TrueJu TrueJu commented Nov 9, 2022

No description provided.

blueboxd referenced this pull request in blueboxd/chromium-legacy Nov 30, 2022
Metrics for Biometric Authentication in Password Autofill manager
ad18ad9 
This change adds metrics to record time it takes to authentication and
the result of authentication when trying to fill selected password.

(cherry picked from commit 5f130f5c10af24e3f10e18f961ffe5de080850df)

Bug: 1322079
Fixed: 1375276
Change-Id: I3da4cc61056126680fbd5f88f8c95770e244567b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3955900
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1059945}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3963483
Cr-Commit-Position: refs/branch-heads/5359@{#141}
Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
fujunwei pushed a commit to fujunwei/chromium that referenced this pull request Dec 8, 2022
Incrementing VERSION to 107.0.5304.12
30c189a 
Change-Id: I1e1d6483298470636f845a4ad4aa69c7e8d3ec56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914648
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5304@{chromium#141}
Cr-Branched-From: 5d7b1fc-refs/heads/main@{#1047731}
wendachuan pushed a commit to wendachuan/chromium that referenced this pull request Jan 7, 2023
[Start] Add a work around for wrong start surface state
4cc6115 
See go/fix-start-surface-state for more info.

(cherry picked from commit 984a7d0)

Bug: 1298740
Change-Id: Iee3999f82129ec6f9cdbc7aa84fdd9083af8d047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3472512
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Hao Dong <spdonghao@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#973901}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3489188
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Owners-Override: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/4896@{chromium#141}
Cr-Branched-From: 1f63ff4-refs/heads/main@{#972766}
MaoHan001 pushed a commit to riscv-android-src/chromium that referenced this pull request Jan 17, 2023
@nickdiego
[M109] wayland: speculative fix for a touch tabdrag crash
30eccb5 
The linked crash report, at least the Chrome_Linux occurrences, points
out to an issue when manipulating touch_pointer_ids variable, which is
returned by WaylandEventSource::GetActiveTouchPointIds(), which is both
DCHECKed and assumed to be non-empty. This tentatively fixes the issue
by checking whether it really contains ids, before trying to access it's
first item.

R=​tonikitoo@igalia.com

(cherry picked from commit 99e490d)

Bug: 1381650
Change-Id: I36ce0b3b10c789958d4eb1c444a5ec41e1061135
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4024642
Auto-Submit: Nick Yamane <nickdiego@igalia.com>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Original-Commit-Position: refs/heads/main@{#1072549}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4038410
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5414@{chromium#141}
Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}
blueboxd referenced this pull request in blueboxd/chromium-legacy Feb 8, 2023
@mstensho
Fragments may become monolithic even if the node isn't.
e67781e 
So ask the fragment instead of the LayoutBox. This is an old problem,
and it prevented pre-paint from understanding that a monolithic
fragment would be the containing block for OOF descendants (normally in
block fragmentation, OOFs are direct children of a fragmentainer, but
not if they are contained by a monolithic fragment, like in this case).
However, with CL:4110949 the problem became more severe, since we may
now force off fragmentation at the last OOF fragment (if it's inside a
clipped container), making it monolithic.

out-of-flow-in-multicolumn-112.html is a test for the regression, while
out-of-flow-in-multicolumn-113.html is a test that would fail even
without the aforementioned CL.

(cherry picked from commit 7073850)

Bug: 1404718
Change-Id: I68ebd5218c2bd0e3e895eaf757a90cbc8594a028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4131528
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1088506}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4136433
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/branch-heads/5481@{#141}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
chirayudesai pushed a commit to chirayudesai/chromium that referenced this pull request Mar 7, 2023
[iOS][PT] Moves feature helpers in browser/tabs
1fbbbba 
This CL moves Pinned Tabs helpers in browser/tabs.
This allows to use those helpers outside the browser/ui folder.

(cherry picked from commit 903a05e)

Bug: 1382015, 1408325
Change-Id: Icbe083a08281530e8c7c59b5f94ec17432caba90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4208860
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1099935}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4218334
Cr-Commit-Position: refs/branch-heads/5563@{chromium#141}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
calyxos-gerrit pushed a commit to CalyxOS/chromium that referenced this pull request Mar 31, 2023
[Merge M112] Don't discard pages that have user edits
9bc2117 
Some pages use non-textfield `contenteditable` elements to collect user
input. These pages might be discarded in Memory Saver mode or because of
critical memory pressure, which could result in some lost work. This CL
protects a page with user edits from being discarded.

(cherry picked from commit b06a3c6)

Bug: 1156388
Change-Id: I6aa9202153a90a0edfc35ac337bd87c85aee61f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4291959
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Anthony Vallée-Dubois <anthonyvd@chromium.org>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1110964}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4300353
Cr-Commit-Position: refs/branch-heads/5615@{chromium#141}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
unicornx pushed a commit to unicornx/chromium that referenced this pull request Apr 19, 2023
Incrementing VERSION to 105.0.5195.15
426a833 
Change-Id: I543d85b761d8cb743f95c262dac926ddb0de3241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3796689
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5195@{chromium#141}
Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
l0hn pushed a commit to l0hn/chromium_test that referenced this pull request Jun 9, 2023
[sync] Fix metric about trusted vault error state upon first sync
799c1c3 
Before this patch: in many cases but not always, by the time the
metric-recording code is exercised, IsSyncFeatureEnabled() returned
false, which prevented the recording of the metric.

With this patch, the metric-recording code is exercised also when
IsSyncFeatureEnabled() transitions from false to true. This has a
negligible effect on metrics Sync.TrustedVaultErrorShownOnStartup*,
but significantly impacts metric
Sync.TrustedVaultErrorShownOnFirstTimeSync, which is now renamed.

(cherry picked from commit 872b0cb)

Change-Id: Ia772a607861b9ed456f8138d0a6d7e6505eac7dc
Bug: 1425476
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4483058
Reviewed-by: Rushan Suleymanov <rushans@google.com>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1137026}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4498666
Cr-Commit-Position: refs/branch-heads/5735@{chromium#141}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
msizanoen1 pushed a commit to qtmlabs/chromium that referenced this pull request Jun 29, 2023
@cfredric
[M116 merge] Allow network service to not wait for FPS initialization
fae0655 
Rollout metrics are indicating a heavy latency cost associated
with First-Party Sets at startup, and it's suspected that this is
because the network service waits until the feature is initialized
before sending requests. This waiting is unnecessary in the vast
majority of cases. We'd like to be able to configure this behavior
to validate that this is the cause of the metrics regression.

(cherry picked from commit 56234ce)

Bug: 1458054
Change-Id: I4c1a23ed7c387da68f18a5d28d5f04a5f9044e5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4642965
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
Reviewed-by: Shuran Huang <shuuran@chromium.org>
Reviewed-by: Johann Hofmann <johannhof@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1162620}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4646234
Reviewed-by: Chris Fredrickson <cfredric@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Owners-Override: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/5845@{chromium#141}
Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
debugeek pushed a commit to debugeek/chromium that referenced this pull request Jul 6, 2023
[M102 Merge][side search] Eliminate grey flash when opening Side Search
cd7dfc2 
This CL eliminates the grey flash that can be seen when side search
is first opened.

This is done by setting the default background color of the
WebContents to be transparent and setting the hosting WebView's
background color to the toolbar background color.

Before:
https://screencast.googleplex.com/cast/NTQxMzQ3MzE1NzY0NDI4OHw1ZTRhOTEwMS1kOQ

After:
https://screencast.googleplex.com/cast/NjQ4MjY1MDQ3OTk4NDY0MHwwNDZhMmY5MS0wYg

(cherry picked from commit bdd6df8)

Bug: 1315412
Change-Id: I86a8879ddae422a3c1355924af012bd41d2adf3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3598181
Reviewed-by: Yuheng Huang <yuhengh@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#994790}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3606089
Cr-Commit-Position: refs/branch-heads/5005@{chromium#141}
Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}
aetota61 pushed a commit to monkbrowser/monk-browser that referenced this pull request Aug 2, 2023
@carlosjoan91
Add URLS that are opted out from https upgrades due to being typed wi…
5480da9 
…th http scheme to the allowlist

(cherry picked from commit 3b05be1)

Bug: 1447921
Change-Id: Id676f34826534195cc013a81431bc68f5dae131d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4553926
Reviewed-by: Chris Thompson <cthomp@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1149391}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573299
Auto-Submit: Carlos IL <carlosil@chromium.org>
Commit-Queue: Chris Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/branch-heads/5790@{chromium#141}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
trflynn89 pushed a commit to RebelBrowser/rebel that referenced this pull request Oct 26, 2023
@d0iasm
[M118] [ios] Fix a thumbnail for PDF page
ac1f2b3 
This CL fixes a thumbnail for a PDF page by using -drawInRect: instead
of -drawAtPoint: to draw a base image.

See the demo video here: https://drive.google.com/file/d/1YF1YSYxcufmV-MWOGuWQEQxyVnGznKoM/view?usp=sharing

(cherry picked from commit e49693d)

Bug: 1479854
Change-Id: Ie59e1b104f5968f5b711de3af0f9fde52a7ce3bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4847214
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Asami Doi <asamidoi@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1194002}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4853907
Cr-Commit-Position: refs/branch-heads/5993@{chromium#141}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
Disable flaky test ...MetadataAndPointGoThroughOOPIF on ChromeOS
a53e54c 
Merge: Flaky on M119

(cherry picked from commit 2e84b1f)

Bug: 1490367
Change-Id: I0e46366e6a559b7af1cd6aeafed6d8204f2939dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4918370
Auto-Submit: Jason Lin <lxj@google.com>
Commit-Queue: Jason Lin <lxj@google.com>
Owners-Override: Jason Lin <lxj@google.com>
Reviewed-by: Louise Brett <loubrett@google.com>
Commit-Queue: Louise Brett <loubrett@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1206177}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4920052
Auto-Submit: Robert Liao <robliao@chromium.org>
Commit-Queue: Bo Liu <boliu@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Owners-Override: Robert Liao <robliao@google.com>
Cr-Commit-Position: refs/branch-heads/6045@{chromium#141}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori referenced this pull request in Pissandshittium/pissandshittium Dec 8, 2023
[Passwords] Send positive IN_FORM_OVERRULE votes (2)
ff37a81 
New vote type makes a new signal that the username is either outside or
inside the password form.

Positive IN_FORM_OVERRULE vote means that user was proposed with
username found inside the password form and manually filled username
that was found outside of the password form.

Currently, if single username is not used, UFF votes are not sent.
However, we need to have a signal when the user picks something outside
of the form as a username. Start sending UFF votes on a password form
with username if positive `IN_FORM_OVERRULE` vote type can be sent.

(cherry picked from commit c36ffa0)

Bug: 1498193
Change-Id: Ie1105a4bdbfa5b26fc1f1e2420b624cd57e6dd0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4987324
Reviewed-by: Maria Kazinova <kazinova@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Din Nezametdinov <shaikhitdin@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1218004}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5001513
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{#141}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable pushed a commit that referenced this pull request Jan 6, 2024
Don't animate dismissal on failed auth for Add password and Settings
4218631 
(cherry picked from commit 68b53ee)

Bug: 1462419
Change-Id: Ib27634833869f835b39edeca662d7eb92819e995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5066957
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Auto-Submit: Ernesto Izquierdo Clua <eic@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1234108}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5100473
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/6167@{#141}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable pushed a commit that referenced this pull request Jan 26, 2024
Automatic update from google3
2c1aade 
Automatic update for 2024-01-26 UTC

Change-Id: I4ef678ef2456c2c1d5ac92ce628c80a83d9c8306
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237261
Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Cr-Commit-Position: refs/branch-heads/6261@{#141}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
aarongable pushed a commit that referenced this pull request Feb 26, 2024
[M-123] Disallow going back to LocalDataWarningScreen from SignFatalS…
283bb24 
…creen

(cherry picked from commit e3db305)

Bug: b/320173738
Change-Id: I57ab3f056201a1403a3a2dad799b3e4c61edf2b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5309921
Reviewed-by: Leon Masopust <lmasopust@google.com>
Commit-Queue: Elie Maamari <emaamari@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1262784}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5317995
Cr-Commit-Position: refs/branch-heads/6312@{#141}
Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
NaaeemMalik pushed a commit to SoftwarePrince/Egon-Chromium that referenced this pull request Mar 22, 2024
@ckitagawa-work
[M117] Revert "[Start] Hide overview without the check on VIEW intent."
c70de13 
This reverts commit 8a3e593.

Reason for revert: causes https://crbug.com/1468193 and
https://crbug.com/1470146. The original bug seems less problematic as
it only affects Start Surface Return Time Immediate.

Original change's description:
> [Start] Hide overview without the check on VIEW intent.
>
> In this CL, we remove the check of whether to show Start surface in
> processUrlViewIntent(), since Start surface shouldn't be shown if
> Chrome is launched from VIEW intent. Also clean up a walk around fix
> for  processUrlViewIntent() returning a wrong result after checking
> whether to show Start surface on newIntent before the intent is
> updated. Demo:
> https://drive.google.com/file/d/1DRKLOuaVuQjb9k70-clLGyht8ykySKic/view?usp=drive_link
>
> Bug: 1462302, 1298740
> Change-Id: I109b9f3b8a4296a18ce2f33d82e23c58b7bdb057
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4671434
> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Commit-Queue: Xi Han <hanxi@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1168226}

(cherry picked from commit a730ece)

Bug: 1462302, 1298740, 1468193, 1470146
Change-Id: If3110e229245988428bdbb01d53a7b9b56c75fd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4767259
Commit-Queue: Fred Mello <fredmello@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1182025}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4777839
Commit-Queue: Theresa Sullivan <twellington@chromium.org>
Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Cr-Commit-Position: refs/branch-heads/5938@{chromium#141}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable pushed a commit that referenced this pull request Mar 23, 2024
Incrementing VERSION to 124.0.6367.13
083d663 
Change-Id: Iee8f873b748565667bc31163cfee1f9a894850c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5388340
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6367@{#141}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable pushed a commit that referenced this pull request Apr 19, 2024
Extend Wallpaper Search flag expirations
9c84130 
(cherry picked from commit 1cc43cf)

Bug: 330274886, 330216542, 330301888, 330368068, 330366327, 330367649
Change-Id: Ic1470922927ffb6928268d2c0a2fefe4775337d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5462885
Commit-Queue: Riley Tatum <rtatum@google.com>
Reviewed-by: Paul Adedeji <pauladedeji@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1289374}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5468323
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6422@{#141}
Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable pushed a commit that referenced this pull request May 17, 2024
Automated Commit: LKGM 15886.5.0 for chromeos.
7d12957 
Uploaded by https://ci.chromium.org/b/8747734794321351937

Change-Id: I49af9cf8e87042126f79548e333fb1138689dd76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545769
Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#141}
Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
consp1racy pushed a commit to signageos/chromium-chromium that referenced this pull request May 18, 2024
[M106][Discount] Set up merchant wide promotion
d3ef860 
This CL does the following:
  * Adds a feature flag for rolling merchant wide promotion
  * Adds a param to temporary disable the fetching
  * Hooks up with the no discount merchant list from component updater

(cherry picked from commit d474488)

Bug: 1351534
Change-Id: I5bfba1975f04f4ecb3108026627c1c966b9f861d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3832605
Reviewed-by: Wei-Yin Chen <wychen@chromium.org>
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1036910}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3858055
Auto-Submit: Mei Liang <meiliang@chromium.org>
Commit-Queue: Wei-Yin Chen <wychen@chromium.org>
Cr-Commit-Position: refs/branch-heads/5249@{chromium#141}
Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@TrueJu