Master #143

sathishjai · 2022-11-18T05:12:23Z

No description provided.

A previous CL [1] fixed an issue with DefaultConstructTraits for MojoLPM generated files, however it only fixed the HandleCall function. This CL extends this fix to the HandleResponse function so that compilation errors when using DefaultConstructTraits can be avoided when such types are used in a callback. [1] - https://chromium-review.googlesource.com/c/chromium/src/+/3980213 BUG=1385587, 1269986 Change-Id: I0259329298544bab1339a0c4c00f8832d94bd39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4034274 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072965}

This change is a pure refactor. R=katie AX-Relnotes: n/a. Bug: 1383992 Test: cq Change-Id: I84c7c53eeb5386874d082f4343279c0aa43a4194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4033386 Reviewed-by: Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/main@{#1072966}

This CL adds an integration tests for AutofillAcrossIframes: A test for filling a cross-frame form. This only tests the plain scenario of filling a same-origin form because there's no machinery to access cross-origin iframes in Java. This simple case is sufficient because the complexity of cross-origin forms is encapsulated at the lower ContentAutofill{Driver,Router} level anyway. A test for mapping the Autofill predictions to a cross-frame form. A test for detecting submission of a cross-frame form. Bug: 1187842, 1385580 Change-Id: I87388f929a1b6d945247ff25e2881474f1138dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4030510 Reviewed-by: Michael Bai <michaelbai@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072967}

Throughout the ChromeVox codebase, earcons parallels TTS and braille naming conventions. Following this pattern, the abstract descriptor of how earcons can be interacted with should be named EarconInterface. This change is a pure refactor. R=katie AX-Relnotes: n/a. Bug: none Test: cq Change-Id: I7af12600a5166a5e1bf09bf3798c3e8b7ffa197e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4032688 Reviewed-by: Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/main@{#1072968}

With normal length app name: Light: https://screenshot.googleplex.com/3F4hNWQGrpk5Abi.png Dark: https://screenshot.googleplex.com/7wwj5gAfbRMFavG.png With truncated app name: Light: https://screenshot.googleplex.com/BxNV6KT4eEL2dbP.png Dark: https://screenshot.googleplex.com/3L5S7GNxhkAgHq6.png TEST=manually tested in recent apps list in Phone Hub bubble Fixed: b/259318159 Change-Id: Iec258c43c5944d9bffa9076c043182721b95f4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4024655 Reviewed-by: Jon Mann <jonmann@chromium.org> Commit-Queue: Pu Shi <pushi@google.com> Reviewed-by: Abbas Nayebi <nayebi@google.com> Cr-Commit-Position: refs/heads/main@{#1072969}

Refactor tab_strip_scroll_session to work with RTL Change-Id: Ib88d2b2cc42d15109271d6065bf281a2170c188d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4031668 Commit-Queue: David Pennington <dpenning@chromium.org> Reviewed-by: David Pennington <dpenning@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072970}

The alignas specifier seems to be ignored on the anonymous struct. Change-Id: I0275e745685bffae1a6207026a9a7968ea9294d3 Fixed: 1385739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4031213 Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072971}

DropBookmarks() has a code path that looks up the index of a node. The node supplied to GetIndexOf() is the original node. This is the wrong node to use if a copy is created (because copying creates a new node). This fixes the copy path to increment the index. Bug: b:257217681 Change-Id: If982e624be373a301898dad21cdfbb8a40c3debb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4033027 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072972}

The back button will be enabled if the current page is a Lens camera experience that is enabled (this checks feature flags, etc.) and the user is at the bottom of the navigation stack. In that case, we open the Lens camera and close the current tab (regardless of what the user does after opening the camera). Bug: 1353430 Change-Id: I82375a1f7b915eef9aebe720874d4005b98017a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3965534 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jason Hu <hujasonx@google.com> Cr-Commit-Position: refs/heads/main@{#1072973}

Bug: b/259496596 Change-Id: Ieef1aebbc751064a07a67ee94034ea62490412c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4032058 Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Anton Swifton <swifton@google.com> Cr-Commit-Position: refs/heads/main@{#1072974}

Bug: None Change-Id: Id8ba93c7a7fa3ac0230d02dd3af958373dcb4b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4034786 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072975}

https://android.googlesource.com/platform/external/perfetto.git/+log/209aac9ddf6a..a379922c8115 2022-11-17 ddiproietto@google.com Merge "docs: Mention unwinding issue with ART mainline module" 2022-11-17 ddiproietto@google.com Merge "docs: Build with ninja" 2022-11-17 ddrone@google.com Merge "Revert "Enable Pivot Table by default"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I19a8537f2a307a3d4a3949d5d7b4336687415046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4032500 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1072976}

Roll Chrome Win64 PGO profile from chrome-win64-main-1668686205-267f0d844bd5ca130f55ff4225213ff7a6ad0450.profdata to chrome-win64-main-1668697173-bdfdcc317f828c6824d70ac5e1d03e5b467c6d7b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idc624eea421a088fa1c8c436a82478736a2d2b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4034312 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1072977}

https://dawn.googlesource.com/dawn.git/+log/7df98007abd6..4d65fc91bb28 2022-11-17 jrprice@google.com tint: Implement pointer alias analysis 2022-11-17 dsinclair@chromium.org Enable some disabled test. 2022-11-17 amaiorano@google.com tint: remove redundant insertBits tests 2022-11-17 amaiorano@google.com Roll third_party/webgpu-cts/ d7e8d005d..622cac9c6 (2 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC bajones@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:53440 Tbr: bajones@google.com Change-Id: I06c25991aec799b54c8686585cb3e7255b2fd993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4032502 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1072978}

This is a reland of commit cdf178d Fix for the revert reason is on the second patchset. Original change's description: > [ProfileID] Add profile id to chrome://policy > > This change makes the enterprise profile identifier visible on > the chrome://policy page. This identifier is specific to the each > profile and its creation is documented in this design document: > go/chrome-profile-identifier-dd > > Screenshot: https://screenshot.googleplex.com/C6hFMRyTWoBy3CP > > Bug: 1384158 > Change-Id: I41c8de60df40de886f06d583ee4b6386a55bb561 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3973637 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > Commit-Queue: Hamda Mare <hmare@google.com> > Reviewed-by: Yann Dago <ydago@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1071283} Bug: 1384158 Change-Id: I0380924e85f230491c0df40e32244c0026a488f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4030967 Commit-Queue: Hamda Mare <hmare@google.com> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Reviewed-by: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072979}

…me (6/n) This CL replaces the GetPrimaryMainFrame() comparison check in favor of a more concise method IsInPrimaryMainFrame() in webui_load_timer.cc. Bug: 1268893 Change-Id: I5127aa919648cd48b63184c88332f76ca317f906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4027863 Reviewed-by: John Lee <johntlee@chromium.org> Commit-Queue: Antia Puentes <apuentes@igalia.com> Cr-Commit-Position: refs/heads/main@{#1072980}

All 16 cores are with SSD. https://ci.chromium.org/ui/p/chromium/builders/try/linux-lacros-asan-lsan-rel/136/overview Change-Id: I69dc085b92f3dc984e2fa511bfa9be6a55b7ac45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4034609 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by: Jieting Yang <yjt@google.com> Cr-Commit-Position: refs/heads/main@{#1072981}

Adds needed includes for keyboard tester tests which was causing the keyboard tester to fail to initialize. Reenables KeyboardTester browser tests as this CL fixes them. Bug: b/243706697 Test: DiagnosticsAppWithInput_KeyboardTester.All Change-Id: Iffa9785a700d27ce534093bf78f8c9868d31bb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4027542 Reviewed-by: Michael Checo <michaelcheco@google.com> Commit-Queue: David Padlipsky <dpad@google.com> Cr-Commit-Position: refs/heads/main@{#1072982}

Previously, we called ReserveSpaceInPrefixMap twice, once for the old map size and once for the additions map. The refactored logic incorrectly used the current map size instead of capacity when doing the second call, causing not enough space to be reserved. This change fixes that by collecting the total size needed up front, then doing a single reserve call. Bug: 1385712 Change-Id: If0d8e23ef7242b030b719240474a6f804ed6819f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4033772 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072983}

Bug: chromium:1352405 Change-Id: I315104eb4ee985a2d04ea90f01341129c6307501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4027202 Reviewed-by: ccameron chromium <ccameron@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072984}

https://boringssl.googlesource.com/boringssl/+log/1ee71185a2322dc354bee5e5a0abfb1810a27dc6..f0518d45119dd4dd322a884669daf8247bc3c992 The following commits have update notes: a1dffbfed Define CBS/CBB tags as uint32_t with a typedef. 38f621a36 Add the suite of EC_KEY and EC_POINT serializers. 19d6ec9c4 Check for TLS 1.3 in SSL_generate_key_block. Bug: none Change-Id: I87a65dcb2eb29e4260502017da5fd9800aff8599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4027426 Reviewed-by: Matt Mueller <mattm@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072985}

This removes the assertion that the hint text must always be valid regardless of the state of the system, but acknowledges the hint can be out of sync and thus will be dropped in that case. BUG=1383684 Change-Id: Ib67e41d88b56e1796f1f82a01d433a611f56c4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4032536 Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072986}

We are no long using first meaningful paint metrics from UKM and UMA, so this CL removes the code of recording FMP metrics into UKM and UMA. Bug: 1064483, 1183191 Change-Id: I985585bc4fb39272836ea030aff70af196165f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4006976 Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072987}

The TODOs about GLSurfaceFormat have been there since 2017 and no use case has shown up since then that would need more fine-grained control than the current implementation. Add comments to explain that this could be changed in the future if needed. Change-Id: Id2b3630f9f5053a4457cbf4aa5da6ff58ce0f7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4014721 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072988}

Bug: 1385416 Change-Id: I9fdd43467f8373b1b5cbde1c0d15adc2c1be25f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4034466 Commit-Queue: Tom Burgin <bur@chromium.org> Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072989}

Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b4d7eaaf..54cbf2ab Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_chromeos_msan_rel_ng CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I36aeac0c4e0655243ab1e8ac865cf1286cdc1247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4034467 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1072990}

This ensures we are not mocking non-existent functions. Change-Id: Ic175bbe9c28aad9d2f5984333a4d7eee36a57f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4024672 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072991}

Added additional constructor that does not take in tray_bubble_view. Moved tray_bubble_view and widget initialization to a separate ShowBubble() function that takes a unique_ptr. Will remove the old constructor once other bubbles are updated. Bug: b/257129394 Change-Id: If1ed6a4ac2ea3c3f1b1cc7519fdf774e22e2d65f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4032792 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/main@{#1072992}

Add metric that emits the result of attempting to create a custom APN. Further metrics relating to specific properties of the created APN will be added in a follow-up CL. Bug: b:162365553 Test: CrosNetworkConfigTest* Change-Id: Iaf8ad11eec6a7019815579f1ffb5d439abae903b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4022577 Reviewed-by: Chad Duffin <chadduffin@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/main@{#1072993}

https://chromium.googlesource.com/angle/angle.git/+log/a6fae3fec809..7e7a47dffca0 2022-11-17 syoussefi@chromium.org Vulkan: Adjust logicOp dynamic state workaround If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1379201 Tbr: jonahr@google.com Change-Id: I3ddc643a1141a159c7aed418effeb9c295b5eff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4032701 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1072994}

https://chromium.googlesource.com/external/github.com/google/nearby-connections.git/+log/e58dd0a5977f..141f02114053 2022-11-18 jsobczak@google.com Add Borrowable class. > Define Lender/Borrowable/Borrowed classes for sharing resources safely between threads. > > PiperOrigin-RevId: 489361079 > If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/nearby-connections-chromium Please CC chromeos-cross-device-eng+autoroll@google.com,jonfan@google.com,nearby-chromeos-eng+autoroll@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-nearby-chrome-fyi Bug: None Tbr: chromeos-cross-device-eng+autoroll@google.com,jonfan@google.com,nearby-chromeos-eng+autoroll@google.com Change-Id: I1bcbe0c227f239865b1601f0b5a20b0a74b0ec06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4035852 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1073209}

The current stack can only support one transition tied to a compositor. This is an issue if multiple local frames tied to the same compositor trigger a transition concurrently. Safely handle this by skipping an existing transition if another one is initiated within the same local frame tree. A transition initiated by a parent will take priority over child frames. The test for this is chromium specific, instead of a WPT, since this is unspec'd behaviour. Its a limitation of the current stack that will be eventually improved. Bug: 1376158 Change-Id: If173e39e87efc7b63e26821e6608ce16ffa771e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4022033 Commit-Queue: Khushal Sagar <khushalsagar@chromium.org> Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Auto-Submit: Khushal Sagar <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1073210}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aad574d4464f..1f67d5573f9c 2022-11-18 jwata@google.com Add ninja wrappers to trigger DEPS ninja If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,aravindvasudev@google.com,gavinmak@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ajp@google.com,aravindvasudev@google.com,gavinmak@google.com,sokcevic@google.com Test: Test: Change-Id: Ib0e0da34773c39234a8351a7d9c23f65bbbf0148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4036250 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1073211}

Bug: b:251046341 Change-Id: I54b18308b48f086ecf12d4e83feba68eb420250e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4037301 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Austin Tankiang <austinct@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/main@{#1073212}

… may return null."" This reverts commit fc75f28. Reason for revert: This CL is likely the cause of failure for PageSpecificSiteDataDialogInteractiveUiTest in many bots, some examples are: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28Wayland%29/24266, https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/58474, https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/35287 Original change's description: > Reland "Clarify when ElementTrackerViews::GetElementForView() may return null." > > This reverts commit 2c6efa2. > > Reason for revert: Fixed test failures. > > Original change's description: > > Revert "Clarify when ElementTrackerViews::GetElementForView() may return null." > > > > This reverts commit caa6d23. > > > > Reason for revert: suspected to cause interactive_ui_tests failures > > (crbug.com/1383327). > > > > Original change's description: > > > Clarify when ElementTrackerViews::GetElementForView() may return null. > > > > > > The caller of this method should generally check the return value to > > > avoid crashes. This CL modifies several call sites, either checking the > > > return value or simplifying the code by replacing several steps with an > > > existing utility function that does the check. > > > > > > Change-Id: I63150b1a7574f36f83c902ecf36ad7b5140d2a63 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4001206 > > > Commit-Queue: Dana Fried <dfried@chromium.org> > > > Reviewed-by: David Pennington <dpenning@chromium.org> > > > Cr-Commit-Position: refs/heads/main@{#1069903} > > > > Change-Id: Ic95d96c4f1c6ab47443d2fe0d86ef161062c2763 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4022666 > > Reviewed-by: David Pennington <dpenning@chromium.org> > > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> > > Owners-Override: Kunihiko Sakamoto <ksakamoto@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1070081} > > Change-Id: I53abd7f54d06f22a76f77dd7e3aee71ef7e295fe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4022576 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: David Pennington <dpenning@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1073149} Change-Id: I21ca424e2c2331fee903f01c8633b294e5079fcf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4037227 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Maggie Cai <mxcai@chromium.org> Owners-Override: Patti Lor <patricialor@chromium.org> Cr-Commit-Position: refs/heads/main@{#1073213}

Test: None Bug: None Change-Id: I352535e1eceb559836fa373f75aae90b6e9cba8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4037126 Commit-Queue: Marcello Salomao <msalomao@google.com> Reviewed-by: Ben Reich <benreich@chromium.org> Cr-Commit-Position: refs/heads/main@{#1073214}

This CL checks that a view controller is at the top of the stack before popping it. (cherry picked from commit c6e9d92) Bug: 1374889 Change-Id: Ie83a34e0e4cd87368622ca954a2712088958b321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3956163 Reviewed-by: Robbie Gibson <rkgibson@google.com> Commit-Queue: Cheick Cisse <cheickcisse@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1060667} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3966882 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5359@{#143} Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}

Merge to M107. - DesktopSiteContentSetting.SettingsPage.Entered User entered the SingleCategoryPreferences page for Desktop site. It is emitted whenever this page is shown regardless how it is triggered. - DesktopSiteContentSetting.SettingsPage.SiteException.Opened User opened the site exception edit dialog by clicking on a site in the SingleCategoryPreferences page for Desktop site. (cherry picked from commit 6c83fb2) Bug: 1365771 Change-Id: I347ebf7d366bf4c4d06a2965422a6c434227adff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910373 Commit-Queue: Shu Yang <shuyng@google.com> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1050220} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3913962 Auto-Submit: Shu Yang <shuyng@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Cr-Commit-Position: refs/branch-heads/5304@{chromium#143} Cr-Branched-From: 5d7b1fc-refs/heads/main@{#1047731}

Previously, we had a 30 day limit for the keyword cache generation, because we mistakenly believed that visits older than 30 days would not have keywords. Actually, they still can, in some circumstances, so now we are lifting that restriction. This CL also removes some outdated comments and updates the log messages a little bit to be more informative. (cherry picked from commit 6c5a441) Bug: 1300231 Change-Id: Ib7aa9f90ecf83cfed3d694566c4d6db14214aa88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3484037 Reviewed-by: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#974338} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3489137 Cr-Commit-Position: refs/branch-heads/4896@{chromium#143} Cr-Branched-From: 1f63ff4-refs/heads/main@{#972766}

… desktop This CL removes any way of rendering the update expiration date version of the CVC input dialog for virtual cards. This is due to the fact that it never makes sense to update a virtual card's expiration date, since they do not technically ever expire. Before: https://screenshot.googleplex.com/8n65m2FmKmvLwSw After: https://screenshot.googleplex.com/66y2QGKbCUHqbwR (cherry picked from commit 28afe2a) Bug: 1385511 Change-Id: Ic82630ba6fe80ab81ae297e59bc847034a4a8e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4025316 Reviewed-by: Siyu An <siyua@chromium.org> Commit-Queue: Vinny Persky <vinnypersky@google.com> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1072596} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4036490 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5414@{chromium#143} Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}

When the discover feed is disabled, a "fake" empty UICollectionView is inserted in place of the real discover feed. This fake view does not behave exactly the same and is not width-contrained in the same way. In order to have the feed header width be the same whether the feed is turned on or off, the feed header needs to be constrained by a max width. (cherry picked from commit 90daaf7) Fixed: 1403300 Change-Id: I74fd38fc67d9643e011410fac4537e0bc2e1be61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4129161 Commit-Queue: Scott Yoder <scottyoder@google.com> Reviewed-by: Adam Arcaro <adamta@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1088279} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4134401 Commit-Queue: Adam Arcaro <adamta@google.com> Cr-Commit-Position: refs/branch-heads/5481@{#143} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}

…11.0.5563.11-r1 to 111-5550.0-1675078804-benchmark-111.0.5563.12-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0fadb8f461e46a0dbf4ddeac980e8d2f8773e8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4220246 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{chromium#143} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}

Make the creation of the TabGridDialogCoordinator lazy to minimize startup overhead and memory usage for users that are not using tab groups. (cherry picked from commit 5dc1e1b) Bug: 1418690 Change-Id: Idf7c1d5c0a8d4e7d26854b7d585b2d8d5e14800e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4284379 Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by: Mei Liang <meiliang@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1110497} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4303541 Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5615@{chromium#143} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}

…ate is null This CL fixes the crash caused by `window_state` being null. This is a fix for short term. The fundamental fix is ongoing: crbug.com/1338597. Bug: 1348312 Change-Id: I18efd975fbbb339381ae6cd49ac18cbacd2aabbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3800565 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Srinivas Sista <srinivassista@chromium.org> Owners-Override: Srinivas Sista <srinivassista@chromium.org> Cr-Commit-Position: refs/branch-heads/5195@{chromium#143} Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}

…0-benchmark-114.0.5735.11-r1 to 114-5715.0-1682942126-benchmark-114.0.5735.13-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-exp-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I21f7e0acbd159fd0c2502a103a806361ee56a046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4498277 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5735@{chromium#143} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}

This CL cherry-picks the linked CL to M116: https://chromium-review.googlesource.com/c/chromium/src/+/4633062 TPgM approval is linked in the bug. Bug: 1457955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4633062 Reviewed-by: Benjamin Williams <bwwilliams@google.com> Commit-Queue: Hira Mahmood <hiramahmood@google.com> Cr-Commit-Position: refs/heads/main@{#1160759} (cherry picked from commit 72a56f6) Change-Id: I7e2b54fde4586e23ab976dbd251fe45f7f24b375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4651369 Reviewed-by: Benjamin Williams <bwwilliams@google.com> Auto-Submit: Hira Mahmood <hiramahmood@google.com> Commit-Queue: Benjamin Williams <bwwilliams@google.com> Cr-Commit-Position: refs/branch-heads/5845@{chromium#143} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}

This is first of two changes modifying how we control the inventory of the Omnibox Suggestions, permitting retention of all of the Suggestions with headers without modifications. When the feature flag is enabled, suggestions with headers will not be trimmed or removed from the list, but instead will be considered as a separate addition to everything that comes with no headers. The second step will introduce fine control over the volume of suggestions and their placement in the suggestions list. (cherry picked from commit 49a2028) PRD: http://doc/1495s9QIYo9gz1KRT1luDROuqUi4MHkqLEi8C_NcHMGo Proposals: http://doc/1MXPXcEihnbfDzUipWj0IPsMLpbX7hKOvyusL4uw14Fs Bug: 1318144 Change-Id: Iae8968100006330e9e5c18f73bec4043e825077b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3597199 Reviewed-by: Mohamad Ahmadi <mahmadi@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Original-Commit-Position: refs/heads/main@{#995019} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3599845 Auto-Submit: Tomasz Wiszkowski <ender@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5005@{chromium#143} Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}

This addresses the problem where a vertical resize does not trigger style and layout. With this change we catch the layout inconsistency during the snapshot update and recalculate a new start time. (cherry picked from commit ecd07ef) Bug: 1447321 Change-Id: I8985f66233ff96f1b359c9a0f6aeee3525082111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4566235 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1149163} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573505 Reviewed-by: Eugene Girard <girard@chromium.org> Cr-Commit-Position: refs/branch-heads/5790@{chromium#143} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}

…be9496507459 Commits rolled: https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/cda7640e3e82..be9496507459 Roll src/third_party/devtools-frontend/src from 878ce92888ae to 666c79779cdc Commits rolled: https://chromium.googlesource.com/devtools/devtools-frontend/+log/878ce92888ae..666c79779cdc Generated by: go/bbid/8770236205333407185 Change-Id: Ie240dd38eacb64d03fd7d70d6aae4826a20bbac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4855543 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5993@{chromium#143} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}

Roll Chrome Linux PGO profile from chrome-linux-6045-1696614294-35911a58d41b10b66835402445e02372ee2ff851.profdata to chrome-linux-6045-1696636250-e5ae0b19e02cd63d7cb0474628f6e9a91c43f1ce.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m119.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7802a722d677cb6913abb2e8be10a834719d1cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4920197 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#143} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}

Fix : Giving error in AIX system, When is_component_build flag is set in args.gn file To fix this issue we have excluded AIX in absl.gni Bug: AIX: Fix build with is_component_build flag set #143 Change-Id: I08b2575087711f7ccca7634c0c3cdbad75da64b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5012194 Reviewed-by: Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/main@{#1226738}

…rk-120.0.6099.8-r1 to 120-6085.0-1698658595-benchmark-120.0.6099.9-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ibe6fb4d354aec4e7133a9c3f86a47e54f55bba48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5005290 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{#143} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}

Roll Chrome Mac PGO profile from chrome-mac-6167-1702035211-0ee5f0d26a0e481da1c43e9ab1ab15c447c13e6c.profdata to chrome-mac-6167-1702057598-48a0f0ca7d9fab35cc7d60affaaa8484cfc1e074.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7fbd17c3a21df83f164d11ad932d627923457058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5105074 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#143} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}

The crash was caused by posting a delayed task even when there isn't any module to load. (cherry picked from commit 8c1394c) Bug: 1521488 Change-Id: Ia2f246346aa1d1b6c00d83ef1b737dee5e97c4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5234519 Reviewed-by: Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1251781} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5238232 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#143} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}

Change-Id: I32d2204d960402492ee6ea73ea7b6a10c14a69bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5324140 Auto-Submit: Ben Mason <benmason@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6312@{#143} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}

(cherry picked from commit fdd9a23) Bug: 1472024 Change-Id: Ib4c452b9a9232fdb5f602c35f630b782a8aa922d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4769607 Reviewed-by: Bryan Nguyen <nguyenbryan@google.com> Commit-Queue: Jason Hu <hujasonx@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1182241} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4780888 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Prudhvikumar Bommana <pbommana@google.com> Commit-Queue: Prudhvikumar Bommana <pbommana@google.com> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/5938@{chromium#143} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}

This CL updates the ash version ['125.0.6373.0'] for Lacros version skew testing. This cl only affect linux-lacros config builders like linux-lacros-tester-rel, linux-lacros-rel. This cl will certainly NOT affect Lacros on-device builders (lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab, etc) or any other platforms. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC kuanhuang@chromium.org. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: Ia2bbd763a5f918305024cda92967b7a730561a54 Requires-Testing: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5386827 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367@{#143} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}

Roll Chrome Win64 PGO profile from chrome-win64-6422-1713527944-4cc3ee85ddfe5f5c044ea78deca41ccc07b6e8eb-9c7e4ae58cb5973ffc0dfe92e44e76bfb79aa8d8.profdata to chrome-win64-6422-1713549065-d5cf6b2bec6e000eba80275ad9d0506f44f2e598-aee9613bd615ce50eeca32823aae3bad447da9dc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m125.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic8145ee08a870e8e482b4b3227343caad4a6595f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5468476 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#143} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}

(cherry picked from commit ad80bc9) Bug: 341000924 Change-Id: Ibf69747a2fcb2ac7afff960a5dad2f58b113b837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539043 Reviewed-by: Norge Vizcay <vizcay@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Dominic Battre <battre@chromium.org> Commit-Queue: Jan Keitel <jkeitel@google.com> Reviewed-by: Jan Keitel <jkeitel@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1301841} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5546120 Auto-Submit: Dominic Battre <battre@chromium.org> Commit-Queue: Dominic Battre <battre@chromium.org> Cr-Commit-Position: refs/branch-heads/6478@{#143} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}

This CL will update cros image version for skylab tests. CROS_BOARD_LKGM is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV, CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org, yjt@google.com. R=rubber-stamper@appspot.gserviceaccount.com Requires-Testing: True Change-Id: I1dd47a56ffbc7910893dbb9b57c57d6b47057a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3860487 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com <skylab-test-cros-roller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5249@{chromium#143} Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}

Will Harris and others added 30 commits November 17, 2022 19:29

chromium-internal-autoroll and others added 6 commits November 18, 2022 04:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Master #143

Master #143

sathishjai commented Nov 18, 2022

Master #143

Are you sure you want to change the base?

Master #143

Conversation

sathishjai commented Nov 18, 2022