Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #190

Closed
wants to merge 1 commit into from
Closed

Update README.md #190

wants to merge 1 commit into from

Conversation

Vishwajith-Shettigar
Copy link

added period(.)

@Vishwajith-Shettigar
Update README.md
dc7b254 
added period(.)
@google-cla
Copy link

google-cla bot commented Aug 7, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

icew4y pushed a commit to icew4y/chromium that referenced this pull request Aug 11, 2023
[M115][OOBE] Disable OSSyncConsent Revamp feature flag
f4223c6 
Bug: b:283743335
Change-Id: Idcd460f542b3d81bebbe68539137c86a20b0b212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568222
Reviewed-by: Brahim Chikhaoui <bchikhaoui@google.com>
Commit-Queue: Osama Fathy <osamafathy@google.com>
Cr-Commit-Position: refs/branch-heads/5790@{chromium#190}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
l0hn pushed a commit to protectednet/hopium that referenced this pull request Aug 23, 2023
@kenrussell
[M116] Check for context loss during drawing buffer resolution.
7a7eb5e 
On dual-GPU MacBook Pros on top of OpenGL, when the system activates
the discrete GPU, the WebGL context must be lost and restored in
certain situations to avoid corruption of multisampled renderbuffers.

This context loss occurs in unexpected places, in particular during
execution of the ScopedDrawingBufferBinder. Check for it and early-out
in more places. Add a regression test which catches the bug.

(cherry picked from commit df92771)

Bug: 1441633
Change-Id: Ib1ce1c7e11e5180edd63430180c461789bf766fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4639167
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1161934}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4654036
Cr-Commit-Position: refs/branch-heads/5845@{chromium#190}
Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
blueboxd referenced this pull request in blueboxd/chromium-legacy Sep 10, 2023
Updating XTBs based on .GRDs from branch 5938
c4f06a2 
Change-Id: If7870fa92c8bb0c65111b6e62146fe9f7604e03b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4783047
Auto-Submit: Ben Mason <benmason@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5938@{#190}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
trflynn89 pushed a commit to RebelBrowser/rebel that referenced this pull request Oct 26, 2023
[M118][HSTS] Update bulk entries
c8a3575 
See https://github.com/chromium/hstspreload.org/wiki/Preload-List-Processes#updating-bulk-hsts-entries

(cherry picked from commit a4e8809)

Change-Id: I51b12765f382e59d1d3fecad204db4efeb4efcfe
Bug: 1479067
Fuchsia-Binary-Size: Increase from adding domains to HSTS preload list
Binary-Size: Increase due to adding more domains to HSTS preload list
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4844129
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Chris Thompson <cthomp@chromium.org>
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Chris Thompson <cthomp@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1192600}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4852625
Cr-Commit-Position: refs/branch-heads/5993@{chromium#190}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
[M112] CrOS Settings: Fix localized link display in language/input se…
aa7196f 
…ttings

http://crrev/c/4214973 (Merged in 112) broke the display for a couple
of <localized-link> elements in Language and Input settings. This
cherry-pick into 112 addresses the regression.

Website language settings: http://screen/9xXjDVVVFATnLBz.png
Inputs and keyboard settings: http://screen/568LGodSyWctcDv.png

(cherry picked from commit 3e041f6)

Bug: b/269855587, b/271027393
Change-Id: I97486e4f47a1c892f7468856b402e4f4d512baad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296918
Reviewed-by: Michael Cui <mlcui@google.com>
Commit-Queue: Michael Cui <mlcui@google.com>
Auto-Submit: Wes Okuhara <wesokuhara@google.com>
Commit-Queue: Wes Okuhara <wesokuhara@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1110715}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4297420
Cr-Commit-Position: refs/branch-heads/5615@{chromium#190}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
vuzix-jeff pushed a commit to Vuzix/chromium that referenced this pull request Nov 3, 2023
Roll Chrome Win64 PGO Profile
0beb15d 
Roll Chrome Win64 PGO profile from chrome-win64-6045-1696782300-b6dc4116678ea3a8d477049fa41b65e1b3f3799b.profdata to chrome-win64-6045-1696799779-8f1888f1ee310f64573cd685d5df68bca88977eb.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m119.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I2bdc34ed38a78d4525e4fb1a080fbae1091f217f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4921494
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6045@{chromium#190}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori pushed a commit to Pissandshittium/pissandshittium that referenced this pull request Dec 8, 2023
Roll Amd64 AFDO from 120.0.6099.10_rc-r1-merged to 120.0.6099.11_rc-r…
76fa753 
…1-merged

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file go/crostc-bug.

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-beta
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I12f1b2850f03cc3270b4c31e532fa7bcacf130fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006737
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{chromium#190}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable pushed a commit that referenced this pull request Jan 6, 2024
Roll Chrome Mac PGO Profile
91e0e34 
Roll Chrome Mac PGO profile from chrome-mac-6167-1702199807-6dcc631152d41ca77a23eeef7fda14dab1a32d4f.profdata to chrome-mac-6167-1702228404-cf34c0ebdc53c6aea0cb97eb2006bbee255ae157.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m121.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I2651795633cc2e1930f4c7dba2f28ba7b8f2be04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5107199
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6167@{#190}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable pushed a commit that referenced this pull request Jan 28, 2024
Roll Chrome Mac PGO Profile
c01d51c 
Roll Chrome Mac PGO profile from chrome-mac-6261-1706349784-9305d312eac0ae7b08b875b93e2f1a956198d6b5.profdata to chrome-mac-6261-1706389012-144d1fe1818b83da77926648e77028ab7641dca5.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m122.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ib206cd2ee558f4cb67211a0d7b26ff204dfba0b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5241790
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6261@{#190}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
ecotopian pushed a commit to ecosia/chromium-android-browser that referenced this pull request Feb 12, 2024
[M111 merge][ios]Don't monitor NSUserDefaults changes to refresh plat…
e7c6065 
…form policies

Handling the platform policy refresh on NSUserDefaults change
notifications can be costly and is fragile (can lead to long
chain of calls with re-entries). There can be hundreds of
NSUserDefaults updates in a second. Re-evaluating every few seconds
large policy payloads with thousands of policy items  could make the
browser janky.

The monitoring of NSUserDefaults didn't seem problematic until
its conceptual flaw was exposed by the
recently deployed ScopedCriticalActionReuseEnabled experiment.
  - We discussed the option of turning off the experiment for now,
    the time we figure a viable solution, but this is too
    patchy and will just kick the can; we need something a bit more
    viable and durable.

The AsyncPolicyLoader has already a baked in refresh scheduling where
it ensures a platform policy refresh every 15 minutes.

We have already explored most of the possible options:
 1) Use dispatch_async instead of PostTask() to avoid the
    PostTask() re-entry.
     - This doesn't prevent from other re-entry situations
      that may trigger similar issues.
 2) Skip NSUserDefaults changes that aren't on the AppConfig key.
     - Compare value object references.
     - Compare values.
     - Use KVO.
        * Can't be done with NSUserDefaults dictionary.
 3) Stop monitoring NSUserDefaults and rely on the baked in
    refresh interval. That interval can be adjusted if needed if there
    is pushback on the 15 minutes interval.
 4) Trigger updates on UI events such as foregrounding.

Considering that AsyncPolicyLoader can already handle refreshes,
option 3) seems the best and simplest option. Option 3) saves
computation time and is more robust at the expense of freshness.
The refresh interval can be adjusted.

Option 3) can be deployed immediately with a high confidence that
there won't be unexpected side effects.


(cherry picked from commit 191c444)

Bug: 1412137, 1412066
Change-Id: I6d0b4e85f9c5f8aded0d99e3104b768c9d0398fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4213472
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Vincent Boisselle <vincb@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1100660}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4220399
Cr-Commit-Position: refs/branch-heads/5563@{chromium#190}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable pushed a commit that referenced this pull request Feb 27, 2024
Roll Chrome Linux PGO Profile
8f99cdc 
Roll Chrome Linux PGO profile from chrome-linux-6312-1708991890-096d714daf60a5900e742691710c37b040c7eacc-9313089519654579959a9cd96f613e71b9ba972c.profdata to chrome-linux-6312-1709008617-ed6f7ae5b0998ac2efebdfcf603951df5171d3bc-d1c9234df07f86151e2a9bd62e7226293f0dab8f.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m123.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I2eaa060aa82832781d98c57a3fefe0fd15ff5819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5326716
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6312@{#190}
Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
aarongable pushed a commit that referenced this pull request Mar 25, 2024
Roll Chrome Linux PGO Profile
3f35673 
Roll Chrome Linux PGO profile from chrome-linux-6367-1711324243-ecc822f6e4eef70686ce347dc1bc02b406b72ab0-6ac91b0d81050d473ed5734235b2f11ed934d4a2.profdata to chrome-linux-6367-1711339532-88723f8cadf2704f783023e9b67cd6391e3a8d18-86072a8a4ae2686ab42b026a94b7aeeb8ed1b235.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m124.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I63be41bdd0d24bf5862ad7f4c17242a05d24afea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5391039
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6367@{#190}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable pushed a commit that referenced this pull request Apr 21, 2024
Roll Chrome Win32 PGO Profile
d4b3d9c 
Roll Chrome Win32 PGO profile from chrome-win32-6422-1713699177-f6724e0914c2140ce9a4dec98c909d16aacf3413-5ff55575eb9a2d22acb2574b296942977b16900a.profdata to chrome-win32-6422-1713718539-3f0924ee0da0941b7dab7f94eee4d6b6300239d8-efce24656591a49aa90c8f7a853990eae3147824.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m125.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ib2fb6127f09f88384e23a6017ac710a07ee5733b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5470214
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6422@{#190}
Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable pushed a commit that referenced this pull request May 18, 2024
Roll Chrome Mac Arm PGO Profile
9a590ae 
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6478-1715996517-afb753c52b53ab4d38a71c361196d53d063c3e9b-aeae2ad4e14027f542d44662bf9a9429ed92c358.profdata to chrome-mac-arm-6478-1716001857-6f0d269534df064f18c792e213ed2148f75a8e60-a317b4b1c8c093cfcf135cf81447ef6ae5d982d3.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: pgo-profile-sheriffs@google.com
Change-Id: I92633c2ac8f25964e57122bab1d66622257c5f68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5549238
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#190}
Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
consp1racy pushed a commit to signageos/chromium-chromium that referenced this pull request May 18, 2024
[Start] Fix tab switcher tests when Start is enabled.
d187f27 
When Start surface is disabled, the parent view of the GTS is
compositor_view_holder, while becomes tasks_surface_body when Start
surface is enabled. Update TabUiTestHelper#getTabSwitcherParentId() and
add StartSurfaceTestUtils#getTabSwitcherParentId() to allow GTS related
instrument tests can be run in both Start surface enabled/disabled cases.

(cherry picked from commit 7eb2b1a)

Bug: 1356180
Change-Id: Icb9cbbf62595a8e13e6aa47cf414fd0952ecfd73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3854008
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Hao Dong <spdonghao@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1039953}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3863524
Cr-Commit-Position: refs/branch-heads/5249@{chromium#190}
Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Vishwajith-Shettigar