Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: fix typo #211

Closed
wants to merge 1 commit into from
Closed

wip: fix typo #211

wants to merge 1 commit into from

Conversation

vuittont60
Copy link

No description provided.

@google-cla Google CLA
Copy link

google-cla bot commented Jan 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@vuittont60
Copy link
Author

close since of cla

@vuittont60 vuittont60 closed this Jan 18, 2024
@vuittont60 vuittont60 changed the title Update bitmap_pipeline.md: fix typo wip: fix typo Jan 18, 2024
aarongable pushed a commit that referenced this pull request Jan 19, 2024
Roll Chrome Win32 PGO Profile
536a551 
Roll Chrome Win32 PGO profile from chrome-win32-6099-1699205229-4e8b4f3337e1f05cabea96941c9112e3f87f1d1f.profdata to chrome-win32-6099-1699220220-b72dc46c167e2c85dde122b6e635e99937d56b5e.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m120.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ie2e6609e5d8c65f132cbeead75837dbb0c46e5bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5006991
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{#211}
Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable pushed a commit that referenced this pull request Jan 19, 2024
Automatic update from google3
85d5067 
Automatic update for 2023-12-11 UTC

Change-Id: Ifc5e56c203d792d7f3e2b429eef3d730f12d8511
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5110160
Bot-Commit: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Commit-Queue: PKI Metadata Updates Bot <mdb.chrome-pki-metadata-release-jobs@google.com>
Cr-Commit-Position: refs/branch-heads/6167@{#211}
Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable pushed a commit that referenced this pull request Jan 19, 2024
[M118 Merge][Quests V2] Make icon background white in visit tile
6bbd5e8 
Make icon background white and shrink icon so it fits in box.

Screenshot: http://screenshot/AHAzDNcsp4gqcQv

(cherry picked from commit bc6b3e2)

Bug: 1474097
Change-Id: I7df9b9c28724e164ea2d97d628cb1670183d294f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4811525
Reviewed-by: Roman Arora <romanarora@chromium.org>
Commit-Queue: Marlon Facey <mfacey@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1194381}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4858640
Reviewed-by: Marlon Facey <mfacey@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Roman Arora <romanarora@chromium.org>
Cr-Commit-Position: refs/branch-heads/5993@{#211}
Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
aarongable pushed a commit that referenced this pull request Jan 26, 2024
Roll ChromeOS Bigcore AFDO profile from 114-5715.0-1682936626-benchma…
2579e39 
…rk-114.0.5735.13-r1 to 114-5715.0-1682936626-benchmark-114.0.5735.16-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ib072d6be1dcc84aba253cfa8f620af6bc9285734
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4503157
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5735@{#211}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
aarongable pushed a commit that referenced this pull request Jan 29, 2024
[M122]Always replace device placeholders in DoH URI templates
41cc536 
Currently, if the DoH URI template contains placeholders for device
identifiers these placeholders are ignored for unaffiliated users.

This is incorrect because the template delimiters are not URL encoded
and it breaks the DoH server assumptions regarding the size of the
identifier replacement.

This CL changes the current logic by hashing and hex encoding the
value of the placeholder name for users which are not affiliated.

E.g. the replacement for ${DEVICE_ASSET_ID} is
uppercase_hex(sha256(VALUE_NOT_AVAILABLE)).

(cherry picked from commit 417487a)

Bug: b/315422225
Change-Id: If142d012b11379a9c44aa71389463c43609736ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5211015
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Andreea Costinas <acostinas@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1251974}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5236992
Cr-Commit-Position: refs/branch-heads/6261@{#211}
Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
NaaeemMalik pushed a commit to AsilHQ/Asil-Chromium that referenced this pull request Feb 8, 2024
[gbb-cct] Adding workflow of triggering page insights hub
daa050b 
Page Insights Data Loader
Original change by @mako: https://chromium-review.googlesource.com/c/chromium/src/+/4814046

Change-Id: Ibbe95a342b21d16990809986a4b538999a81b3bb

(cherry picked from commit 5e24c21)

Bug: 1489169
Bug: b/280428326
Change-Id: Ib6ce36f5f1d17355600bf7119e8e9a034a4476fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4874416
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Joe Bartone <jbartone@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1205339}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4922573
Auto-Submit: Edmund Wright <edmundw@google.com>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/branch-heads/6045@{chromium#211}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
ecotopian pushed a commit to ecosia/chromium-android-browser that referenced this pull request Feb 12, 2024
@naeioi
[M111] mac: fix out-of-range checkfail in attributedSubstringForPropo…
f38ae0a 
…sedRange

(cherry picked from commit fde1524)

Bug: 1409669
Change-Id: I31afbea3af0433c6775532d5f35377d5b18935b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219617
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1101063}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4225791
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/branch-heads/5563@{chromium#211}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable pushed a commit that referenced this pull request Feb 27, 2024
@michaeldo1
[M123] Remove available device storage histograms and info from crash…
afe805f 
… reports

The values of the "NSURLVolume*" keys may no longer be sent off device
without explicit user consent as described in E174.1
Reference: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api#4278397

OBSOLETE_HISTOGRAMS=Removed because device storage numbers can no longer be sent off-device.
Bug: 327009133

(cherry picked from commit 3779d56)

Change-Id: Idc574679658e25f0a39cf668dd6ebaf6728b5f8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5304225
Reviewed-by: Ali Juma <ajuma@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1262511}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5324895
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/branch-heads/6312@{#211}
Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
gcjenkinson pushed a commit to chromium-cheri/chromium that referenced this pull request Mar 15, 2024
[M115][Files]: Eliminate extra space between trash and options
1ecc8f3 
In crrev.com/4521362 in order to hide search in trash while preserving
transition events the display: none was replaced with visibility: none.
This however upsets the layout of the files. In this CL we force the
button to occupy no additional space.
Video: http://screencast/cast/NTQ1NjgzMjgxOTYyNTk4NHw4OTMzZTdjMi1mZg

(cherry picked from commit 9bc6e51)

Bug: b:283932818
Change-Id: I2f8d2a750f26442c57beecb265239a443ac2f7cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4564176
Reviewed-by: Wenbo Jie <wenbojie@chromium.org>
Commit-Queue: Bo Majewski <majewski@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1148924}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569965
Cr-Commit-Position: refs/branch-heads/5790@{chromium#211}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
NaaeemMalik pushed a commit to SoftwarePrince/Egon-Chromium that referenced this pull request Mar 22, 2024
@mschillaci
[Auto-disable Accessibility] Speculative fix for onDisable asserts
de17ba9 
This is a speculative fix for a rare crash that is appearing in the
Canary channel. Since onDisable can come up to 5 seconds after a Tab
is hidden, which is also after usage statistics have been recorded, we
will wait to reset histogram state until onDisable finishes.

(cherry picked from commit bf4da41)

AX-Relnotes: N/A
Bug: 1472495, 1430202, b/265493191
Change-Id: Ie4e1e1568fc324cd8c758bbb75fac3ef19ad7d6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4777943
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Jocelyn Tran <jocelyntran@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1183191}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4784589
Reviewed-by: David Tseng <dtseng@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5938@{chromium#211}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable pushed a commit that referenced this pull request Mar 25, 2024
@brusshamilton
[M124] Disable k-anonymity enforcement of reporting for Facilitated T…
381cb64 
…esting

(cherry picked from commit 67d3586)

Bug: 330906102
Change-Id: I0ca771255354015f77d906cb0d4be6c35b29374b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5388696
Commit-Queue: Russ Hamilton <behamilton@google.com>
Auto-Submit: Russ Hamilton <behamilton@google.com>
Reviewed-by: Qingxin Wu <qingxinwu@google.com>
Commit-Queue: Qingxin Wu <qingxinwu@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1277075}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5387609
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/6367@{#211}
Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable pushed a commit that referenced this pull request Apr 22, 2024
Roll Chrome Win32 PGO Profile
4929cf4 
Roll Chrome Win32 PGO profile from chrome-win32-6422-1713763964-7fb7e4eb222f8df1c6de71562fee06d49bafa998-122fe18cfe278bbe2b13f48c280bc843749ab114.profdata to chrome-win32-6422-1713785808-c5a54cfe504e46e902a2e58905476fc4029ea63f-5e9bb5deef0aa4e17f5acee0a37e4a39d47575a0.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome-m125.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ib4c3c7fa595a95c25507b6c574fb2c4b7b34c0af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472184
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6422@{#211}
Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable pushed a commit that referenced this pull request May 18, 2024
Roll Chrome Mac Arm PGO Profile
46ab776 
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6478-1716046415-4887a09f988596b4c53410d26be491917d1854c5-106d6f99ab03cf0f3eac280b9e6684b1f3e866e8.profdata to chrome-mac-arm-6478-1716051484-9312af350e92d1bd7fe331d1dae7355da9fdd3b6-38b9014bf3b0324f7a11731982d4bfe190271323.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: pgo-profile-sheriffs@google.com
Change-Id: I655dcad69b367513ad84a63a1abd2a139d73ff3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5549030
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6478@{#211}
Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@vuittont60