119.0.6045.114
edmundwright
tagged this
03 Nov 23:48
Previously we were always returning 1 as our vertical offset, which meant bottom sheet infra never interpreted downward swipes on content view as attempts to drag down bottom sheet. This actually also made it hard to drag down from the toolbar, as if your finger continued into the content view it would not get interpreted correctly. This CL implements a short term solution for getting vertical offset, to avoid this issue. Bug: 1494354 Bug: 1496235 Bug: b/307709495 (cherry picked from commit ea9cc41eaf5108a6d78d40b2374516c49ada222a) Change-Id: I25cc59395c58e05c4c85a51f7219df34e5fe355c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4976147 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Auto-Submit: Edmund Wright <edmundw@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1215489} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5001644 Commit-Queue: Edmund Wright <edmundw@google.com> Reviewed-by: Kevin Grosu <kgrosu@google.com> Cr-Commit-Position: refs/branch-heads/6045@{#1203} Cr-Branched-From: 905e8bdd32d891451d94d1ec71682e989da2b0a1-refs/heads/main@{#1204232}
Assets 2
-
2023-11-03T23:48:48Z -
2023-11-03T23:48:48Z -