120.0.6099.193
OlivierLi
tagged this
02 Jan 19:09
The point of the check was to validate what was assumed an invariant. Crash reports are coming in at a rate that is high for crashes but extremely low in the context of the number of cookie operations. This is caused by the mojo operation returning a null string which can happen. If a null value is detected the code now falls back on using an IPC to request a new value. (cherry picked from commit 4178e369978d840981cbb446bb5cb861858f9ad2) Bug: 1393050, 1511021 Change-Id: I0bc52eed3799b95d73ec1f1c4c01665356b11f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5119481 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Olivier Li <olivierli@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1237641} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5155288 Commit-Queue: Francois Pierre Doray <fdoray@chromium.org> Commit-Queue: Prudhvikumar Bommana <pbommana@google.com> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Reviewed-by: Prudhvikumar Bommana <pbommana@google.com> Reviewed-by: Francois Pierre Doray <fdoray@chromium.org> Cr-Commit-Position: refs/branch-heads/6099@{#1663} Cr-Branched-From: e6ee4500f7d6549a9ac1354f8d056da49ef406be-refs/heads/main@{#1217362}
Assets 2
-
2024-01-02T19:09:35Z -
2024-01-02T19:09:35Z -