Skip to content

124.0.6367.10

@pbos pbos tagged this 20 Mar 22:41
The NOTREACHED() hit in extensions/renderer/dispatcher.cc was found as
we're seeing an increase in the extensions::ScriptContext::RunScript
signature but parts of the stack was ICF'd (where the NOTREACHED()
actually got hit).

To find this one we searched for all crash reports containing
extensions::ScriptContext::RunScript on the stack and then looking at
the error-message field. This essentially let us find if the
NOTREACHED() hit was ever reported in a build where NOTREACHED() logging
has not been optimized out, and if so which non-code-folded path hit it.

There was another hit instance for extensions::ScriptContext::RunScript
in extensions/renderer/api/web_request_hooks.cc but it has already been
marked DUMP_WILL_BE_NOTREACHED_NORETURN().

(cherry picked from commit 226693167d4abf3c04641e40db8ec8b493339759)

Bug: 40580068, 326252858, 326381645
Change-Id: I13f5a0a4fd3322642610d36bf9e8701bdeaa05b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5381318
Auto-Submit: Peter Boström <pbos@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1275180}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5381335
Cr-Commit-Position: refs/branch-heads/6367@{#51}
Cr-Branched-From: d158c6dc6e3604e6f899041972edf26087a49740-refs/heads/main@{#1274542}
Assets 2