125.0.6420.2
tburgin
tagged this
15 Apr 16:43
This reverts commit 28273753680514c44f30daba0f9115a3fcb6d7cb. Reason for revert: https://issues.chromium.org/issues/334384167 Original change's description: > immersive fullscreen: fix oom on window restore > > Restoring a fullscreen window that has an NSToolbar and an > NSTitlebarAccessoryViewController causes the key view loop to become > corrupted. The NSToolbar's view points to the > NSTitlebarAccessoryViewController's view in the key view loop. Under > certain circumstances this can cause an infinite loop leading to an OOM. > > This CL calls `-[NSWindow recalculateKeyViewLoop]` on the browser window > after a restore. This fixes the key view loop setting the NSToolbar's > view `-nextKeyView` to nil. > > Note: This bug stems from a workaround added because of FB12010731 > (NSTitlebarAccessoryViewController fullScreenMinHeight ignored). Once > that bug is fixed this workaround can be removed. > > For good completeness I have also reported this bug to Apple under > FB13724144 (restoring a fullscreen window that has an NSToolbar and an > NSTitlebarAccessoryViewController causes the key view loop to become > corrupted). Though we would prefer a fix for FB12010731. > > Bug: 324812653 > Change-Id: I813b049ec844e26c343395b7e99ff05808b3ffe8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5445152 > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Commit-Queue: Tom Burgin <bur@google.com> > Cr-Commit-Position: refs/heads/main@{#1286666} (cherry picked from commit 8db844043a67f827bf5560c7f91833ecce95244f) Bug: 324812653 Change-Id: I937217505332b9b0a185defff66d21b33264cde2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5451787 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Auto-Submit: Tom Burgin <bur@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1287321} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5454712 Reviewed-by: Tom Burgin <bur@google.com> Commit-Queue: Prudhvikumar Bommana <pbommana@google.com> Owners-Override: Prudhvikumar Bommana <pbommana@google.com> Cr-Commit-Position: refs/branch-heads/6420@{#5} Cr-Branched-From: df576e0dad8b00dea2749a08f0849c518fa28949-refs/heads/main@{#1287100}
Assets 2
-
2024-04-15T16:43:13Z -
2024-04-15T16:43:13Z -