Skip to content

125.0.6422.8

Opening Settings immediately crashes due to a failed CHECK where a
key in $i18n{} is not properly registered. The missing key is
"snapWindowLabel" which is not registered when the
OsSettingsRevampWayfinding and FasterSplitScreenSetup features are
both disabled.

This CL ensures the strings are always registered in load time data
regardless of the feature states. The feature feature visibility is
then controlled on the frontend.

(cherry picked from commit f2453b2014a5e7a82c626060823bfc3066ee73df)

Bug: b:334223004
Test: browser_tests --gtest_filter="*OSSettings*Personalization*"
Change-Id: I1a17c7dcd2315b6cdea39854f973c21a3f5e48fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463266
Commit-Queue: Wes Okuhara <wesokuhara@google.com>
Reviewed-by: Michele Fan <michelefan@chromium.org>
Reviewed-by: Sophie Wen <sophiewen@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1288957}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463744
Cr-Commit-Position: refs/branch-heads/6422@{#148}
Cr-Branched-From: 9012208d0ce02e0cf0adb9b62558627c356f3278-refs/heads/main@{#1287751}
Assets 2