Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option<T>::foo needs const& overloads when T is Copy #190

Closed
danakj opened this issue Jan 11, 2023 · 0 comments · Fixed by #251
Closed

Option<T>::foo needs const& overloads when T is Copy #190

danakj opened this issue Jan 11, 2023 · 0 comments · Fixed by #251
Labels
enhancement New feature or request
Milestone
0. Numerics

Comments

@danakj
Copy link
Collaborator

danakj commented Jan 11, 2023

For all &&-qualified methods we should provide a const&-qualified overload when T is Copy.

We can use deducing this (#176) to do this without overloads in the future.

This should block marking Option as stabilized, even though it would not be a breaking change?
@danakj danakj added the design Design of the library systems as a whole, such as concepts label Jan 11, 2023
@danakj danakj added this to the stable-numerics milestone Jan 11, 2023
@danakj danakj added enhancement New feature or request and removed design Design of the library systems as a whole, such as concepts labels Jan 11, 2023
@danakj danakj linked a pull request Jun 7, 2023 that will close this issue
Option copy overloads #251
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0. Numerics
Development

Successfully merging a pull request may close this issue.

Option copy overloads danakj/subspace
1 participant
@danakj