-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for browser-side navigation (PlzNavigate) #2290
Comments
Issue #1076 was marked as a duplicate of this issue. |
Issue #579 was marked as a duplicate of this issue. |
Other related complications:
|
|
The old navigation code path will be deleted from Chromium in mid-December: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/embedder-dev/9m0nieB320U/QSW9KWOQBQAJ |
The |
Fix bugs and test failures with browser-side navigation in master revision 69178d5 (bb) and 3239 branch revision ddfc3ed (bb). |
Original comment by Dave Simmons (Bitbucket: HarmlessDave, GitHub: HarmlessDave). OnBeforeBrowse issue: request->GetPostData always returns null in our tests. We used the POST data in the renderer OnBeforeNavigation to distinguish between different actions that use same server URL, and to extract other values. In some cases we delay or block navigations so OnBeforeResourceLoad is not an ideal substitute. Sample code to replicate in CEFClient: http://magpcss.org/ceforum/viewtopic.php?f=6&t=15750 If the Chromium docs say this event is working as intended, perhaps there is another pre-navigation event added by plzNavigate where the POST data does appear. |
Enable browser-side navigation by default and remove CefRenderHandler::OnBeforeNavigation in master revision de1bd28 (bb). |
Filed issue #2386 for @HarmlessDave 's comment above. |
Marking this issue as resolved because browser-side navigation is now enabled by default. Please find/file new issues for any additional problems or enhancements related to browser-side navigation. |
|
Original report by me.
Chromium's effort to move all navigation-related callbacks into the browser process (called PlzNavigate) has now been enabled by default in Chromium master [1]. We need to add support for this run mode in CEF.
Related discussion is occuring in https://crbug.com/776884.
[1] https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/4SU8Vw63quY/RMGyAto5BAAJ
The text was updated successfully, but these errors were encountered: