Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chrome: Add support for off-screen rendering #3293

Closed
magreenblatt opened this issue Mar 18, 2022 · 4 comments
Closed

chrome: Add support for off-screen rendering #3293

magreenblatt opened this issue Mar 18, 2022 · 4 comments
Labels
chrome Related to the Chrome runtime enhancement Enhancement request Framework Related to framework code or APIs osr Related to off-screen rendering

Comments

@magreenblatt
Copy link
Collaborator

Original report by me.

This issue involves the following functionality currently supported by the Alloy runtime:

  • Off-screen rendering (OSR) via CefWindowInfo.SetAsWindowless and CefRenderHandler

Most likely to be supported for the Chrome runtime via the Ozone layer (see issue #3263).

The following capabilities would need to be implemented in combination with OSR support:

  • File and JS dialog handlers (CefDialogHandler, CefJSDialogHandler; needed for DialogTest.*, JSDialogTest.*, LifeSpanTest.*; currently uses default Chrome dialogs).
  • Context menu custom runner (CefContextMenuHandler::RunContextMenu; currently uses default Chrome menu)

See issue #2969 for background on the Chrome runtime.
@magreenblatt
Copy link
Collaborator Author

  • edited description

1 similar comment
@magreenblatt
Copy link
Collaborator Author

  • edited description

@magreenblatt
Copy link
Collaborator Author

Use Chrome file dialogs on all platforms and runtimes (fixes issue #3314)

All file dialogs irrespective of source, platform and runtime will now be
routed through CefFileDialogManager and trigger CefDialogHandler callbacks
(see issue #3293).

Adds Chrome runtime support for CefBrowserHost::RunFileDialog and
CefDialogHandler callbacks.

Adds Alloy runtime support for internal GTK file and print dialogs on Linux
subject to the following limitations:

  1. Internal GTK implementation:
    • Cannot be used with multi-threaded-message-loop because Chromium's
      internal GTK implementation is not thread-safe (does not use GDK threads).
    • Dialogs will not be modal to application windows when used with off-screen
      rendering due to lack of access to the client's top-level GtkWindow.
  2. Cefclient CefDialogHandler implementation:
    • Cannot be used with Views because it requires a top-level GtkWindow.

Due to the above limitations no dialog implementation is currently provided for
Views + multi-threaded-message-loop on Linux. In cases where both
implementations are supported the cefclient version is now behind an optional
--use-client-dialogs command-line flag.

Expressly forbids multiple simultaneous file dialogs with the internal platform
implementation which uses modal dialogs. CefDialogHandler will still be notified
and can optionally handle each request without a modal dialog (see issue #3154).

Removes some RunFileDialog parameters that are not supported by the Chrome file
dialog implementation (selected_accept_filter parameter, cef_file_dialog_mode_t
overwrite/read-only flags).

→ <<cset 2ea7459a89fb (bb)>>

@magreenblatt magreenblatt added the osr Related to off-screen rendering label Mar 12, 2023
robincarlisle pushed a commit to robincarlisle/cef that referenced this issue Apr 28, 2023
@magreenblatt
Use Chrome file dialogs on all platforms and runtimes (fixes issue ch…
2ea7459 
…romiumembedded#3314)

All file dialogs irrespective of source, platform and runtime will now be
routed through CefFileDialogManager and trigger CefDialogHandler callbacks
(see issue chromiumembedded#3293).

Adds Chrome runtime support for CefBrowserHost::RunFileDialog and
CefDialogHandler callbacks.

Adds Alloy runtime support for internal GTK file and print dialogs on Linux
subject to the following limitations:

1. Internal GTK implementation:
   - Cannot be used with multi-threaded-message-loop because Chromium's
     internal GTK implementation is not thread-safe (does not use GDK threads).
   - Dialogs will not be modal to application windows when used with off-screen
     rendering due to lack of access to the client's top-level GtkWindow.
2. Cefclient CefDialogHandler implementation:
   - Cannot be used with Views because it requires a top-level GtkWindow.

Due to the above limitations no dialog implementation is currently provided for
Views + multi-threaded-message-loop on Linux. In cases where both
implementations are supported the cefclient version is now behind an optional
`--use-client-dialogs` command-line flag.

Expressly forbids multiple simultaneous file dialogs with the internal platform
implementation which uses modal dialogs. CefDialogHandler will still be notified
and can optionally handle each request without a modal dialog (see issue chromiumembedded#3154).

Removes some RunFileDialog parameters that are not supported by the Chrome file
dialog implementation (selected_accept_filter parameter, cef_file_dialog_mode_t
overwrite/read-only flags).
@amaitland amaitland mentioned this issue Jul 29, 2023
Closed
@magreenblatt magreenblatt mentioned this issue Apr 11, 2024
Open
@magreenblatt
Copy link
Collaborator Author

This will be completed in issue #3681 (OSR = Chrome bootstrap + Alloy style).

magreenblatt added a commit that referenced this issue Apr 22, 2024
@magreenblatt
chrome: Add support for Alloy style browsers and windows (see #3681)
dca0435 
Split the Alloy runtime into bootstrap and style components. Support
creation of Alloy style browsers and windows with the Chrome runtime.
Chrome runtime (`--enable-chrome-runtime`) + Alloy style
(`--use-alloy-style`) supports Views (`--use-views`), native parent
(`--use-native`) and windowless rendering
(`--off-screen-rendering-enabled`).

Print preview is supported in all cases except with windowless rendering
on all platforms and native parent on MacOS. It is disabled by default
with Alloy style for legacy compatibility. Where supported it can be
enabled or disabled globally using `--[enable|disable]-print-preview` or
configured on a per-RequestContext basis using the
`printing.print_preview_disabled` preference. It also behaves as
expected when triggered via the PDF viewer print button.

Chrome runtime + Alloy style behavior differs from Alloy runtime in the
following significant ways:

- Supports Chrome error pages by default.
- DevTools popups are Chrome style only (cannot be windowless).
- The Alloy extension API will not supported.

Chrome runtime + Alloy style passes all expected Alloy ceftests except
the following:

- `DisplayTest.AutoResize` (Alloy extension API not supported)
- `DownloadTest.*` (Download API not yet supported)
- `ExtensionTest.*` (Alloy extension API not supported)

This change also adds Chrome runtime support for
CefContextMenuHandler::RunContextMenu (see #3293).

This change also explicitly blocks (and doesn't retry) FrameAttached
requests from PDF viewer and print preview excluded frames (see #3664).

Known issues specific to Chrome runtime + Alloy style:
- DevTools popup with windowless rendering doesn't load successfully.
  Use windowed rendering or remote debugging as a workaround.
- Chrome style Window with Alloy style BrowserView (`--use-alloy-style
  --use-chrome-style-window`) does not show Chrome theme changes.

To test:
- Run `ceftests --enable-chrome-runtime --use-alloy-style
       [--use-chrome-style-window] [--use-views|--use-native]
       --gtest_filter=...`
- Run `cefclient --enable-chrome-runtime --use-alloy-style
       [--use-chrome-style-window]
       [--use-views|--use-native|--off-screen-rendering-enabled]`
- Run `cefsimple --enable-chrome-runtime --use-alloy-style [--use-views]`
@magreenblatt magreenblatt mentioned this issue Jul 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chrome Related to the Chrome runtime enhancement Enhancement request Framework Related to framework code or APIs osr Related to off-screen rendering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@magreenblatt