Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win: Include DirectX Compiler in binary distribution #3646

Closed
amaitland opened this issue Feb 9, 2024 · 2 comments
Closed

win: Include DirectX Compiler in binary distribution #3646

amaitland opened this issue Feb 9, 2024 · 2 comments
Labels
enhancement Enhancement request

Comments

@amaitland
Copy link
Contributor

Chrome started shipping with a DirectX compiler on Windows, it would be ideal if CEF could also include these files.

https://chromium-review.googlesource.com/c/chromium/src/+/4633008

I've had one report that WebGPU doesn't work properly without them. cefsharp/CefSharp#4662 (comment)
@amaitland amaitland added the enhancement Enhancement request label Feb 9, 2024
@magreenblatt
Copy link
Collaborator

The missing files are:

dxil.dll
dxcompiler.dll

@magreenblatt
Copy link
Collaborator

These DLLs are currently only available on Windows x64 (not x86 or arm64). See dawn_use_built_dxc GN arg.

magreenblatt added a commit that referenced this issue Feb 15, 2024
@magreenblatt
win: distrib: Add DirectX compiler binaries for WebGPU (fixes #3646)
f09a9bc
magreenblatt added a commit that referenced this issue Feb 15, 2024
@magreenblatt
win: distrib: Add DirectX compiler binaries for WebGPU (fixes #3646)
5c4a81b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amaitland @magreenblatt