upgrade react-hooks-plugin to v4.5.0 #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of
![image](https://private-user-images.githubusercontent.com/118760036/321684023-2f3fd892-ac3e-48e1-b351-e74c839f0b0e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgzOTUzMDMsIm5iZiI6MTcxODM5NTAwMywicGF0aCI6Ii8xMTg3NjAwMzYvMzIxNjg0MDIzLTJmM2ZkODkyLWFjM2UtNDhlMS1iMzUxLWU3NGM4MzlmMGIwZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYxNFQxOTU2NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yZjk3NTRiNDVhZjY2ZDczMmYzOTMxZDQ2NGNjOWU4MjVkYzYwZDFjOThhZDRkMjE5ZTFjZDBlNDUxMmVkNjY4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.SeEBqjdB1pLdv5F4-SJln8Sg1k3xZAQUaq2X3w98iAI)
react-hooks-plugin
has a bug where files with many conditionals are occasionally flagged as calling hooks conditionally. This frequently presents itself in theMetricDefEditorSidePanel
component:More details on the bug here: facebook/react#21328
This PR updates to v4.5.0 which should fix the bug.
Steps to verify:
eslint-config-chronograph
reponpm install
name
attribute inpackage.json
to"eslint-config-chronograph"
instead of"@chronograph-pe/eslint-config-chronograph"
. This is to match the package name incg-web
so that symlinking can work.npm link
cg-weg
npm link eslint-config-chronograph
npm run lint
should work as expected