Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossbow Hold Posing is non functional for MCDW crossbows in 3rd person #146

Closed
Kluzzio opened this issue Aug 25, 2022 · 1 comment
Closed
Assignees
Labels
Maybe a bug? Maybe not? Good for newcomers

Comments

@Kluzzio
Copy link
Collaborator

Kluzzio commented Aug 25, 2022

Describe the bug
The crossbow being held forward rather than down is not occuring with mcdw crossbows.

To Reproduce
Steps to reproduce the behavior:

  1. Spawn any mcdw crossbow.
  2. Hit F5 to enter 3rd person.
  3. Charge the crossbow.
  4. Observe crossbow pointing down

Expected behavior
Crossbow should be held in front of face same as vanilla

Screenshots
image

Please complete the following information:

  • OS: Windows
  • Launcher Dev
  • Mod Version Dev as of pre 5.0.0
  • Are you using a Modpack? Dev

Additional context
Thanks Sjorn Paradox for finding this. I believe the normal behavior is performed via CrossbowPosing.hold() method

@Kluzzio
Copy link
Collaborator Author

Kluzzio commented Aug 25, 2022

BipedEntityModel calls this in a switch statement in its positionLeftArm() method. Where any of this actual logic is done? Who knows

chronosacaria added a commit that referenced this issue Aug 30, 2022
 - Backport of fixes from 1.19
  - #146, #151, #152 and #153
 - Version Bump for 5.0.3-1.18 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maybe a bug? Maybe not? Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants