Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swagger for unstable OtelMetricsIngestion #21

Merged
merged 2 commits into from
May 10, 2024

Conversation

enisoc
Copy link
Member

@enisoc enisoc commented May 10, 2024

Note that I made some changes under tools/ to prevent otel-metrics-ingestion from being pluralized despite being a singleton. It appears that all the previous singletons had base entity names that were themselves plural, such as resource-pools and trace-tail-sampling-rules, because the singleton object semantically represented a list of multiple things (pools/rules).

By contrast, otel-metrics-ingestion is a pure singleton config that does not represent a list of anything, so it never makes sense to pluralize the name. Please let me know if there's a better way to achieve this.

@enisoc enisoc requested a review from a team as a code owner May 10, 2024 18:08
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Brandon Gonzalez <bg451@users.noreply.github.com>
@enisoc enisoc merged commit d54ef33 into main May 10, 2024
1 check passed
@enisoc enisoc deleted the enisoc/otel-metrics-ingestion branch May 10, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants