Apply lib.rs suggestions #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Apr 5, 2024
pitdicker
force-pushed
the
librs_suggestions
branch
from
3214ea2
to
b3079ef
Compare
pitdicker
force-pushed
the
librs_suggestions
branch
from
7666dc9
to
8cb3cc1
Compare
djc
approved these changes
Apr 5, 2024
|
Do you want to set up branch protection for this repository? |
|
Done. I've also set up the merge queue -- should probably do that for chrono, too. |
|
👍 What does a merge queue do? I'll look it up. |
|
It seems with a merge queue we can no longer use the rebase and merge strategy? |
|
The merge queue rebases by default -- the idea is that you can queue up PRs to merge concurrently and they'll run CI against the full set of other PRs that's queued to merge. You can still do merges by bypassing the merge queue (this will come up when you do a chrono version merge). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://lib.rs/~chronotope/dash.
Also fixed three more places that were using deprecated methods from chrono.