Merge 0.4.x, excluding #1113 #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force the `run` script to fail early using bash shell `set` options. Previously, errors before the last statement of the script would be ignored.
The script at the URL uses bash-isms. Previously `sh` was silently emitting an error but by luck was succeeding.
NFC fix most `yamllint` errors and warnings in `lint.yml` and `test.yml`.
Sanity check `date` command used in tests `try_verify_against_date_command` and `try_verify_against_date_command_format`. Make sure it's the kind of `data` command expected (accepts `--version`). Also, it's just good to print this for debugging purposes.
Print progress messages for human users watching this long-running test `try_verify_against_date_command`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are small but I wanted to do it now because I don't know if excluding #1113 will remain easy.